From 20f33dbd1031b6a79ceb12f469c95281e66d6e35 Mon Sep 17 00:00:00 2001
From: Nico Alt <nicoalt@posteo.org>
Date: Fri, 18 Dec 2020 19:59:37 +0100
Subject: [PATCH] Add some more comments on what to do in future for
refactoring
---
briar-gtk/briar_gtk/controllers/private_chat.py | 1 +
briar-gtk/briar_gtk/views/add_contact.py | 2 ++
briar-gtk/briar_gtk/views/login.py | 2 ++
briar-gtk/briar_gtk/views/private_chat.py | 2 ++
briar-gtk/briar_gtk/views/registration.py | 2 ++
briar-gtk/briar_gtk/views/sidebar.py | 2 ++
6 files changed, 11 insertions(+)
diff --git a/briar-gtk/briar_gtk/controllers/private_chat.py b/briar-gtk/briar_gtk/controllers/private_chat.py
index 652ad02..185a8b8 100644
--- a/briar-gtk/briar_gtk/controllers/private_chat.py
+++ b/briar-gtk/briar_gtk/controllers/private_chat.py
@@ -68,6 +68,7 @@ class PrivateChatController:
contact_name_label = self._builder.get_object("contact_name")
contact_name_label.set_text(user_alias)
self._sidebar_controller.refresh_contacts()
+ # TODO: Update name in chat history
def open_delete_all_messages_dialog(self):
if self._current_contact_id == 0:
diff --git a/briar-gtk/briar_gtk/views/add_contact.py b/briar-gtk/briar_gtk/views/add_contact.py
index f4cce01..76adb3a 100644
--- a/briar-gtk/briar_gtk/views/add_contact.py
+++ b/briar-gtk/briar_gtk/views/add_contact.py
@@ -14,6 +14,8 @@ from briar_gtk.define import APP, RESOURCES_DIR
class AddContactView(Gtk.Overlay):
+ # TODO: Move more logic into AddContactController
+
ADD_CONTACT_UI = "add_contact.ui"
STACK_NAME = "add_contact_flow_stack"
HEADERS_NAME = "add_contact_flow_headers"
diff --git a/briar-gtk/briar_gtk/views/login.py b/briar-gtk/briar_gtk/views/login.py
index 980bf9f..06e3dc7 100644
--- a/briar-gtk/briar_gtk/views/login.py
+++ b/briar-gtk/briar_gtk/views/login.py
@@ -13,6 +13,8 @@ from briar_gtk.define import APP, RESOURCES_DIR
class LoginView(Gtk.Overlay):
+ # TODO: Move more logic into LoginController
+
LOGIN_UI = "login.ui"
STACK_NAME = "login_flow_stack"
HEADERS_NAME = "login_flow_headers"
diff --git a/briar-gtk/briar_gtk/views/private_chat.py b/briar-gtk/briar_gtk/views/private_chat.py
index b1f25a9..a3071ad 100644
--- a/briar-gtk/briar_gtk/views/private_chat.py
+++ b/briar-gtk/briar_gtk/views/private_chat.py
@@ -18,6 +18,8 @@ from briar_gtk.widgets.private_message import PrivateMessageWidget
# pylint: disable=too-many-instance-attributes
class PrivateChatView(Gtk.Overlay):
+ # TODO: Move more logic into PrivateChatController
+
CONTAINER_UI = "private_chat.ui"
def __init__(self, builder):
diff --git a/briar-gtk/briar_gtk/views/registration.py b/briar-gtk/briar_gtk/views/registration.py
index 63aa300..4ef9246 100644
--- a/briar-gtk/briar_gtk/views/registration.py
+++ b/briar-gtk/briar_gtk/views/registration.py
@@ -13,6 +13,8 @@ from briar_gtk.define import APP, RESOURCES_DIR
class RegistrationView(Gtk.Overlay):
+ # TODO: Move more logic into RegistrationController
+
REGISTRATION_UI = "registration.ui"
STACK_NAME = "registration_flow_stack"
HEADERS_NAME = "registration_flow_headers"
diff --git a/briar-gtk/briar_gtk/views/sidebar.py b/briar-gtk/briar_gtk/views/sidebar.py
index 678a87f..a3146a0 100644
--- a/briar-gtk/briar_gtk/views/sidebar.py
+++ b/briar-gtk/briar_gtk/views/sidebar.py
@@ -7,6 +7,8 @@ from briar_gtk.widgets.contact_row import ContactRowWidget
class SidebarView:
+ # TODO: Move more logic into SidebarController
+
def __init__(self, builder):
self._builder = builder
--
GitLab