diff --git a/.pylintrc b/.pylintrc index 5fde3fa31c47e51a6d5532bf0314e370d8b3b5f2..677f121a460f5b26dc3b3a1d5fa1bb2f52eebf18 100644 --- a/.pylintrc +++ b/.pylintrc @@ -8,4 +8,5 @@ disable=attribute-defined-outside-init, duplicate-code, fixme, missing-docstring, + no-name-in-module, wrong-import-position diff --git a/briar-gtk/briar_gtk/actions/actions.py b/briar-gtk/briar_gtk/actions/actions.py index 4b34067cca0e924b0b133e6d5916386040227972..3bd4961ad7edc9df531ab1cf2f4288ee45b0a0ff 100644 --- a/briar-gtk/briar_gtk/actions/actions.py +++ b/briar-gtk/briar_gtk/actions/actions.py @@ -11,7 +11,8 @@ class Actions: def __init__(self, widget): self.widget = widget - def _create_action(self, key, parameter, callback): + @staticmethod + def _create_action(key, parameter, callback): action = Gio.SimpleAction.new(key, parameter) action.connect("activate", callback) return action diff --git a/briar-gtk/briar_gtk/actions/login.py b/briar-gtk/briar_gtk/actions/login.py index 549904ae42c20c96f87660a0840fb3d3be712535..42a0caed8d73e8d7cf933201106b22f945522199 100644 --- a/briar-gtk/briar_gtk/actions/login.py +++ b/briar-gtk/briar_gtk/actions/login.py @@ -23,4 +23,4 @@ class LoginActions(Actions): # pylint: disable=unused-argument def _login(self, action, parameter): - self.widget._on_login_pressed() + self.widget.on_login_pressed() diff --git a/briar-gtk/briar_gtk/containers/login.py b/briar-gtk/briar_gtk/containers/login.py index dcc229f51e3ec28398b2f316203add5cec344c28..7caff0bb7a52b102ad79e5cfbf53ae435e092bf4 100644 --- a/briar-gtk/briar_gtk/containers/login.py +++ b/briar-gtk/briar_gtk/containers/login.py @@ -37,7 +37,9 @@ class LoginContainer(Container): def _setup_login_flow_headers(self): login_flow_headers = self.builder.get_object(self.HEADERS_NAME) login_flow_headers.show_all() - login_flow_headers.insert_action_group("login", self.get_action_group("login")) + login_flow_headers.insert_action_group( + "login", self.get_action_group("login") + ) self._window.set_titlebar(login_flow_headers) def _setup_enter_listener(self): @@ -46,10 +48,9 @@ class LoginContainer(Container): # pylint: disable=unused-argument def _on_password_enter(self, widget): - self._on_login_pressed() + self.on_login_pressed() - # pylint: disable=unused-argument - def _on_login_pressed(self): + def on_login_pressed(self): self._show_loading_animation() self._login()