From cfcb711efa5ee7bbc1f2db24bfe2df248c900b80 Mon Sep 17 00:00:00 2001
From: Nico Alt <nicoalt@posteo.org>
Date: Fri, 27 Mar 2020 12:00:01 +0000
Subject: [PATCH] Make lint happy
---
.pylintrc | 1 +
briar-gtk/briar_gtk/actions/actions.py | 3 ++-
briar-gtk/briar_gtk/actions/login.py | 2 +-
briar-gtk/briar_gtk/containers/login.py | 9 +++++----
4 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/.pylintrc b/.pylintrc
index 5fde3fa..677f121 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -8,4 +8,5 @@ disable=attribute-defined-outside-init,
duplicate-code,
fixme,
missing-docstring,
+ no-name-in-module,
wrong-import-position
diff --git a/briar-gtk/briar_gtk/actions/actions.py b/briar-gtk/briar_gtk/actions/actions.py
index 4b34067..3bd4961 100644
--- a/briar-gtk/briar_gtk/actions/actions.py
+++ b/briar-gtk/briar_gtk/actions/actions.py
@@ -11,7 +11,8 @@ class Actions:
def __init__(self, widget):
self.widget = widget
- def _create_action(self, key, parameter, callback):
+ @staticmethod
+ def _create_action(key, parameter, callback):
action = Gio.SimpleAction.new(key, parameter)
action.connect("activate", callback)
return action
diff --git a/briar-gtk/briar_gtk/actions/login.py b/briar-gtk/briar_gtk/actions/login.py
index 549904a..42a0cae 100644
--- a/briar-gtk/briar_gtk/actions/login.py
+++ b/briar-gtk/briar_gtk/actions/login.py
@@ -23,4 +23,4 @@ class LoginActions(Actions):
# pylint: disable=unused-argument
def _login(self, action, parameter):
- self.widget._on_login_pressed()
+ self.widget.on_login_pressed()
diff --git a/briar-gtk/briar_gtk/containers/login.py b/briar-gtk/briar_gtk/containers/login.py
index dcc229f..7caff0b 100644
--- a/briar-gtk/briar_gtk/containers/login.py
+++ b/briar-gtk/briar_gtk/containers/login.py
@@ -37,7 +37,9 @@ class LoginContainer(Container):
def _setup_login_flow_headers(self):
login_flow_headers = self.builder.get_object(self.HEADERS_NAME)
login_flow_headers.show_all()
- login_flow_headers.insert_action_group("login", self.get_action_group("login"))
+ login_flow_headers.insert_action_group(
+ "login", self.get_action_group("login")
+ )
self._window.set_titlebar(login_flow_headers)
def _setup_enter_listener(self):
@@ -46,10 +48,9 @@ class LoginContainer(Container):
# pylint: disable=unused-argument
def _on_password_enter(self, widget):
- self._on_login_pressed()
+ self.on_login_pressed()
- # pylint: disable=unused-argument
- def _on_login_pressed(self):
+ def on_login_pressed(self):
self._show_loading_animation()
self._login()
--
GitLab