From febea2300092f40785c95b3f6b2c37e5c8a31abe Mon Sep 17 00:00:00 2001
From: Nico Alt <nicoalt@posteo.org>
Date: Tue, 29 Dec 2020 12:00:00 +0000
Subject: [PATCH] Make lint happy
---
briar-gtk/briar_gtk/actions/window.py | 11 +++++++----
briar-gtk/briar_gtk/presenters/__init__.py | 3 ++-
briar-gtk/briar_gtk/widgets/edit_dialog.py | 11 ++++++-----
briar-gtk/briar_gtk/window.py | 2 --
4 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/briar-gtk/briar_gtk/actions/window.py b/briar-gtk/briar_gtk/actions/window.py
index d2beb9b..71f01f2 100644
--- a/briar-gtk/briar_gtk/actions/window.py
+++ b/briar-gtk/briar_gtk/actions/window.py
@@ -65,13 +65,14 @@ class WindowActions(Actions):
# pylint: disable=unused-argument
def _back_to_sidebar(self, action, parameter):
if not isinstance(self.widget.current_view, MainWindowView):
- return # No Exception thrown because shortcut may come from other view
+ return # No Exception because shortcut can come from other view
self.widget.current_view.presenter.close_private_chat()
# pylint: disable=unused-argument
def _delete_all_messages_dialog(self, action, parameter):
if not isinstance(self.widget.current_view, MainWindowView):
- raise Exception("Should delete all messages only from MainWindowView")
+ raise Exception(
+ "Should delete all messages only from MainWindowView")
self.widget.current_view.presenter.open_delete_all_messages_dialog()
# pylint: disable=unused-argument
@@ -103,5 +104,7 @@ class WindowActions(Actions):
# pylint: disable=unused-argument
def _open_private_chat(self, action, contact_id):
if not isinstance(self.widget.current_view, MainWindowView):
- raise Exception("Should open private chat only from MainWindowView")
- self.widget.current_view.presenter.open_private_chat(contact_id.get_int32())
+ raise Exception(
+ "Should open private chat only from MainWindowView")
+ self.widget.current_view.presenter.open_private_chat(
+ contact_id.get_int32())
diff --git a/briar-gtk/briar_gtk/presenters/__init__.py b/briar-gtk/briar_gtk/presenters/__init__.py
index d793e06..5ad73fc 100644
--- a/briar-gtk/briar_gtk/presenters/__init__.py
+++ b/briar-gtk/briar_gtk/presenters/__init__.py
@@ -2,5 +2,6 @@
# SPDX-License-Identifier: AGPL-3.0-only
# License-Filename: LICENSE.md
"""
-Presenters (of MVP pattern) reacting to user input and model/data updates in Briar GTK
+Presenters (of MVP pattern) reacting to user input and model/data updates
+in Briar GTK
"""
diff --git a/briar-gtk/briar_gtk/widgets/edit_dialog.py b/briar-gtk/briar_gtk/widgets/edit_dialog.py
index f70a293..622c273 100644
--- a/briar-gtk/briar_gtk/widgets/edit_dialog.py
+++ b/briar-gtk/briar_gtk/widgets/edit_dialog.py
@@ -7,6 +7,7 @@ from gi.repository import Gtk
class EditDialog(Gtk.Dialog):
+
def __init__(self, parent: "Gtk.Window", flags: "Gtk.DialogFlags",
placeholder: str, text: str = ""):
Gtk.Dialog.__init__(
@@ -22,17 +23,17 @@ class EditDialog(Gtk.Dialog):
)
self.set_default_size(150, 100)
- self.__alias_entry = Gtk.Entry()
- self.__alias_entry.set_text(placeholder)
- self.__alias_entry.set_size_request(250, 0)
+ self._alias_entry = Gtk.Entry()
+ self._alias_entry.set_text(placeholder)
+ self._alias_entry.set_size_request(250, 0)
dialog_box = self.get_content_area()
dialog_text = Gtk.Label(label=text)
dialog_box.add(dialog_text)
- dialog_box.add(self.__alias_entry)
+ dialog_box.add(self._alias_entry)
self.show_all()
def get_entry(self) -> "Gtk.Entry":
- return self.__alias_entry
+ return self._alias_entry
diff --git a/briar-gtk/briar_gtk/window.py b/briar-gtk/briar_gtk/window.py
index 6401f15..f72ba09 100644
--- a/briar-gtk/briar_gtk/window.py
+++ b/briar-gtk/briar_gtk/window.py
@@ -2,8 +2,6 @@
# SPDX-License-Identifier: AGPL-3.0-only
# License-Filename: LICENSE.md
-import os
-
from gettext import gettext as _
from gi.repository import Gio, Gtk
--
GitLab