Briar GTK issueshttps://code.briarproject.org/briar/briar-gtk/-/issues2021-04-20T23:36:56Zhttps://code.briarproject.org/briar/briar-gtk/-/issues/100RuntimeError: Requests dependency 'chardet' must be version >= 3.0.2, < 3.1.0!2021-04-20T23:36:56ZJohn KennedyRuntimeError: Requests dependency 'chardet' must be version >= 3.0.2, < 3.1.0!I've been getting this error for a couple of weeks while trying to build on Arch (both stable and git).
`RuntimeError: Requests dependency 'chardet' must be version >= 3.0.2, < 3.1.0!`I've been getting this error for a couple of weeks while trying to build on Arch (both stable and git).
`RuntimeError: Requests dependency 'chardet' must be version >= 3.0.2, < 3.1.0!`https://code.briarproject.org/briar/briar-gtk/-/issues/76Handle error when adding pending contact2021-03-09T10:34:35ZNicoHandle error when adding pending contactFound by @grote in https://code.briarproject.org/briar/python-briar-wrapper/-/issues/19.
We should definitely fix this in the next release. For now, all we seem to be able to do is tell users about the failure. Once https://code.briarpr...Found by @grote in https://code.briarproject.org/briar/python-briar-wrapper/-/issues/19.
We should definitely fix this in the next release. For now, all we seem to be able to do is tell users about the failure. Once https://code.briarproject.org/briar/briar/-/issues/1825 is done, we can offer ways to fix the error.
When implementing this issue, we have to keep in mind that attackers might want to know if a user already has a contact, i.e. exploring the contacts relationships of the targeted user.
In general Briar GTK should start to properly handle errors. When doing this, the documentation of Briar Headless should be improved, too.GTK 0.1.0-beta3NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/89Stay at top when entering second line in chat input2021-03-07T13:24:23ZNicoStay at top when entering second line in chat inputCurrently it scrolls down, hiding the first line.Currently it scrolls down, hiding the first line.GTK 0.1.0-beta3NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/92Support sending messages with numpad enter2021-03-07T12:32:57ZNicoSupport sending messages with numpad enterCurrently only the "main" enter key leads to messages being sent.
Currently:
* https://code.briarproject.org/briar/briar-gtk/-/blob/a46245005fdd2d65bb05b6766325d025dd70544a/briar-gtk/briar_gtk/private_chat/private_chat_presenter.py#L193...Currently only the "main" enter key leads to messages being sent.
Currently:
* https://code.briarproject.org/briar/briar-gtk/-/blob/a46245005fdd2d65bb05b6766325d025dd70544a/briar-gtk/briar_gtk/private_chat/private_chat_presenter.py#L193
* https://code.briarproject.org/briar/briar-gtk/-/blob/a46245005fdd2d65bb05b6766325d025dd70544a/briar-gtk/briar_gtk/private_chat/private_chat_presenter.py#L273
Formerly: https://code.briarproject.org/briar/briar-gtk/-/blob/0.1.0-beta2/briar-gtk/briar_gtk/containers/main_window.py#L187GTK 0.1.0-beta3NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/93Current contact not always highlighted2021-03-07T12:13:21ZNicoCurrent contact not always highlightedSometimes the chat is open but no contact is highlighted in the sidebar.Sometimes the chat is open but no contact is highlighted in the sidebar.GTK 0.1.0-beta3NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/91Slows down with large amount of messages saved2021-01-23T13:49:41ZBen ArmsteadSlows down with large amount of messages savedReporting a minor bug.
After 2-3 weeks of regular messaging via briar-gtk with a contact, and click on the contact (which now has a large amount of messages (Im not sure maybe a few thousand)).
The program hangs for about 1-2 seconds ...Reporting a minor bug.
After 2-3 weeks of regular messaging via briar-gtk with a contact, and click on the contact (which now has a large amount of messages (Im not sure maybe a few thousand)).
The program hangs for about 1-2 seconds (which I am pretty confident is due to loading in the large amount of messages?).
In line with my theory the more messages that are sent the slower it is to open the contact from the main menu.
Would it be possible to load in e.g. 50 messages at a time and then only load in the others if I scroll back enough to need to see them instead of loading in all the messages at the same time?
(Deleting all of the messages with the contact solves the problem and I instantly load into a chat with them without the few seconds wait).
I am willing to help with the python programming of this, but have less experience with GTK.
As always thanks for the great work!https://code.briarproject.org/briar/briar-gtk/-/issues/47Only reload contact list on changes2021-01-23T13:49:22ZNicoOnly reload contact list on changesCurrently, it's reloaded every time a message arrived, which produces a flickering list because for a tiny amount of time the selected contact gets unselected.Currently, it's reloaded every time a message arrived, which produces a flickering list because for a tiny amount of time the selected contact gets unselected.https://code.briarproject.org/briar/briar-gtk/-/issues/90Briar too big for resolution 1366x7682021-01-23T13:40:50ZdanBriar too big for resolution 1366x768The right part is missing, cant delete contact etc.
Briar v0.1.0-beta2 master x86_64 gtk-originThe right part is missing, cant delete contact etc.
Briar v0.1.0-beta2 master x86_64 gtk-originhttps://code.briarproject.org/briar/briar-gtk/-/issues/78Notification counter stays even when msg has been seen2021-01-23T13:40:43ZdanNotification counter stays even when msg has been seenNotification doesnt go away. ![briar.notif](/uploads/565826097a0162211009d7e70c70576f/briar.notif.png)
The only way to make the notification go away, is to send a msg.
flatpak v0.1.0-beta2Notification doesnt go away. ![briar.notif](/uploads/565826097a0162211009d7e70c70576f/briar.notif.png)
The only way to make the notification go away, is to send a msg.
flatpak v0.1.0-beta2GTK Nexthttps://code.briarproject.org/briar/briar-gtk/-/issues/48Reliably scroll down for new messages2021-01-23T13:40:26ZNicoReliably scroll down for new messagesAs of now, every time a new message arrives in a private chat the list should scroll down. This doesn't work reliably because the message needs to be rendered before adjustment has effects; the used `idle_add()` does not always work to w...As of now, every time a new message arrives in a private chat the list should scroll down. This doesn't work reliably because the message needs to be rendered before adjustment has effects; the used `idle_add()` does not always work to wait for the rendering.
This may become unnecessary with #40.GTK Nexthttps://code.briarproject.org/briar/briar-gtk/-/issues/85Shows first sent messages rather than latest2021-01-11T08:05:19ZBen ArmsteadShows first sent messages rather than latestReporting a possible bug.
Not sure if anybody else has experienced this?
Every time I click on e.g. contact1, i am put at the top of the messages list (so I see the first messages that were ever sent to contact1, rather than the most re...Reporting a possible bug.
Not sure if anybody else has experienced this?
Every time I click on e.g. contact1, i am put at the top of the messages list (so I see the first messages that were ever sent to contact1, rather than the most recent ones).
I am using briar via the AUR so this might be an AUR only problem, as it did not occur when I was on debian a few days ago.
I was wondering if anybody else was experiencing this?https://code.briarproject.org/briar/briar-gtk/-/issues/81Improve line wrapping in messages2021-01-06T14:41:28ZNicoImprove line wrapping in messagesA user reported a bug I had in mind once but forgot about: messages consisting of one very large "word" don't get wrapped in the chat history. By sending a very large sequence of characters without spaces etc. you can essentially explode...A user reported a bug I had in mind once but forgot about: messages consisting of one very large "word" don't get wrapped in the chat history. By sending a very large sequence of characters without spaces etc. you can essentially explode your window width.
Seems like this is really easy to fix: in [_briar-gtk/briar_gtk/widgets/private_message.py#L121_](https://code.briarproject.org/briar/briar-gtk/-/blob/154be3dcfe2c93f5cf66f25f1b356e54653175a1/briar-gtk/briar_gtk/widgets/private_message.py#L121) all we have to do is to add a new code line calling [`body_content.set_line_wrap_mode()`](https://lazka.github.io/pgi-docs/#Gtk-3.0/classes/Label.html#Gtk.Label.set_line_wrap_mode) with [`Pango.WrapMode.WORD_CHAR `](https://lazka.github.io/pgi-docs/#Pango-1.0/enums.html#Pango.WrapMode.WORD_CHAR).GTK 0.1.0-beta3https://code.briarproject.org/briar/briar-gtk/-/issues/84Use Briar blue instead of theme selected color2020-12-16T14:02:59ZNicoUse Briar blue instead of theme selected colorCurrently we use [`@theme_selected_bg_color`](https://code.briarproject.org/briar/briar-gtk/-/blob/154be3dcfe2c93f5cf66f25f1b356e54653175a1/briar-gtk/data/ui/application.css#L67) for things like usernames. This is mostly blue, but on e.g...Currently we use [`@theme_selected_bg_color`](https://code.briarproject.org/briar/briar-gtk/-/blob/154be3dcfe2c93f5cf66f25f1b356e54653175a1/briar-gtk/data/ui/application.css#L67) for things like usernames. This is mostly blue, but on e.g. Linux Mint it's green. There, the difference between own and their usernames is not visible that much, because both names are colored in green. We should use the Briar blue code instead, so that we have blue-green on all platforms.GTK 0.1.0-beta3x0lootsx0lootshttps://code.briarproject.org/briar/briar-gtk/-/issues/67Don't allow sending empty messages2020-09-23T08:14:36ZNicoDon't allow sending empty messagesLooks really weird and empty messages get filtered out anyway on the other side.Looks really weird and empty messages get filtered out anyway on the other side.GTK 0.1.0-beta2NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/62Refresh contact list when sending messages2020-09-09T11:47:03ZNicoRefresh contact list when sending messagesAlthough after sending a message that contact should be at the top of the list, it's currently not.Although after sending a message that contact should be at the top of the list, it's currently not.GTK 0.1.0-beta1NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/60Contacts don't get deleted reliably2020-09-08T17:17:27ZNicoContacts don't get deleted reliablySteps to reproduce:
* Open private chat with contact
* Click to delete them
* Click + to add new contact
Expected:
* Contact gets deleted
Actually:
```bash
(Briar:3): Handy-CRITICAL **: 17:49:00.203: hdy_stackable_box_set_visible_child...Steps to reproduce:
* Open private chat with contact
* Click to delete them
* Click + to add new contact
Expected:
* Contact gets deleted
Actually:
```bash
(Briar:3): Handy-CRITICAL **: 17:49:00.203: hdy_stackable_box_set_visible_child: assertion 'contains_child' failed
Traceback (most recent call last):
File "/app/share/briar-gtk/briar_gtk/widgets/undo_notification.py", line 57, in _on_destroy
action()
File "/app/share/briar-gtk/briar_gtk/containers/main_window.py", line 99, in _timeout_action
self.show_sidebar()
File "/app/share/briar-gtk/briar_gtk/containers/main_window.py", line 85, in show_sidebar
self.chat_view.hide()
AttributeError: 'NoneType' object has no attribute 'hide'
```
Maybe we shouldn't do this "Undo" thing at all...GTK 0.1.0-beta1NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/61Use 24h format for times in messages2020-09-08T17:03:18ZNicoUse 24h format for times in messagesCurrently we leave that out, making it unclear whether it's a.m./p.m.Currently we leave that out, making it unclear whether it's a.m./p.m.GTK 0.1.0-beta1https://code.briarproject.org/briar/briar-gtk/-/issues/58Tell Python from where to import dependencies2020-08-31T06:35:25ZNicoTell Python from where to import dependenciesA user had huge problems installing Briar GTK as .debs, because they also had installed previous versions of `briar_wrapper` with _pip_. They installed the latest versions of all .debs, but nevertheless got a warning due to an outdated v...A user had huge problems installing Briar GTK as .debs, because they also had installed previous versions of `briar_wrapper` with _pip_. They installed the latest versions of all .debs, but nevertheless got a warning due to an outdated version of `briar_wrapper`. Instead of using the newer .deb version in _/usr/lib/python3/dist-packages/briar_wrapper_, Briar GTK imported `briar_wrapper` from _/usr/**local**/lib/python3.8/dist-packages/briar_wrapper_, which was the old version from *pip*.https://code.briarproject.org/briar/briar-gtk/-/issues/2Repair pytest on GitLab CI2020-07-19T13:59:52ZNicoRepair pytest on GitLab CISince fc91cbd8dac3db4dd8965b7ef1662b63bad047f6, _pytest_ fails on GitLab CI. Locally, everything works fine for me. [This is the first job](https://code.briarproject.org/nicoalt/briar-gtk/-/jobs/3893) failing for this commit:
```
$ tool...Since fc91cbd8dac3db4dd8965b7ef1662b63bad047f6, _pytest_ fails on GitLab CI. Locally, everything works fine for me. [This is the first job](https://code.briarproject.org/nicoalt/briar-gtk/-/jobs/3893) failing for this commit:
```
$ tools/tests/test-pytest.sh
============================= test session starts ==============================
platform linux -- Python 3.7.3, pytest-5.2.0, py-1.8.0, pluggy-0.13.0
rootdir: /builds/nicoalt/briar-gtk, inifile: pytest.ini
plugins: cov-2.7.1, mock-1.11.0, requests-mock-1.7.0
collected 20 items
tests/briar/api/test_constants.py .... [ 20%]
tests/briar/api/models/test_contacts.py . [ 25%]
tests/briar/api/models/test_private_chat.py .. [ 35%]
tests/briar/gtk/test_application.py .....tools/tests/test-pytest.sh: line 6: 4406 Trace/breakpoint trap (core dumped) PYTHONPATH=src pytest --cov=src tests/
ERROR: Job failed: exit code 1
```
Until this is fixed, I allowed the pipeline to fail with d519ebc7aa5e0d3ed76cba2a424c4e64acf4397a.GTK 0.1.0-alpha2https://code.briarproject.org/briar/briar-gtk/-/issues/55Contact's name not showing in private messages2020-07-18T16:43:57ZNicoContact's name not showing in private messagesThe [following code](https://code.briarproject.org/briar/briar-gtk/-/blob/f9c25591c9f7b5db8c214ea88364aa17138be974/briar-gtk/briar_gtk/containers/main_window.py#L116) is buggy:
```python
def _get_contact_name(self, contact_id):
...The [following code](https://code.briarproject.org/briar/briar-gtk/-/blob/f9c25591c9f7b5db8c214ea88364aa17138be974/briar-gtk/briar_gtk/containers/main_window.py#L116) is buggy:
```python
def _get_contact_name(self, contact_id):
name = ""
for contact in self.contacts_list:
if contact["contactId"] is contact_id:
name = contact["author"]["name"]
if "alias" in contact:
name = contact["alias"]
break
return name
```
It's fixed by doing
```diff
def _get_contact_name(self, contact_id):
name = ""
for contact in self.contacts_list:
- if contact["contactId"] is contact_id:
+ if contact["contactId"] == contact_id:
name = contact["author"]["name"]
if "alias" in contact:
name = contact["alias"]
break
return name
```GTK 0.1.0-alpha2NicoNico