Briar GTK issueshttps://code.briarproject.org/briar/briar-gtk/-/issues2020-07-18T16:43:57Zhttps://code.briarproject.org/briar/briar-gtk/-/issues/56Don't expect messages to always have text2020-07-18T16:43:57ZTorsten GroteDon't expect messages to always have textSome messages are notices that don't carry any text (responses to forum invitations for example).
```
Traceback (most recent call last):
File "/usr/share/briar-gtk/briar_gtk/containers/private_chat.py", line 101, in _add_message
m...Some messages are notices that don't carry any text (responses to forum invitations for example).
```
Traceback (most recent call last):
File "/usr/share/briar-gtk/briar_gtk/containers/private_chat.py", line 101, in _add_message
message_widget = PrivateMessageWidget(self._contact_name, message)
File "/usr/share/briar-gtk/briar_gtk/widgets/private_message.py", line 18, in __init__
self._setup_view(contact_name, message)
File "/usr/share/briar-gtk/briar_gtk/widgets/private_message.py", line 34, in _setup_view
message["text"])
KeyError: 'text'
```GTK 0.1.0-alpha2NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/55Contact's name not showing in private messages2020-07-18T16:43:57ZNicoContact's name not showing in private messagesThe [following code](https://code.briarproject.org/briar/briar-gtk/-/blob/f9c25591c9f7b5db8c214ea88364aa17138be974/briar-gtk/briar_gtk/containers/main_window.py#L116) is buggy:
```python
def _get_contact_name(self, contact_id):
...The [following code](https://code.briarproject.org/briar/briar-gtk/-/blob/f9c25591c9f7b5db8c214ea88364aa17138be974/briar-gtk/briar_gtk/containers/main_window.py#L116) is buggy:
```python
def _get_contact_name(self, contact_id):
name = ""
for contact in self.contacts_list:
if contact["contactId"] is contact_id:
name = contact["author"]["name"]
if "alias" in contact:
name = contact["alias"]
break
return name
```
It's fixed by doing
```diff
def _get_contact_name(self, contact_id):
name = ""
for contact in self.contacts_list:
- if contact["contactId"] is contact_id:
+ if contact["contactId"] == contact_id:
name = contact["author"]["name"]
if "alias" in contact:
name = contact["alias"]
break
return name
```GTK 0.1.0-alpha2NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/51Support copying content in messages2020-07-18T16:43:57ZnomaneSupport copying content in messagesNot sure if specific to OS, but after testing in Qubes-Whonix workstation I noticed copying messages was not working/supportedNot sure if specific to OS, but after testing in Qubes-Whonix workstation I noticed copying messages was not working/supportedGTK 0.1.0-alpha2NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/39Create Debian package2021-02-01T12:26:13ZNicoCreate Debian packageFor later inclusion in Debian (https://code.briarproject.org/briar/briar-gtk/issues/38), we most likely need a separate package for _python-briar-wrapper_ (https://code.briarproject.org/briar/python-briar-wrapper/issues/14) and briar-hea...For later inclusion in Debian (https://code.briarproject.org/briar/briar-gtk/issues/38), we most likely need a separate package for _python-briar-wrapper_ (https://code.briarproject.org/briar/python-briar-wrapper/issues/14) and briar-headless (https://code.briarproject.org/briar/briar/-/issues/1739). Also, Briar Headless should not ship its own Tor binary but use Debian's one (https://code.briarproject.org/briar/python-briar-wrapper/issues/15).GTK 0.1.0-alpha2NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/19Show online status of contacts in contact list2020-07-18T16:31:40ZNicoShow online status of contacts in contact listRelated to https://code.briarproject.org/briar/briar-gtk/issues/20.Related to https://code.briarproject.org/briar/briar-gtk/issues/20.GTK 0.1.0-alpha2NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/2Repair pytest on GitLab CI2020-07-19T13:59:52ZNicoRepair pytest on GitLab CISince fc91cbd8dac3db4dd8965b7ef1662b63bad047f6, _pytest_ fails on GitLab CI. Locally, everything works fine for me. [This is the first job](https://code.briarproject.org/nicoalt/briar-gtk/-/jobs/3893) failing for this commit:
```
$ tool...Since fc91cbd8dac3db4dd8965b7ef1662b63bad047f6, _pytest_ fails on GitLab CI. Locally, everything works fine for me. [This is the first job](https://code.briarproject.org/nicoalt/briar-gtk/-/jobs/3893) failing for this commit:
```
$ tools/tests/test-pytest.sh
============================= test session starts ==============================
platform linux -- Python 3.7.3, pytest-5.2.0, py-1.8.0, pluggy-0.13.0
rootdir: /builds/nicoalt/briar-gtk, inifile: pytest.ini
plugins: cov-2.7.1, mock-1.11.0, requests-mock-1.7.0
collected 20 items
tests/briar/api/test_constants.py .... [ 20%]
tests/briar/api/models/test_contacts.py . [ 25%]
tests/briar/api/models/test_private_chat.py .. [ 35%]
tests/briar/gtk/test_application.py .....tools/tests/test-pytest.sh: line 6: 4406 Trace/breakpoint trap (core dumped) PYTHONPATH=src pytest --cov=src tests/
ERROR: Job failed: exit code 1
```
Until this is fixed, I allowed the pipeline to fail with d519ebc7aa5e0d3ed76cba2a424c4e64acf4397a.GTK 0.1.0-alpha2