Briar GTK issueshttps://code.briarproject.org/briar/briar-gtk/-/issues2020-12-31T12:06:36Zhttps://code.briarproject.org/briar/briar-gtk/-/issues/27Refactor code2020-12-31T12:06:36ZNicoRefactor codeSo far, the code has grown organically. We should refactor the code to reduce duplication and improve maintainability.
#### Useful links
* https://refactoring.guruSo far, the code has grown organically. We should refactor the code to reduce duplication and improve maintainability.
#### Useful links
* https://refactoring.guruGTK 0.1.0-beta3NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/70Limit input width just like message texts width2020-12-31T12:05:26ZNicoLimit input width just like message texts widthWhile we limit the width of messages in the chat history, the input is stretched from one end to another.
I guess we need to put the `Gtk.Entry` in a `Handy.Leaflet`, just like Fractal:
![fractal-4.0-screenshot](/uploads/92eb9f5cdc4dfb...While we limit the width of messages in the chat history, the input is stretched from one end to another.
I guess we need to put the `Gtk.Entry` in a `Handy.Leaflet`, just like Fractal:
![fractal-4.0-screenshot](/uploads/92eb9f5cdc4dfb083d2bf72e5414ffa6/fractal-4.0-screenshot.png)GTK 0.1.0-beta3NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/71Allow multiple lines in input field2020-12-31T12:05:29ZNicoAllow multiple lines in input fieldDino.im handles it in a way I like personally.Dino.im handles it in a way I like personally.GTK 0.1.0-beta3NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/76Handle error when adding pending contact2021-03-09T10:34:35ZNicoHandle error when adding pending contactFound by @grote in https://code.briarproject.org/briar/python-briar-wrapper/-/issues/19.
We should definitely fix this in the next release. For now, all we seem to be able to do is tell users about the failure. Once https://code.briarpr...Found by @grote in https://code.briarproject.org/briar/python-briar-wrapper/-/issues/19.
We should definitely fix this in the next release. For now, all we seem to be able to do is tell users about the failure. Once https://code.briarproject.org/briar/briar/-/issues/1825 is done, we can offer ways to fix the error.
When implementing this issue, we have to keep in mind that attackers might want to know if a user already has a contact, i.e. exploring the contacts relationships of the targeted user.
In general Briar GTK should start to properly handle errors. When doing this, the documentation of Briar Headless should be improved, too.GTK 0.1.0-beta3NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/81Improve line wrapping in messages2021-01-06T14:41:28ZNicoImprove line wrapping in messagesA user reported a bug I had in mind once but forgot about: messages consisting of one very large "word" don't get wrapped in the chat history. By sending a very large sequence of characters without spaces etc. you can essentially explode...A user reported a bug I had in mind once but forgot about: messages consisting of one very large "word" don't get wrapped in the chat history. By sending a very large sequence of characters without spaces etc. you can essentially explode your window width.
Seems like this is really easy to fix: in [_briar-gtk/briar_gtk/widgets/private_message.py#L121_](https://code.briarproject.org/briar/briar-gtk/-/blob/154be3dcfe2c93f5cf66f25f1b356e54653175a1/briar-gtk/briar_gtk/widgets/private_message.py#L121) all we have to do is to add a new code line calling [`body_content.set_line_wrap_mode()`](https://lazka.github.io/pgi-docs/#Gtk-3.0/classes/Label.html#Gtk.Label.set_line_wrap_mode) with [`Pango.WrapMode.WORD_CHAR `](https://lazka.github.io/pgi-docs/#Pango-1.0/enums.html#Pango.WrapMode.WORD_CHAR).GTK 0.1.0-beta3https://code.briarproject.org/briar/briar-gtk/-/issues/84Use Briar blue instead of theme selected color2020-12-16T14:02:59ZNicoUse Briar blue instead of theme selected colorCurrently we use [`@theme_selected_bg_color`](https://code.briarproject.org/briar/briar-gtk/-/blob/154be3dcfe2c93f5cf66f25f1b356e54653175a1/briar-gtk/data/ui/application.css#L67) for things like usernames. This is mostly blue, but on e.g...Currently we use [`@theme_selected_bg_color`](https://code.briarproject.org/briar/briar-gtk/-/blob/154be3dcfe2c93f5cf66f25f1b356e54653175a1/briar-gtk/data/ui/application.css#L67) for things like usernames. This is mostly blue, but on e.g. Linux Mint it's green. There, the difference between own and their usernames is not visible that much, because both names are colored in green. We should use the Briar blue code instead, so that we have blue-green on all platforms.GTK 0.1.0-beta3x0lootsx0lootshttps://code.briarproject.org/briar/briar-gtk/-/issues/88Revise contributing guide2021-02-04T09:28:42ZNicoRevise contributing guideThere's at least an error with the `component` thing in merge requests. Might have other issues, too.There's at least an error with the `component` thing in merge requests. Might have other issues, too.GTK 0.1.0-beta3NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/89Stay at top when entering second line in chat input2021-03-07T13:24:23ZNicoStay at top when entering second line in chat inputCurrently it scrolls down, hiding the first line.Currently it scrolls down, hiding the first line.GTK 0.1.0-beta3NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/92Support sending messages with numpad enter2021-03-07T12:32:57ZNicoSupport sending messages with numpad enterCurrently only the "main" enter key leads to messages being sent.
Currently:
* https://code.briarproject.org/briar/briar-gtk/-/blob/a46245005fdd2d65bb05b6766325d025dd70544a/briar-gtk/briar_gtk/private_chat/private_chat_presenter.py#L193...Currently only the "main" enter key leads to messages being sent.
Currently:
* https://code.briarproject.org/briar/briar-gtk/-/blob/a46245005fdd2d65bb05b6766325d025dd70544a/briar-gtk/briar_gtk/private_chat/private_chat_presenter.py#L193
* https://code.briarproject.org/briar/briar-gtk/-/blob/a46245005fdd2d65bb05b6766325d025dd70544a/briar-gtk/briar_gtk/private_chat/private_chat_presenter.py#L273
Formerly: https://code.briarproject.org/briar/briar-gtk/-/blob/0.1.0-beta2/briar-gtk/briar_gtk/containers/main_window.py#L187GTK 0.1.0-beta3NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/93Current contact not always highlighted2021-03-07T12:13:21ZNicoCurrent contact not always highlightedSometimes the chat is open but no contact is highlighted in the sidebar.Sometimes the chat is open but no contact is highlighted in the sidebar.GTK 0.1.0-beta3NicoNico