Briar Mailbox merge requestshttps://code.briarproject.org/briar/briar-mailbox/-/merge_requests2022-09-21T13:16:10Zhttps://code.briarproject.org/briar/briar-mailbox/-/merge_requests/121Add parameter that can be used to instruct mailbox not to exit on stop2022-09-21T13:16:10ZSebastianAdd parameter that can be used to instruct mailbox not to exit on stopCloses #158Closes #158SebastianSebastianhttps://code.briarproject.org/briar/briar-mailbox/-/merge_requests/122Fix DoNotKillMeFragment from getting re-created preventing users from proceeding2022-09-19T12:11:34ZTorsten GroteFix DoNotKillMeFragment from getting re-created preventing users from proceedingTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar-mailbox/-/merge_requests/119Let StatusManager combine all sources into single app state2022-11-08T17:33:31ZSebastianLet StatusManager combine all sources into single app stateFixes #159, #155, #122
Looks like #155 is also solved by this. Not sure about #157, I think we should try that intensively after merging.Fixes #159, #155, #122
Looks like #155 is also solved by this. Not sure about #157, I think we should try that intensively after merging.SebastianSebastianhttps://code.briarproject.org/briar/briar-mailbox/-/merge_requests/120Make onboarding readable on small landscape screens2022-09-01T17:46:02ZTorsten GroteMake onboarding readable on small landscape screensThis makes the text content scrollable which is invisible on large screens, but becomes possible on very small screens in landscape orientation. I didn't really find another way to solve this without introducing yet another custom layout...This makes the text content scrollable which is invisible on large screens, but becomes possible on very small screens in landscape orientation. I didn't really find another way to solve this without introducing yet another custom layout for this.
Closes #152Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar-mailbox/-/merge_requests/117Get rid of OnboardingActivity, use a fragment in MainActivity instead2022-08-24T07:39:36ZSebastianGet rid of OnboardingActivity, use a fragment in MainActivity insteadFixes #153, #150, #144Fixes #153, #150, #144SebastianSebastianhttps://code.briarproject.org/briar/briar-mailbox/-/merge_requests/114After pairing completed, show success screen2022-08-15T12:40:24ZSebastianAfter pairing completed, show success screenCloses #151Closes #151Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar-mailbox/-/merge_requests/112Move fragment navigation to activity2022-08-02T14:25:29ZSebastianMove fragment navigation to activityCloses #141
~~WIP: based on !108~~
~~WIP: want to fix #144 too with this MR~~ on second thoughts, let's keep a solution for #144 out of this. We probably need to save the current lifecycle state to a bundle in `onSaveInstanceState()` ...Closes #141
~~WIP: based on !108~~
~~WIP: want to fix #144 too with this MR~~ on second thoughts, let's keep a solution for #144 out of this. We probably need to save the current lifecycle state to a bundle in `onSaveInstanceState()` as I do in !110. Let's either work on #144 separately or try to add it to !110 where it might fit in nicely.Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar-mailbox/-/merge_requests/110Fix navigation bug when finishing onboarding2022-08-02T12:49:57ZSebastianFix navigation bug when finishing onboardingThe bug occurs when finishing onboarding while having the
do-not-keep-activities developer option enabled.
Closes #142
@earthlingIB Testing instructions:
This fix makes sure the problematic behavior does not happen any longer, i.e. th...The bug occurs when finishing onboarding while having the
do-not-keep-activities developer option enabled.
Closes #142
@earthlingIB Testing instructions:
This fix makes sure the problematic behavior does not happen any longer, i.e. that the wiping-complete screen does not come up in the wrong position in the sequence of screens (after finishing onboarding with the do-not-keep-activities option enabled).
At the same time, it is important to check that this fix did not break anything else, i.e. it is important to check that the wiping-complete screen does come up when it is supposed to.
I think it is rather clear, how to check that the wiping-complete screen does not appear in the wrong place. Just check that after onboarding we correctly arrive at the do-not-kill-me fragment with both the do-not-keep-activities option enabled and disabled.
The other thing, to check whether the wiping complete screen does appear where it is supposed to is rather complicated. There are a bunch of slightly different situations that need to be checked carefully. The basic situations are these:
* **1.** Wiping from within the mailbox app.
* **2.** Wiping remotely using briar.
In both cases, the wipe-complete screen should be visible eventually.
There are variations of the above cases that are important to check individually:
* **A.** The user has the mailbox status screen open while the wiping happens.
* **B.** The user has moved the mailbox app to the background while the wiping happens and until wiping finished.
* **C.** The user has moved the mailbox app to the background while the wiping happens but brings it back to the foreground before it has finished.
Then another dimension of variation is whether the do-not-keep-activities option has been enabled.
* **\*** do-not-keep-activities is enabled
* **no-\*** do-not-keep-activities is disabled
That leaves us with quite a lot of combinations. It is a bit tedious to test, but I think there's not really a way around it:
* All combinations with do-not-keep activities disabled: **1A, 1B, 1C, 2A, 2B, 2C**
* And then the same combinations but with do-not-keep activities enabled: **1A\*, 1B\*, 1C\*, 2A\*, 2B\*, 2C\***
Concerning the "wipe-complete screen should be visible eventually":
* In variations **A** and **C**, the wiping complete screen should be presented to the user instantly once wiping completed.
* In variation **B**, the user has navigated away from the app while wiping finishes. In this case the wipe-complete screen does not appear unsolicited, instead it should appear when the user reopens the app, either by moving back to it using the recent app switcher or by relaunching the app from the launcher. (Oh my, another variation for case **B**, sorry!)Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar-mailbox/-/merge_requests/111Return 404 for missing or unauthorised folders2022-08-01T13:40:37ZakwizgranReturn 404 for missing or unauthorised foldersThis branch updates the mailbox API to return a 404 response for requests involving missing or unauthorised folders. This enables the client to move on to the next API call without retrying.
As before, the same response is returned for ...This branch updates the mailbox API to return a 404 response for requests involving missing or unauthorised folders. This enables the client to move on to the next API call without retrying.
As before, the same response is returned for missing folders and unauthorised folders so that the API can't be used to probe for the existence of folders the client isn't authorised to access.
Note: This should be merged on the same day as briar!1692 to avoid breaking the nightly integration tests.https://code.briarproject.org/briar/briar-mailbox/-/merge_requests/109Fix power view icons being cut off; add text margin2022-08-01T13:22:28ZSebastianFix power view icons being cut off; add text marginCloses #146
@earthlingIB Testing instructions:
* Start mailbox app after uninstalling and reinstalling,
* See do-not-kill fragment,
* Rotate device to landscape mode,
* Observe whether everything looks nice and in particular whether th...Closes #146
@earthlingIB Testing instructions:
* Start mailbox app after uninstalling and reinstalling,
* See do-not-kill fragment,
* Rotate device to landscape mode,
* Observe whether everything looks nice and in particular whether the icons get cut off or not.
@akwizgran @earthlingIB usually there is only one permission question shown on most devices. There are some devices that show more such as Xiamoi etc. It would be nice if either of you could check on those if after the updates here the margins still look good when multiple permission questions are being shown. Thanks!Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar-mailbox/-/merge_requests/103Backport recent changes from Briar TorPlugin2022-08-01T12:50:54ZTorsten GroteBackport recent changes from Briar TorPluginThis activates automatic bridge usageThis activates automatic bridge usageMailbox: Torhttps://code.briarproject.org/briar/briar-mailbox/-/merge_requests/108Don't crash when navigating to do-not-kill-fragment after dozing2022-08-01T12:50:08ZTorsten GroteDon't crash when navigating to do-not-kill-fragment after dozingCloses #145Closes #145https://code.briarproject.org/briar/briar-mailbox/-/merge_requests/105Show different notifications for each state2022-07-26T15:56:21ZTorsten GroteShow different notifications for each stateCloses #140, #123Closes #140, #123https://code.briarproject.org/briar/briar-mailbox/-/merge_requests/107Upgrade KTor to 2.02022-07-26T15:43:35ZTorsten GroteUpgrade KTor to 2.0Closes #143Closes #143https://code.briarproject.org/briar/briar-mailbox/-/merge_requests/99Resolve "Clear UI when mailbox is wiped remotely"2023-03-13T15:45:10ZSebastianResolve "Clear UI when mailbox is wiped remotely"Closes #113, #114Closes #113, #114Mailbox: Unpairinghttps://code.briarproject.org/briar/briar-mailbox/-/merge_requests/104Fix layouts, improve UI in landscape mode and small screens2022-07-21T12:56:27ZTorsten GroteFix layouts, improve UI in landscape mode and small screensCloses #131
Might also fix https://code.briarproject.org/briar/briar-mailbox/-/issues/130Closes #131
Might also fix https://code.briarproject.org/briar/briar-mailbox/-/issues/130Mailboxhttps://code.briarproject.org/briar/briar-mailbox/-/merge_requests/106Do not crash when rotating device after do not kill me fragment2022-08-02T13:16:13ZSebastianDo not crash when rotating device after do not kill me fragmentCloses #134Closes #134https://code.briarproject.org/briar/briar-mailbox/-/merge_requests/87Display error when lifecycle fails to start2022-06-30T11:53:53ZSebastianDisplay error when lifecycle fails to starta first step in order to implement a feedback mechanism (#82)a first step in order to implement a feedback mechanism (#82)Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar-mailbox/-/merge_requests/100Show a warning for wrong system time during startup2022-06-30T07:16:24ZTorsten GroteShow a warning for wrong system time during startupTest instructions: Stop mailbox. change system date a few days into the past. start mailbox. expected behavior: clock error screen appears and after fixing system date, start continues.
Addition: Try different time differences such as fa...Test instructions: Stop mailbox. change system date a few days into the past. start mailbox. expected behavior: clock error screen appears and after fixing system date, start continues.
Addition: Try different time differences such as far in the past and future or just a few hours in the past and future.
Closes #138Mailbox: Torhttps://code.briarproject.org/briar/briar-mailbox/-/merge_requests/102Adapt Xiaomi power setup for MIUI 12.52022-06-29T14:35:48ZTorsten GroteAdapt Xiaomi power setup for MIUI 12.5Analogous to https://code.briarproject.org/briar/briar/-/merge_requests/1667
Closes #136Analogous to https://code.briarproject.org/briar/briar/-/merge_requests/1667
Closes #136Mailbox: Manage app lifecycle