Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
briar
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
694
Issues
694
List
Boards
Labels
Service Desk
Milestones
Merge Requests
17
Merge Requests
17
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Incidents
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
briar
briar
Commits
d06ac3c8
Verified
Commit
d06ac3c8
authored
Nov 03, 2020
by
akwizgran
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Show correct summary for Tor setting when bridges are enabled.
parent
432fb2c7
Pipeline
#5083
passed with stage
in 12 minutes and 14 seconds
Changes
2
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
23 additions
and
4 deletions
+23
-4
briar-android/src/main/java/org/briarproject/briar/android/AndroidComponent.java
...java/org/briarproject/briar/android/AndroidComponent.java
+3
-0
briar-android/src/main/java/org/briarproject/briar/android/settings/SettingsFragment.java
...briarproject/briar/android/settings/SettingsFragment.java
+20
-4
No files found.
briar-android/src/main/java/org/briarproject/briar/android/AndroidComponent.java
View file @
d06ac3c8
...
...
@@ -21,6 +21,7 @@ import org.briarproject.bramble.api.keyagreement.PayloadEncoder;
import
org.briarproject.bramble.api.keyagreement.PayloadParser
;
import
org.briarproject.bramble.api.lifecycle.IoExecutor
;
import
org.briarproject.bramble.api.lifecycle.LifecycleManager
;
import
org.briarproject.bramble.api.network.NetworkManager
;
import
org.briarproject.bramble.api.plugin.PluginManager
;
import
org.briarproject.bramble.api.settings.SettingsManager
;
import
org.briarproject.bramble.api.system.AndroidExecutor
;
...
...
@@ -169,6 +170,8 @@ public interface AndroidComponent
AndroidWakeLockManager
wakeLockManager
();
NetworkManager
networkManager
();
void
inject
(
SignInReminderReceiver
briarService
);
void
inject
(
BriarService
briarService
);
...
...
briar-android/src/main/java/org/briarproject/briar/android/settings/SettingsFragment.java
View file @
d06ac3c8
...
...
@@ -18,6 +18,9 @@ import org.briarproject.bramble.api.db.DbException;
import
org.briarproject.bramble.api.event.Event
;
import
org.briarproject.bramble.api.event.EventBus
;
import
org.briarproject.bramble.api.event.EventListener
;
import
org.briarproject.bramble.api.network.NetworkManager
;
import
org.briarproject.bramble.api.network.NetworkStatus
;
import
org.briarproject.bramble.api.network.event.NetworkStatusEvent
;
import
org.briarproject.bramble.api.nullsafety.MethodsNotNullByDefault
;
import
org.briarproject.bramble.api.nullsafety.ParametersNotNullByDefault
;
import
org.briarproject.bramble.api.plugin.BluetoothConstants
;
...
...
@@ -165,6 +168,8 @@ public class SettingsFragment extends PreferenceFragmentCompat
LocationUtils
locationUtils
;
@Inject
CircumventionProvider
circumventionProvider
;
@Inject
NetworkManager
networkManager
;
@Inject
AndroidExecutor
androidExecutor
;
...
...
@@ -331,7 +336,8 @@ public class SettingsFragment extends PreferenceFragmentCompat
return
direction
==
LAYOUT_DIRECTION_LTR
;
}
private
void
setTorNetworkSummary
(
int
torNetworkSetting
)
{
private
void
setTorNetworkSummary
(
int
torNetworkSetting
,
NetworkStatus
networkStatus
)
{
if
(
torNetworkSetting
!=
PREF_TOR_NETWORK_AUTOMATIC
)
{
torNetwork
.
setSummary
(
"%s"
);
// use setting value
return
;
...
...
@@ -341,12 +347,13 @@ public class SettingsFragment extends PreferenceFragmentCompat
String
country
=
locationUtils
.
getCurrentCountry
();
String
countryName
=
getCountryDisplayName
(
country
);
boolean
ipv6Only
=
networkStatus
.
isIpv6Only
();
boolean
blocked
=
circumventionProvider
.
isTorProbablyBlocked
(
country
);
boolean
useBridges
=
circumventionProvider
.
doBridgesWork
(
country
);
String
setting
=
getString
(
R
.
string
.
tor_network_setting_without_bridges
);
if
(
blocked
&&
useBridges
)
{
if
(
ipv6Only
||
(
blocked
&&
useBridges
)
)
{
setting
=
getString
(
R
.
string
.
tor_network_setting_with_bridges
);
}
else
if
(
blocked
)
{
setting
=
getString
(
R
.
string
.
tor_network_setting_never
);
...
...
@@ -408,7 +415,8 @@ public class SettingsFragment extends PreferenceFragmentCompat
int
torNetworkSetting
=
torSettings
.
getInt
(
PREF_TOR_NETWORK
,
DEFAULT_PREF_TOR_NETWORK
);
torNetwork
.
setValue
(
Integer
.
toString
(
torNetworkSetting
));
setTorNetworkSummary
(
torNetworkSetting
);
setTorNetworkSummary
(
torNetworkSetting
,
networkManager
.
getNetworkStatus
());
boolean
torMobileSetting
=
torSettings
.
getBoolean
(
PREF_TOR_MOBILE
,
DEFAULT_PREF_TOR_MOBILE
);
...
...
@@ -593,7 +601,8 @@ public class SettingsFragment extends PreferenceFragmentCompat
}
else
if
(
preference
==
torNetwork
)
{
int
torNetworkSetting
=
Integer
.
valueOf
((
String
)
newValue
);
storeTorNetworkSetting
(
torNetworkSetting
);
setTorNetworkSummary
(
torNetworkSetting
);
setTorNetworkSummary
(
torNetworkSetting
,
networkManager
.
getNetworkStatus
());
}
else
if
(
preference
==
torMobile
)
{
boolean
torMobileSetting
=
(
Boolean
)
newValue
;
storeTorMobileSetting
(
torMobileSetting
);
...
...
@@ -760,6 +769,13 @@ public class SettingsFragment extends PreferenceFragmentCompat
torSettings
=
migrateTorSettings
(
s
.
getSettings
());
displaySettings
();
}
}
else
if
(
e
instanceof
NetworkStatusEvent
)
{
NetworkStatusEvent
n
=
(
NetworkStatusEvent
)
e
;
if
(
settingsLoaded
)
{
int
torNetworkSetting
=
torSettings
.
getInt
(
PREF_TOR_NETWORK
,
DEFAULT_PREF_TOR_NETWORK
);
setTorNetworkSummary
(
torNetworkSetting
,
n
.
getStatus
());
}
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment