diff --git a/briar-android/src/main/java/org/briarproject/briar/android/reporting/CrashFragment.java b/briar-android/src/main/java/org/briarproject/briar/android/reporting/CrashFragment.java index ece37d7282581872f2004d3048462a9c544b5f07..102cdbf116fc93d3437ec5cd5816413aae815d69 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/reporting/CrashFragment.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/reporting/CrashFragment.java @@ -26,7 +26,7 @@ public class CrashFragment extends Fragment { .inflate(R.layout.fragment_crash, container, false); v.findViewById(R.id.acceptButton).setOnClickListener(view -> - getDevReportActivity().showReportForm(true)); + getDevReportActivity().displayFragment(true)); v.findViewById(R.id.declineButton).setOnClickListener(view -> getDevReportActivity().closeReport()); diff --git a/briar-android/src/main/java/org/briarproject/briar/android/reporting/DevReportActivity.java b/briar-android/src/main/java/org/briarproject/briar/android/reporting/DevReportActivity.java index b18d72d4d7e365b6cd089d5eb90703651b07817e..d958f1494bc6ca7f9bbf42aa6a901d6c1cfa3819 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/reporting/DevReportActivity.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/reporting/DevReportActivity.java @@ -75,7 +75,7 @@ public class DevReportActivity extends BaseCrashReportDialog { R.string.crash_report_title); requireNonNull(getDelegate().getSupportActionBar()).setTitle(title); - if (state == null) showReportForm(isFeedback()); + if (state == null) displayFragment(isFeedback()); } @Override @@ -133,7 +133,7 @@ public class DevReportActivity extends BaseCrashReportDialog { return getException() instanceof UserFeedback; } - void showReportForm(boolean showReportForm) { + void displayFragment(boolean showReportForm) { Fragment f; if (showReportForm) { File file = @@ -145,8 +145,15 @@ public class DevReportActivity extends BaseCrashReportDialog { requireNonNull(getDelegate().getSupportActionBar()).hide(); } getSupportFragmentManager().beginTransaction() - .replace(R.id.fragmentContainer, f) + .replace(R.id.fragmentContainer, f, f.getTag()) .commit(); + + } + + @Override + public void invalidateOptionsMenu() { + super.invalidateOptionsMenu(); + getDelegate().invalidateOptionsMenu(); } void closeReport() { diff --git a/briar-android/src/main/java/org/briarproject/briar/android/reporting/ReportFormFragment.java b/briar-android/src/main/java/org/briarproject/briar/android/reporting/ReportFormFragment.java index 2c4a873b9c313bf729a63f760f9b06af1293e7e0..7de1b5f85e9117052fd83657216d684a3b74ac0f 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/reporting/ReportFormFragment.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/reporting/ReportFormFragment.java @@ -13,6 +13,7 @@ import android.view.ViewGroup; import android.widget.Button; import android.widget.CheckBox; import android.widget.CompoundButton; +import android.widget.CompoundButton.OnCheckedChangeListener; import android.widget.EditText; import android.widget.LinearLayout; import android.widget.TextView; @@ -52,7 +53,7 @@ import static org.acra.ReportField.STACK_TRACE; @MethodsNotNullByDefault @ParametersNotNullByDefault public class ReportFormFragment extends Fragment - implements CompoundButton.OnCheckedChangeListener { + implements OnCheckedChangeListener { private static final Logger LOG = getLogger(ReportFormFragment.class.getName()); @@ -91,7 +92,7 @@ public class ReportFormFragment extends Fragment } @Override - public void onCreate(Bundle savedInstanceState) { + public void onCreate(@Nullable Bundle savedInstanceState) { super.onCreate(savedInstanceState); setHasOptionsMenu(true); }