briar issueshttps://code.briarproject.org/briar/briar/-/issues2017-12-18T07:40:36Zhttps://code.briarproject.org/briar/briar/-/issues/756Creator discards new member's join message2017-12-18T07:40:36ZakwizgranCreator discards new member's join messageThe creator of a private group will discard a join message from a new member that arrives before the corresponding invitation protocol message has been handled. The new member will eventually retransmit the message and the creator will h...The creator of a private group will discard a join message from a new member that arrives before the corresponding invitation protocol message has been handled. The new member will eventually retransmit the message and the creator will handle it, but this causes an unnecessary delay in the creator handling the new member's join message.Milestone Eakwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/755Timestamp of new group message should be higher than that of all messages in ...2017-12-18T07:40:36ZTorsten GroteTimestamp of new group message should be higher than that of all messages in the groupMilestone ETorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/737Private group conversation is not updated when group is dissolved2017-12-18T07:40:37ZakwizgranPrivate group conversation is not updated when group is dissolvedIf a private group is dissolved while it's being viewed, the view doesn't update until the activity is recreated.If a private group is dissolved while it's being viewed, the view doesn't update until the activity is recreated.Milestone ETorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/736Private group list is not updated when group is dissolved2017-12-18T07:40:37ZakwizgranPrivate group list is not updated when group is dissolvedThe activity has to be recreated for the change to appear.The activity has to be recreated for the change to appear.Milestone ETorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/735Back button in Invite Members screen returns to group list2017-12-18T07:40:38ZakwizgranBack button in Invite Members screen returns to group listPressing the back button in the private group Invite Members screen should return to the group, not the group list.Pressing the back button in the private group Invite Members screen should return to the group, not the group list.Milestone ETorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/734Notifications for private group messages2017-12-18T07:40:38ZakwizgranNotifications for private group messagesNotifications should be shown for private group messages as they are for blog and forum posts.Notifications should be shown for private group messages as they are for blog and forum posts.Milestone ETorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/733Incoming messages aren't added to private group conversation2017-12-18T07:40:38ZakwizgranIncoming messages aren't added to private group conversationWhen a new private message arrives, it isn't shown in the conversation until the activity is recreated.When a new private message arrives, it isn't shown in the conversation until the activity is recreated.Milestone ETorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/732Implement UX design for revealing contacts to a private group2017-12-18T07:40:38ZTorsten GroteImplement UX design for revealing contacts to a private groupSubticket of #654 and #127.
![654_reveal_neu_v01](/uploads/e88db85207db1a8b807e08f34722a303/654_reveal_neu_v01.jpg)Subticket of #654 and #127.
![654_reveal_neu_v01](/uploads/e88db85207db1a8b807e08f34722a303/654_reveal_neu_v01.jpg)Milestone ETorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/726Layout for private group join message isn't i18n-friendly2017-12-18T07:40:38ZakwizgranLayout for private group join message isn't i18n-friendlyThe layout for private group join messages combines an AuthorView with a TextView to form a sentence. This won't work for languages where the subject doesn't come at the start of the sentence.
Review the layout so that the AuthorView is...The layout for private group join messages combines an AuthorView with a TextView to form a sentence. This won't work for languages where the subject doesn't come at the start of the sentence.
Review the layout so that the AuthorView is separate from the sentence.Milestone Ehttps://code.briarproject.org/briar/briar/-/issues/722Implement UX design for inviting new members to a group2017-12-18T07:40:39ZTorsten GroteImplement UX design for inviting new members to a groupSubticket of #127. Design discussion in #653
![](https://code.briarproject.org/akwizgran/briar/uploads/47e136beab2fa3d22dbac8d2943fe101/653_add_member.jpg)Subticket of #127. Design discussion in #653
![](https://code.briarproject.org/akwizgran/briar/uploads/47e136beab2fa3d22dbac8d2943fe101/653_add_member.jpg)Milestone ETorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/718Creating a group without having contacts can cause crash2017-12-18T07:40:39ZTorsten GroteCreating a group without having contacts can cause crashCurrently, it is possible to create a private group without having contacts, but the group creation code assumes that you have at least one contact. If you try to create a group without having contacts, you land in a strange UI state and...Currently, it is possible to create a private group without having contacts, but the group creation code assumes that you have at least one contact. If you try to create a group without having contacts, you land in a strange UI state and when you press the back button, briar crashes.
I see two simple solutions for this:
1. Only allow creating groups when the user has at least one contact (requires a different empty state message)
2. Allow for creating groups without having contacts.Milestone ETorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/715Long posts aren't rendered2017-12-18T07:40:39ZakwizgranLong posts aren't renderedOn the Galaxy Nexus, long blog posts from an RSS feed aren't rendered. The following warning is logged:
```
10-20 15:37:47.647 18342-18342/org.briarproject W/View: View too large to fit into drawing cache, needs 4553568 bytes, only 368...On the Galaxy Nexus, long blog posts from an RSS feed aren't rendered. The following warning is logged:
```
10-20 15:37:47.647 18342-18342/org.briarproject W/View: View too large to fit into drawing cache, needs 4553568 bytes, only 3686400 available
```
Shorter posts from the same feed render without problems. Looks like this might be caused by software rendering. At least we have a device that prints useful warnings about this. :-)Milestone ETorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/712Throw FormatException if BdfList index is out of bounds2017-12-18T07:40:39ZakwizgranThrow FormatException if BdfList index is out of boundsCurrently an ArrayIndexOutOfBoundsException will be thrown, which could be a source of crashes when parsing untrusted data.Currently an ArrayIndexOutOfBoundsException will be thrown, which could be a source of crashes when parsing untrusted data.Milestone Eakwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/709Implement protocol for private group invitations2017-12-18T07:40:39ZakwizgranImplement protocol for private group invitationsSpec ticket is #659. Subtask of #127.Spec ticket is #659. Subtask of #127.Milestone Eakwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/708Implement protocol for private group messaging2017-12-18T07:40:39ZakwizgranImplement protocol for private group messagingSpec ticket is #658. Subtask of #127.Spec ticket is #658. Subtask of #127.Milestone ETorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/707Implement UX for showing and answering private group invitations2017-12-18T07:40:39ZTorsten GroteImplement UX for showing and answering private group invitationsDepends on #648. Subtask of #127.
![](https://code.briarproject.org/akwizgran/briar/uploads/2cfb10c1cc3ebd85804b6fd0d7edae24/648_B_flow.jpg)Depends on #648. Subtask of #127.
![](https://code.briarproject.org/akwizgran/briar/uploads/2cfb10c1cc3ebd85804b6fd0d7edae24/648_B_flow.jpg)Milestone ETorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/696NPE when stopping KeyAgreementTask2018-06-12T11:32:17ZakwizgranNPE when stopping KeyAgreementTaskThis comes from the attached crash report:
```
10-01 13:32:55.236 E/ACRA (12071): ACRA caught a NullPointerException for org.briarproject.unofficial
10-01 13:32:55.236 E/ACRA (12071): java.lang.NullPointerException: Attempt to i...This comes from the attached crash report:
```
10-01 13:32:55.236 E/ACRA (12071): ACRA caught a NullPointerException for org.briarproject.unofficial
10-01 13:32:55.236 E/ACRA (12071): java.lang.NullPointerException: Attempt to invoke interface method 'void org.briarproject.api.keyagreement.KeyAgreementTask.stopListening()' on a null object reference
10-01 13:32:55.236 E/ACRA (12071): at org.briarproject.android.keyagreement.ShowQrCodeFragment$3.run(ShowQrCodeFragment.java:192)
```
The user has customised the package name and version number, so there may be other modifications.
[report-5444258362477720692.json](/uploads/c9cd2a9bab424cbf12f00a143f5a8ced/report-5444258362477720692.json)Milestone Eakwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/695Introduction failure2018-06-12T11:32:17ZakwizgranIntroduction failure* Set up three devices (Ace, Moto and Sony)
* Ace and Moto add each other as contacts
* Sony and Moto add each other as contacts
* Moto introduces Ace to Sony
* Sony accepts
* Ace accepts
* Moto receives Ace's ack and enters the error st...* Set up three devices (Ace, Moto and Sony)
* Ace and Moto add each other as contacts
* Sony and Moto add each other as contacts
* Moto introduces Ace to Sony
* Sony accepts
* Ace accepts
* Moto receives Ace's ack and enters the error state
The problem seems to be that Moto is receiving Ace's ack before Ace's response.
Log from Ace:
```
10-04 15:52:45.613 5426-5522/org.briarproject I/IntroduceeEngine: Received Introduction in state AWAIT_REQUEST from Moto with session ID -652500394 in group -1226669137. Moving on to state AWAIT_RESPONSES
10-04 15:52:54.622 5426-5522/org.briarproject I/IntroduceeEngine: Received Response in state AWAIT_RESPONSES from Moto related to Sony with session ID -652500394 in group -1226669137. Moving on to state AWAIT_LOCAL_RESPONSE
10-04 15:52:56.074 5426-5522/org.briarproject I/IntroduceeEngine: Sending accept response in state AWAIT_LOCAL_RESPONSE to Moto for Sony with session ID -652500394 in group -1226669137. Moving on to state AWAIT_ACK
10-04 15:52:58.426 5426-5522/org.briarproject I/IntroduceeManager: Adding contact in inactive state
10-04 15:52:58.876 5426-5522/org.briarproject I/IntroduceeEngine: Sending ACK to Moto for Sony with session ID -652500394 in group -1226669137
10-04 15:53:01.330 5426-5522/org.briarproject I/IntroduceeEngine: Received Abort in state AWAIT_ACK from Moto related to Sony with session ID -652500394 in group -1226669137. Moving on to state ERROR
```
Log from Moto:
```
10-04 15:52:00.776 9254-9993/org.briarproject I/IntroducerEngine: Sending introduction request in state PREPARE_REQUESTS to Ace with session ID -652500394 in group -1226669137. Moving on to state AWAIT_RESPONSES
10-04 15:52:00.776 9254-9993/org.briarproject I/IntroducerEngine: Sending introduction request in state PREPARE_REQUESTS to Sony with session ID -652500394 in group -1923720712. Moving on to state AWAIT_RESPONSES
10-04 15:52:10.336 9254-9993/org.briarproject I/IntroducerEngine: Received Response in state AWAIT_RESPONSES from Sony to Ace with session ID -652500394 in group -1923720712. Moving on to state AWAIT_RESPONSE_1
10-04 15:52:10.337 9254-9993/org.briarproject I/IntroducerEngine: Forwarding message to group -1226669137
10-04 15:52:16.592 9254-9993/org.briarproject I/IntroducerEngine: Received ACK in state AWAIT_RESPONSE_1 from Ace to Sony with session ID -652500394 in group -1226669137. Moving on to state ERROR
10-04 15:52:16.592 9254-9993/org.briarproject W/IntroducerEngine: Aborting protocol session -652500394 in state AWAIT_RESPONSE_1
10-04 15:52:16.727 9254-9993/org.briarproject I/IntroducerEngine: Received Response in state ERROR from Ace to Sony with session ID -652500394 in group -1226669137. Moving on to state ERROR
```
Log from Sony:
```
10-04 15:52:46.079 2996-3845/org.briarproject I/IntroduceeEngine: Received Introduction in state AWAIT_REQUEST from Moto with session ID -652500394 in group -1923720712. Moving on to state AWAIT_RESPONSES
10-04 15:52:52.329 2996-3845/org.briarproject I/IntroduceeEngine: Sending accept response in state AWAIT_RESPONSES to Moto for Ace with session ID -652500394 in group -1923720712. Moving on to state AWAIT_REMOTE_RESPONSE
10-04 15:53:02.029 2996-3845/org.briarproject I/IntroduceeEngine: Received Abort in state AWAIT_REMOTE_RESPONSE from Moto related to Ace with session ID -652500394 in group -1923720712. Moving on to state ERROR
```Milestone ETorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/694NPE in ShareActivity when going back2018-06-12T11:32:17ZTorsten GroteNPE in ShareActivity when going back```
java.lang.NullPointerException: Attempt to invoke virtual method 'int java.util.ArrayList.size()' on a null object reference
at org.briarproject.android.sharing.ShareActivity.getContactsFromIntegers(Sha...```
java.lang.NullPointerException: Attempt to invoke virtual method 'int java.util.ArrayList.size()' on a null object reference
at org.briarproject.android.sharing.ShareActivity.getContactsFromIntegers(ShareActivity.java:85)
at org.briarproject.android.sharing.ContactSelectorFragment.onCreateView(ContactSelectorFragment.java:125)
at android.support.v4.app.Fragment.performCreateView(Fragment.java:1974)
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1067)
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1252)
at android.support.v4.app.BackStackRecord.popFromBackStack(BackStackRecord.java:971)
at android.support.v4.app.FragmentManagerImpl.popBackStackState(FragmentManager.java:1670)
at android.support.v4.app.FragmentManagerImpl.popBackStackImmediate(FragmentManager.java:586)
at android.support.v4.app.FragmentActivity.onBackPressed(FragmentActivity.java:189)
at org.briarproject.android.sharing.ShareMessageFragment.onOptionsItemSelected(ShareMessageFragment.java:100)
at org.briarproject.android.sharing.ShareForumMessageFragment.onOptionsItemSelected(ShareForumMessageFragment.java:23)
```Milestone ETorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/690Introduction onboarding is shown again if it's dismissed2018-06-12T11:32:17ZakwizgranIntroduction onboarding is shown again if it's dismissedIf I tap outside the tap target to dismiss the onboarding, it's shown again next time I open the screen.If I tap outside the tap target to dismiss the onboarding, it's shown again next time I open the screen.Milestone ETorsten GroteTorsten Grote