briar issueshttps://code.briarproject.org/briar/briar/-/issues2020-11-30T12:31:03Zhttps://code.briarproject.org/briar/briar/-/issues/1843Create sync client to exchange profile pictures with contacts2020-11-30T12:31:03ZakwizgranCreate sync client to exchange profile pictures with contactsThis client will sync single-block messages initially, pending large message support.
Subtask of #214.This client will sync single-block messages initially, pending large message support.
Subtask of #214.Profile picturesTorsten GroteTorsten Grote2021-01-31https://code.briarproject.org/briar/briar/-/issues/1844Add core method for loading a profile picture2020-11-30T12:31:04ZakwizgranAdd core method for loading a profile pictureAdd a core method for loading a profile picture as an InputStream, give the message ID and content type. This will be similar to MessagingManager#getAttachment(), so consider whether that method and the Attachment and AttachmentHeader cl...Add a core method for loading a profile picture as an InputStream, give the message ID and content type. This will be similar to MessagingManager#getAttachment(), so consider whether that method and the Attachment and AttachmentHeader classes should be factored out.
Subtask of #214.Profile picturesTorsten GroteTorsten Grote2021-01-31https://code.briarproject.org/briar/briar/-/issues/1846Refactor image compression code for reuse outside messaging client2020-12-07T11:49:19ZakwizgranRefactor image compression code for reuse outside messaging clientFactor out AttachmentCreationTask#compressImage() so it can be reused when storing the user's profile picture.
Subtask of #214.Factor out AttachmentCreationTask#compressImage() so it can be reused when storing the user's profile picture.
Subtask of #214.Profile picturesSebastianSebastian2021-01-31https://code.briarproject.org/briar/briar/-/issues/1847UI for choosing profile picture2020-12-11T10:34:02ZakwizgranUI for choosing profile pictureAdd an item to the settings screen that shows the user's current profile picture (if any) with a button for choosing a new picture.
Create a new confirmation screen that shows the chosen picture cropped to a circle, with an explanation ...Add an item to the settings screen that shows the user's current profile picture (if any) with a button for choosing a new picture.
Create a new confirmation screen that shows the chosen picture cropped to a circle, with an explanation that the picture will only be visible to contacts and buttons to confirm or cancel the choice.
Depends on #1844, #1846. Subtask of #214.Profile picturesSebastianSebastian2021-01-31https://code.briarproject.org/briar/briar/-/issues/1848Test performance of profile picture loading and caching2020-12-11T10:34:16ZakwizgranTest performance of profile picture loading and cachingCheck that performance is acceptable when loading a conversation with a large number of profile pictures (eg a forum with posts from many contacts).
Depends on #1845. Subtask of #214.Check that performance is acceptable when loading a conversation with a large number of profile pictures (eg a forum with posts from many contacts).
Depends on #1845. Subtask of #214.Profile picturesTorsten GroteTorsten Grote2021-01-31https://code.briarproject.org/briar/briar/-/issues/1845Show profile picture in AuthorView using Glide2020-12-11T10:34:26ZakwizgranShow profile picture in AuthorView using GlideIf an AuthorInfo specifies a profile picture, AuthorView should load it using Glide instead of showing an identicon.
Depends on #1842 and #1844. Subtask of #214.If an AuthorInfo specifies a profile picture, AuthorView should load it using Glide instead of showing an identicon.
Depends on #1842 and #1844. Subtask of #214.Profile picturesTorsten GroteTorsten Grote2021-01-31https://code.briarproject.org/briar/briar/-/issues/1842Add message ID of profile picture to Identity, Contact and AuthorInfo classes2020-12-11T10:34:39ZakwizgranAdd message ID of profile picture to Identity, Contact and AuthorInfo classesThis field will be null for identities without a profile picture, or those whose profile picture is unknown.
Subtask of #214This field will be null for identities without a profile picture, or those whose profile picture is unknown.
Subtask of #214Profile picturesTorsten GroteTorsten Grote2021-01-31https://code.briarproject.org/briar/briar/-/issues/1856Update profile picture in current chat's app bar2020-12-16T12:59:18ZSebastianUpdate profile picture in current chat's app barLike #1855 we need to update the avatar once it changesLike #1855 we need to update the avatar once it changesProfile picturesSebastianSebastian2021-01-31https://code.briarproject.org/briar/briar/-/issues/1855Update profile pictures in contact list2020-12-16T13:01:41ZSebastianUpdate profile pictures in contact listMake sure that the profile pictures update in the contact list automatically when one of the contacts changes their avatar.Make sure that the profile pictures update in the contact list automatically when one of the contacts changes their avatar.Profile picturesSebastianSebastian2021-01-31https://code.briarproject.org/briar/briar/-/issues/1851Move media related classes and interfaces from AttachmentModule into dedicate...2021-02-19T17:58:09ZSebastianMove media related classes and interfaces from AttachmentModule into dedicated MediaModuleWhile working on #1846 the idea came up to further refactor the attachment package and module by creating a dedicated media or image module that would be a new home for the various classes and interfaces dealing with images that might de...While working on #1846 the idea came up to further refactor the attachment package and module by creating a dedicated media or image module that would be a new home for the various classes and interfaces dealing with images that might deserve their own package now that they are also being used for other purposes. We decided to handle that further refactoring separately to not interfere too much with the ongoing work on #214Profile picturesSebastianSebastian2021-01-31https://code.briarproject.org/briar/briar/-/issues/214User Avatars2021-05-05T16:17:22ZTorsten GroteUser AvatarsFollowing support for Identicons in #120, we want to give users the possibility to use their own avatar to be recognized by their peers.
We should bear in mind the potential for impersonation, especially in forums, where users will see ...Following support for Identicons in #120, we want to give users the possibility to use their own avatar to be recognized by their peers.
We should bear in mind the potential for impersonation, especially in forums, where users will see posts from known and unknown identities mixed together. Anyone can create a throwaway identity with the same nickname (and avatar, if we allow them) as another user, which is different from what people are used to in centralised systems.
One possibility would be to show avatars *only* for known/verified identities and use identicons for unknown identities and those users who did not specify an avatar.
Unverified contacts should be distinguished from verified contacts in some way. They could use different identicons or have a little badge on their image indicating the trust-level similar to the little green briar icons we use at the moment.Profile picturesIvanaIvana2021-01-31https://code.briarproject.org/briar/briar/-/issues/1952Crash - when changing or canceling profile pictures2021-07-06T10:06:10ZIvanaCrash - when changing or canceling profile picturesSteps to reproduce:
HTC One M9 API 24 -
Log into the briar
1. Go to settings > tap on 'tap here to change your profile picture'
2. Select a picture available in your phone
3. When the popup appears, select 'cancel'.
Go back to step 1...Steps to reproduce:
HTC One M9 API 24 -
Log into the briar
1. Go to settings > tap on 'tap here to change your profile picture'
2. Select a picture available in your phone
3. When the popup appears, select 'cancel'.
Go back to step 1 and 2
This has been reproduced 3 times... here are the logfiles from Android studio.
[change_of_profile_pictures_3.txt](/uploads/2be2b0296e1e4a386f41e6ce31fbae13/change_of_profile_pictures_3.txt)[crash_when_changing_profile_picture_2.txt](/uploads/fb32103ee1133301809083e9331bd5f5/crash_when_changing_profile_picture_2.txt)[Crash_when_changing_profile_pictures.txt](/uploads/bdbcba54c0d8ff0a966a3effe4dd2d2e/Crash_when_changing_profile_pictures.txt)
version under test: beta 1.2.16 8a534b45Profile picturesIvanaIvana2021-01-31https://code.briarproject.org/briar/briar/-/issues/1207Update content rating in Play Store when image support is added2021-07-06T10:06:40ZakwizgranUpdate content rating in Play Store when image support is addedProfile picturesakwizgranakwizgran2021-01-31