Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
briar
briar
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 679
    • Issues 679
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 12
    • Merge Requests 12
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • briar
  • briarbriar
  • Issues
  • #1110

Closed
Open
Opened Nov 29, 2017 by akwizgran@akwizgranOwner
  • Report abuse
  • New issue
Report abuse New issue

Signatures use wrong labels

The blog, forum, private group and introduction clients are using the wrong labels for their signatures. The signatures use a label of the form CLIENT_ID + "/FOO", which results in the string org.briarproject.bramble.sync.ClientId@abcd1234/FOO, where abcd1234 is the hash code of the ClientId object, because ClientId inherits its toString() implementation from Object.

The ClientId object has the same hash code as the string it wraps, which is the same across devices, so the signatures will verify as long as the verifier has the same bug.

Fortunately we're about to break compatibility with the beta series, so we can fix this cleanly.

Assignee
Assign to
Android 1.0
Milestone
Android 1.0 (Past due)
Assign milestone
Time tracking
None
Due date
None
Reference: briar/briar#1110