Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
briar
briar
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 694
    • Issues 694
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 17
    • Merge Requests 17
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • briar
  • briarbriar
  • Issues
  • #1530

Closed
Open
Opened Apr 10, 2019 by alex@0x1337

images doesn't get sent even after changing 'hasSupport' to true

When attempting to send an image, an overlay comes with

"Images unavailable" "Your contact's Briar does not yet support image attachments. Once they upgrade you'll see a different icon."

Then, I changed the constant FEATURE_FLAG_IMAGE_ATTACHMENTS to TRUE in TestingConstants.java With no luck, So I changed the following code -> (in android/conversation/conversationActivity.java - Line 267)

observeOnce(viewModel.hasImageSupport(), this, hasSupport -> {
				if (hasSupport != null && hasSupport) {
					// remove cast when removing FEATURE_FLAG_IMAGE_ATTACHMENTS
					((TextAttachmentController) sendController)
							.setImagesSupported();
				}
			});

to

((TextAttachmentController) sendController).setImagesSupported();

also, as another attempt with the same manner, I left the code as is but I changed the value of hasSupport=true manually ;

After that , whenever sending an image, nothing goes and only 'null' is sent. knowing that the same version of the build is used in both android devises.

Is it a bug ? or i am lacking something important ? in both cases i'd love hearing from you. By the way, thank you for this great application !

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: briar/briar#1530