Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
briar
briar
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 694
    • Issues 694
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 16
    • Merge Requests 16
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • briar
  • briarbriar
  • Issues
  • #1573

Closed
Open
Opened May 29, 2019 by akwizgran@akwizgranOwner

LanTcpPlugin broadcasts a TransportDisabledEvent if it fails to bind key agreement socket

TcpPlugin#tryToClose(ServerSocket) broadcasts a TransportDisabledEvent, apparently as a convenience because the enabled/disabled state of the plugin is defined by whether a server socket is bound and the socket can be closed in several places. But LanTcpPlugin calls this method if it fails to bind a server socket for key agreement, wrongly broadcasting an event.

TorPlugin copies TcpPlugin's tryToClose() method. We should probably clean that up too, as TorPlugin will soon have other server sockets for rendezvous connections and we don't want to broadcast an event when they're closed.

Related to #1572 (closed).

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: briar/briar#1573