Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
briar
briar
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 696
    • Issues 696
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 7
    • Merge Requests 7
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briar
  • briarbriar
  • Issues
  • #619

Closed
Open
Opened Aug 26, 2016 by akwizgran@akwizgranOwner

Transaction is set complete unconditionally

ValidationManagerImpl line 323:

} finally {
    if (!txn.isComplete()) txn.setComplete();
    db.endTransaction(txn);
}

This will commit the transaction even if an exception is thrown, which is probably not the intended behaviour. Fix this and check for the same pattern being used elsewhere.

Assignee
Assign to
Milestone E
Milestone
Milestone E (Past due)
Assign milestone
Time tracking
None
Due date
None
Reference: briar/briar#619