briar merge requestshttps://code.briarproject.org/briar/briar/-/merge_requests2019-11-06T17:52:44Zhttps://code.briarproject.org/briar/briar/-/merge_requests/1195Update image attachment UI when new client version is received from contact2019-11-06T17:52:44ZakwizgranUpdate image attachment UI when new client version is received from contactThis fixes a bug where a newly added contact wouldn't appear to support image attachments if the conversation was opened before the contact's client versioning message was received.
Closes #1638This fixes a bug where a newly added contact wouldn't appear to support image attachments if the conversation was opened before the contact's client versioning message was received.
Closes #1638Android 1.3https://code.briarproject.org/briar/briar/-/merge_requests/1187Fix IllegalStateException when creating image attachments2020-10-30T16:17:21ZTorsten GroteFix IllegalStateException when creating image attachmentsInjecting the non-singleton AttachmentCreator keeps an instance around
that gets re-used with a different ViewModel.
When backing out without sending or cancelling the attachments,
we don't reset the state which leads us into an illegal ...Injecting the non-singleton AttachmentCreator keeps an instance around
that gets re-used with a different ViewModel.
When backing out without sending or cancelling the attachments,
we don't reset the state which leads us into an illegal state.
Closes #1647Android 1.3https://code.briarproject.org/briar/briar/-/merge_requests/1186Show Attachment Placeholders2020-10-30T15:54:27ZTorsten GroteShow Attachment Placeholdersand display attachments as they load.
Closes #1592and display attachments as they load.
Closes #1592Android 1.3https://code.briarproject.org/briar/briar/-/merge_requests/1185Remove contacts feature flag2019-11-05T18:23:51ZTorsten GroteRemove contacts feature flagAndroid 1.2https://code.briarproject.org/briar/briar/-/merge_requests/1183Fix PNG compression on some phones2020-01-08T16:06:40ZTorsten GroteFix PNG compression on some phonesCloses #1636Closes #1636Android 1.3https://code.briarproject.org/briar/briar/-/merge_requests/1182Change image preview close button color to accent color2019-11-07T16:23:25ZTorsten GroteChange image preview close button color to accent colorThis was suggested in #1243, because the red color should only be used for something dangerous/destructive. The accent color we use elsewhere for buttons fits better here.
![device-2019-10-22-130809](/uploads/bd2f336d987da742bda139607...This was suggested in #1243, because the red color should only be used for something dangerous/destructive. The accent color we use elsewhere for buttons fits better here.
![device-2019-10-22-130809](/uploads/bd2f336d987da742bda1396070fb97f9/device-2019-10-22-130809.png)
![device-2019-10-22-130656](/uploads/d6db273458606802fbe8d0614cd07d76/device-2019-10-22-130656.png)Android 1.3https://code.briarproject.org/briar/briar/-/merge_requests/1173UX for handling duplicate handshake links2019-10-16T16:16:09ZTorsten GroteUX for handling duplicate handshake links![device-2019-10-15-133019](/uploads/a90fb2865f10bde3187b8d0bde2a109e/device-2019-10-15-133019.png)
![device-2019-10-15-133046](/uploads/6eaecc07059eb809f18cc968f19a5627/device-2019-10-15-133046.png)
![device-2019-10-15-133236](/uploads...![device-2019-10-15-133019](/uploads/a90fb2865f10bde3187b8d0bde2a109e/device-2019-10-15-133019.png)
![device-2019-10-15-133046](/uploads/6eaecc07059eb809f18cc968f19a5627/device-2019-10-15-133046.png)
![device-2019-10-15-133236](/uploads/43cf3500f10cea07c2e709f506566d91/device-2019-10-15-133236.png)
![device-2019-10-15-133332](/uploads/05ab380a769cacd30293c76a53299698/device-2019-10-15-133332.png)
Closes #1565Android 1.2https://code.briarproject.org/briar/briar/-/merge_requests/1170Restore custom layout behaviour for handling snackbar2019-10-14T14:26:03ZakwizgranRestore custom layout behaviour for handling snackbarCloses #1582Closes #1582Android 1.2https://code.briarproject.org/briar/briar/-/merge_requests/1156Use snackbar-aware behaviour for FAB.2019-10-07T13:48:02ZTorsten GroteUse snackbar-aware behaviour for FAB.Closes #1582Closes #1582Android 1.2https://code.briarproject.org/briar/briar/-/merge_requests/1155Make Remote Contact layouts work on small screens2019-09-27T14:58:44ZTorsten GroteMake Remote Contact layouts work on small screensCloses #1583Closes #1583Android 1.2https://code.briarproject.org/briar/briar/-/merge_requests/1152Prevent pending contacts snackbar from covering contact list2019-10-01T12:25:24ZTorsten GrotePrevent pending contacts snackbar from covering contact listThis fixes one part (the contact list covering) of #1582.This fixes one part (the contact list covering) of #1582.Android 1.2akwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/merge_requests/1150Bump client minor version to avoid triggering crash2019-06-28T13:28:38ZakwizgranBump client minor version to avoid triggering crashThis is a sneaky workaround for #1606. Briar 1.1.7 doesn't consider that a contact supports image attachments unless the client minor version is exactly 1, so it won't take the code path that triggers the bug. Current master considers th...This is a sneaky workaround for #1606. Briar 1.1.7 doesn't consider that a contact supports image attachments unless the client minor version is exactly 1, so it won't take the code path that triggers the bug. Current master considers that a contact supports image attachments if the client minor version is greater than 0, so this branch and current master are still able to exchange images.
We should make a stable release that incorporates the (already merged) fix for #1606, and new alpha releases for 1.2 and 1.3 that incorporate this fix so they don't crash contacts running older stable releases.
Closes #1606Android 1.3https://code.briarproject.org/briar/briar/-/merge_requests/1149WIP: Show Attachment Placeholders2019-11-01T17:15:49ZTorsten GroteWIP: Show Attachment Placeholdersand display attachments as they load.
WIP because based on !1176
Closes #1592and display attachments as they load.
WIP because based on !1176
Closes #1592Android 1.3https://code.briarproject.org/briar/briar/-/merge_requests/1148Initialise result LiveData before starting task2019-06-26T14:21:56ZakwizgranInitialise result LiveData before starting taskThis branch fixes a possible race when starting an attachment creation task, which could cause an immediate error to be lost.This branch fixes a possible race when starting an attachment creation task, which could cause an immediate error to be lost.Android 1.3https://code.briarproject.org/briar/briar/-/merge_requests/1147Compress images2019-06-26T14:21:25ZakwizgranCompress imagesThis branch adds temporary code for compressing image attachments to fit within the current 32 KiB message size limit. Once large message support is merged we can remove this code or update it to use more moderate compression, perhaps wi...This branch adds temporary code for compressing image attachments to fit within the current 32 KiB message size limit. Once large message support is merged we can remove this code or update it to use more moderate compression, perhaps with a setting to choose whether to send compressed or uncompressed attachments.
The first commit, which contains most of the changes, is refactoring to extract the code that finds the size of an image from an InputStream, which the second commit uses when creating attachments as well as when loading them. Interfaces were extracted from the AttachmentRetriever and AttachmentCreator classes to allow ConversationViewModel to inject them. We can keep most of these changes even if we remove compression later.Android 1.3https://code.briarproject.org/briar/briar/-/merge_requests/1145Add blocks table to database2020-11-16T11:06:06ZakwizgranAdd blocks table to databaseThis branch adds a blocks table to the database and migrates message bodies from the messages table to the blocks table. This is the first step in adding multi-block message support to the DB.
The migration and subsequent compaction t...This branch adds a blocks table to the database and migrates message bodies from the messages table to the blocks table. This is the first step in adding multi-block message support to the DB.
The migration and subsequent compaction takes a significant amount of time - about a minute on a slow phone with ~750 messages (the default when creating test data).
The branch also modifies the existing migrations to close their statements. As far as I know the statements would have been closed automatically when the respective connection was closed, so I don't think there was a significant resource leak.
Closes #1595Android 1.3https://code.briarproject.org/briar/briar/-/merge_requests/1144Use a fresh LiveData for each attachment creation task2019-06-20T14:05:44ZakwizgranUse a fresh LiveData for each attachment creation taskThis branch fixes a bug caused by my suggested changes to !1038. Since there's a 1:1 correspondence between AttachmentCreationTasks and LiveDatas, I think a better solution would be for the LiveData to be created and returned by the task...This branch fixes a bug caused by my suggested changes to !1038. Since there's a 1:1 correspondence between AttachmentCreationTasks and LiveDatas, I think a better solution would be for the LiveData to be created and returned by the task. But that's a bigger piece of refactoring that may be out of scope for fixing this bug.
Closes #1594Android 1.3https://code.briarproject.org/briar/briar/-/merge_requests/1142Improve handling of missing attachments in UI2019-06-20T14:04:04ZakwizgranImprove handling of missing attachments in UIThis branch improves the handling of missing and invalid attachments.
When an attachment is loaded, the MessagingManager checks that it's an attachment (rather than a private message) and that it has the expected content type. When th...This branch improves the handling of missing and invalid attachments.
When an attachment is loaded, the MessagingManager checks that it's an attachment (rather than a private message) and that it has the expected content type. When the UI tries to load the attachments of a private message, it handles NoSuchMessageException by waiting for the attachment to arrive, then trying again. The message is shown without attachments in the meantime.
This branch doesn't completely solve the handling of missing attachments - I think we should show placeholders for missing or invalid attachments, but we can solve that separately after merging this branch.Android 1.3https://code.briarproject.org/briar/briar/-/merge_requests/1141Move private message creation off the crypto executor2019-06-18T11:22:46ZakwizgranMove private message creation off the crypto executorCloses #1590Closes #1590Android 1.2https://code.briarproject.org/briar/briar/-/merge_requests/1140Use injection to provide feature flags2019-06-18T11:51:10ZakwizgranUse injection to provide feature flagsThis branch moves the feature flags into an injectable interface. This will make the flags accessible from the core. If flags are used in the core, integration tests and the headless app will need to provide implementations of the Featur...This branch moves the feature flags into an injectable interface. This will make the flags accessible from the core. If flags are used in the core, integration tests and the headless app will need to provide implementations of the FeatureFlags interface to specify which features they want to enable.Android 1.3