briar merge requestshttps://code.briarproject.org/briar/briar/-/merge_requests2017-05-12T13:15:45Zhttps://code.briarproject.org/briar/briar/-/merge_requests/536Bring nullable annotation imports in line2017-05-12T13:15:45ZJulian DehmBring nullable annotation imports in lineUse a consistent nullabe annotation throughout the code.
Signed-off-by: goapunk <noobie@goapunks.net>Use a consistent nullabe annotation throughout the code.
Signed-off-by: goapunk <noobie@goapunks.net>Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/535Use application context to get WifiManager2017-05-10T17:02:07ZakwizgranUse application context to get WifiManagerPrevents a memory leak, apparently.Prevents a memory leak, apparently.Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/534Store correct original parent ID when rewrapping blog posts2017-05-12T09:53:30ZakwizgranStore correct original parent ID when rewrapping blog postsWhile writing some tests for !524 I realised we were storing the wrong original parent ID when rewrapping blog posts.While writing some tests for !524 I realised we were storing the wrong original parent ID when rewrapping blog posts.Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/533Remove ellipsizing support from EmojiTextView2017-05-12T09:35:40ZakwizgranRemove ellipsizing support from EmojiTextViewThis is a workaround for a layout bug. @goapunk did the hard work of tracking down the bug, I just wrote the patch.
Closes #884This is a workaround for a layout bug. @goapunk did the hard work of tracking down the bug, I just wrote the patch.
Closes #884Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/531Fix groupname validation2017-05-05T13:32:55ZJulian DehmFix groupname validationThe validation should be done over the utf8 representation, otherwise the result will be wrong if the name contains emoji / utf8 codes.
Signed-off-by: goapunk <noobie@goapunks.net>The validation should be done over the utf8 representation, otherwise the result will be wrong if the name contains emoji / utf8 codes.
Signed-off-by: goapunk <noobie@goapunks.net>Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/530Set up basic CI2017-05-05T13:32:55ZTorsten GroteSet up basic CIFinally, some automated CI \o/
This is just the beginning. There's a lot more we could do, but this is a good start I think.
It is using the docker image used to test the F-Droid client for now. We can easily provide our own later....Finally, some automated CI \o/
This is just the beginning. There's a lot more we could do, but this is a good start I think.
It is using the docker image used to test the F-Droid client for now. We can easily provide our own later. Also, we probably want to add lint checking and espresso tests eventually. Soon, we will even be able to deploy `master` automatically to a nightly builds f-droid repo.
Thanks @akwizgran for providing a server for this!
This might close #468, or not?Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/526Show text input permanently in threaded conversations2017-05-05T13:32:56ZTorsten GroteShow text input permanently in threaded conversationsCloses #791Closes #791Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/525Darken thread indicator2017-05-05T13:32:56ZTorsten GroteDarken thread indicator![device-2017-04-17-161638](/uploads/e243b789b0f7f6b389d19b2715db4eed/device-2017-04-17-161638.png)![device-2017-04-17-161408](/uploads/9eb403b136c0fc6fbd16b3c7e9e0bd56/device-2017-04-17-161408.png)
Closes #874![device-2017-04-17-161638](/uploads/e243b789b0f7f6b389d19b2715db4eed/device-2017-04-17-161638.png)![device-2017-04-17-161408](/uploads/9eb403b136c0fc6fbd16b3c7e9e0bd56/device-2017-04-17-161408.png)
Closes #874Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/522Don't use single top and clear top flags together2017-04-17T18:20:50ZakwizgranDon't use single top and clear top flags togetherWhen an instance of the activity already exists, using these flags together has the unexpected effect of delivering the intent to the current instance's onNewIntent() instead of replacing the current instance.When an instance of the activity already exists, using these flags together has the unexpected effect of delivering the intent to the current instance's onNewIntent() instead of replacing the current instance.Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/521When checking for overlay apps, ignore Play Services2017-04-17T18:19:53ZakwizgranWhen checking for overlay apps, ignore Play ServicesCloses #938Closes #938Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/519Increase socket timeout for Tor sockets2017-04-19T16:54:08ZakwizgranIncrease socket timeout for Tor socketsThis is an experiment to see if #871 is caused by Tor connections timing out.This is an experiment to see if #871 is caused by Tor connections timing out.Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/515Use the new launcher icon2017-04-07T12:59:44ZakwizgranUse the new launcher iconSo very modern.
Closes #829So very modern.
Closes #829Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/514Fix MessageId calculation for deprecated MessageQueue2017-04-11T12:50:08ZTorsten GroteFix MessageId calculation for deprecated MessageQueueThis was preventing introduction messages from getting ACKed.
The introduction tests were modified to check for this.
Closes #891This was preventing introduction messages from getting ACKed.
The introduction tests were modified to check for this.
Closes #891Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/513Terminate the process after handling a panic trigger2017-04-07T12:50:02ZakwizgranTerminate the process after handling a panic triggerThis branch fixes a few bugs with panic button responses:
* Terminate the process when signing out in response to a panic trigger (thanks @goapunk for finding the cause of this bug)
* Terminate the process when a panic trigger is receive...This branch fixes a few bugs with panic button responses:
* Terminate the process when signing out in response to a panic trigger (thanks @goapunk for finding the cause of this bug)
* Terminate the process when a panic trigger is received before signing in
* Ignore panic triggers from untrusted apps
Closes #932Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/512Prevent conversation actions from being executed twice2017-04-07T14:03:52ZTorsten GrotePrevent conversation actions from being executed twiceThis prevents introduction sessions from being aborted really nastily when the user presses accept two times in short sequence. This might already be a sufficent work-around for #890.
It prevents double actions in other contexts as well...This prevents introduction sessions from being aborted really nastily when the user presses accept two times in short sequence. This might already be a sufficent work-around for #890.
It prevents double actions in other contexts as well.
Closes #893Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/511Refine the panic app list tap behavior2017-04-07T10:17:55ZJulian DehmRefine the panic app list tap behavior* Only open if a market is installed
fixes #925
Signed-off-by: goapunk <noobie@goapunks.net>* Only open if a market is installed
fixes #925
Signed-off-by: goapunk <noobie@goapunks.net>Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/510Store only 4 ip addresses because 5 exceed the maximum length.2017-04-06T14:38:51ZJulian DehmStore only 4 ip addresses because 5 exceed the maximum length.I've run into this now a couple of times and I'm concerned that others will too. It's unlikely to happen on our test phones, but on real ones it's quite easy to get 5 different ips (wifi at home, the office, partner, mcdonalds, public wi...I've run into this now a couple of times and I'm concerned that others will too. It's unlikely to happen on our test phones, but on real ones it's quite easy to get 5 different ips (wifi at home, the office, partner, mcdonalds, public wifi, friends,...) and contact exchanges will indefinitely fail from that point.
fixes #885
Signed-off-by: goapunk <noobie@goapunks.net>Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/509Fix "all tests" configuration2017-04-07T10:19:04ZakwizgranFix "all tests" configurationThe last (empty) stage of this configuration used to complain about not finding any tests. I replace the last stage with a copy of the briar-android configuration and removed briar-android from the list of prerequisites, so all stages no...The last (empty) stage of this configuration used to complain about not finding any tests. I replace the last stage with a copy of the briar-android configuration and removed briar-android from the list of prerequisites, so all stages now contain tests.Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/507Use a polite executor for validation tasks2017-04-06T15:47:49ZakwizgranUse a polite executor for validation tasksI tested three solutions to this problem:
* Use a separate executor for validation crypto tasks
* Use a separate executor for validation crypto and DB tasks
* Continue to use the existing executors, but add a queue to prevent validation ...I tested three solutions to this problem:
* Use a separate executor for validation crypto tasks
* Use a separate executor for validation crypto and DB tasks
* Continue to use the existing executors, but add a queue to prevent validation tasks from blocking the crypto executor (this branch)
All the solutions had comparable performance, so I chose the one that didn't involve adding another executor.
This branch also includes a commit that adds logging to the crypto and DB executors and the DB lock to help with performance measurements. Should be useful for #545.
@grote you've seen most of this before in !485.
Closes #675Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/506Move HTML Sanitation to DbThread2017-04-04T16:54:32ZTorsten GroteMove HTML Sanitation to DbThreadCloses #928Closes #928Milestone G