briar merge requestshttps://code.briarproject.org/briar/briar/-/merge_requests2017-03-28T14:41:14Zhttps://code.briarproject.org/briar/briar/-/merge_requests/489Add a setting to disable Tor2017-03-28T14:41:14ZakwizgranAdd a setting to disable TorThis is something the auditors asked for, which I thought might be worth merging into master.
The branch also fixes a bug with settings namespaces (the UI was using "tor" and "bt" whereas the plugins were using their transport IDs, whic...This is something the auditors asked for, which I thought might be worth merging into master.
The branch also fixes a bug with settings namespaces (the UI was using "tor" and "bt" whereas the plugins were using their transport IDs, which are no longer "tor' and "bt"), and replaces some string literals with constants to avoid similar bugs in the future.Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/502Add tapjacking protection2017-04-06T14:31:38ZJulian DehmAdd tapjacking protection* Set filterTouchesWhenObscured for all views
* Warn the user if Apps using the SYSTEM_ALERT_WINDOW permission are installed
* Warn the user if an App using the permission is installed while Briar is running
Fixes #906
Signed-of...* Set filterTouchesWhenObscured for all views
* Warn the user if Apps using the SYSTEM_ALERT_WINDOW permission are installed
* Warn the user if an App using the permission is installed while Briar is running
Fixes #906
Signed-off-by: goapunk <noobie@goapunks.net>Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/536Bring nullable annotation imports in line2017-05-12T13:15:45ZJulian DehmBring nullable annotation imports in lineUse a consistent nullabe annotation throughout the code.
Signed-off-by: goapunk <noobie@goapunks.net>Use a consistent nullabe annotation throughout the code.
Signed-off-by: goapunk <noobie@goapunks.net>Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/525Darken thread indicator2017-05-05T13:32:56ZTorsten GroteDarken thread indicator![device-2017-04-17-161638](/uploads/e243b789b0f7f6b389d19b2715db4eed/device-2017-04-17-161638.png)![device-2017-04-17-161408](/uploads/9eb403b136c0fc6fbd16b3c7e9e0bd56/device-2017-04-17-161408.png)
Closes #874![device-2017-04-17-161638](/uploads/e243b789b0f7f6b389d19b2715db4eed/device-2017-04-17-161638.png)![device-2017-04-17-161408](/uploads/9eb403b136c0fc6fbd16b3c7e9e0bd56/device-2017-04-17-161408.png)
Closes #874Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/503Don't allow other apps to open the panic prefs activity2017-03-31T08:25:36ZakwizgranDon't allow other apps to open the panic prefs activityThe branch prevents other apps from opening PanicPreferencesActivity.
Briar still shows up in Ripple's list of responders (presumably because we listen for TRIGGER intents), and there's no change to the way panic actions are handled. ...The branch prevents other apps from opening PanicPreferencesActivity.
Briar still shows up in Ripple's list of responders (presumably because we listen for TRIGGER intents), and there's no change to the way panic actions are handled. Touching Briar in Ripple's list of responders has no effect (it used to launch PanicPreferencesActivity). The text next to Briar in Ripple's list of responders says "App hides when triggered" (it used to say "EDIT"). This text is wrong, but it seems to be a default supplied by Ripple.
Depends on !501.
Fixes the second part of #909.Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/505Don't cast Context to BaseActivity2017-04-04T12:44:53ZakwizgranDon't cast Context to BaseActivityCloses #926Closes #926Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/488Don't make DNS lookups during RSS import2017-03-24T10:02:21ZakwizgranDon't make DNS lookups during RSS importWe use a custom socket factory to work around the lack of proper SOCKS support on Android - the socket factory implements SOCKS, but OkHttp doesn't know that.
When OkHttp doesn't think it's behind a SOCKS proxy it does local name resolu...We use a custom socket factory to work around the lack of proper SOCKS support on Android - the socket factory implements SOCKS, but OkHttp doesn't know that.
When OkHttp doesn't think it's behind a SOCKS proxy it does local name resolution so it can make one connection attempt per address when there are multiple addresses for a name. This leaks the server's identity to the local network and the internet (#908).
Fortunately, we can configure OkHttp to use a custom DNS resolver as well as a custom socket factory. This allows us to capture the local name lookup. We return 0.0.0.0 as the address, which OkHttp passes through to the socket factory, where we discard the fake address and pass the hostname to Tor to be resolved remotely.
In case a future version of OkHttp decides to do local name lookups in some other way, we also check that any name/address pairs passed into the socket factory have 0.0.0.0 as the address.
Closes #908Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/522Don't use single top and clear top flags together2017-04-17T18:20:50ZakwizgranDon't use single top and clear top flags togetherWhen an instance of the activity already exists, using these flags together has the unexpected effect of delivering the intent to the current instance's onNewIntent() instead of replacing the current instance.When an instance of the activity already exists, using these flags together has the unexpected effect of delivering the intent to the current instance's onNewIntent() instead of replacing the current instance.Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/509Fix "all tests" configuration2017-04-07T10:19:04ZakwizgranFix "all tests" configurationThe last (empty) stage of this configuration used to complain about not finding any tests. I replace the last stage with a copy of the briar-android configuration and removed briar-android from the list of prerequisites, so all stages no...The last (empty) stage of this configuration used to complain about not finding any tests. I replace the last stage with a copy of the briar-android configuration and removed briar-android from the list of prerequisites, so all stages now contain tests.Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/496Fix ForumActivityTest2017-04-07T10:04:37ZTorsten GroteFix ForumActivityTestCloses #915Closes #915Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/531Fix groupname validation2017-05-05T13:32:55ZJulian DehmFix groupname validationThe validation should be done over the utf8 representation, otherwise the result will be wrong if the name contains emoji / utf8 codes.
Signed-off-by: goapunk <noobie@goapunks.net>The validation should be done over the utf8 representation, otherwise the result will be wrong if the name contains emoji / utf8 codes.
Signed-off-by: goapunk <noobie@goapunks.net>Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/514Fix MessageId calculation for deprecated MessageQueue2017-04-11T12:50:08ZTorsten GroteFix MessageId calculation for deprecated MessageQueueThis was preventing introduction messages from getting ACKed.
The introduction tests were modified to check for this.
Closes #891This was preventing introduction messages from getting ACKed.
The introduction tests were modified to check for this.
Closes #891Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/499Fix possible intent hijacking for implicit pending intents2017-04-04T16:35:14ZTorsten GroteFix possible intent hijacking for implicit pending intentsThe intents in questions have simply been removed. See the commit message for more details.
Closes #910The intents in questions have simply been removed. See the commit message for more details.
Closes #910Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/490Fix potential NPE when getting soft reference2017-03-28T14:41:13ZakwizgranFix potential NPE when getting soft referenceThis is an old branch I had lying around that fixes a potential NPE in EmojiProvider if a SoftReference becomes null between two calls to SoftReference#get(). The branch also changes the error handling slightly so that if there's an exce...This is an old branch I had lying around that fixes a potential NPE in EmojiProvider if a SoftReference becomes null between two calls to SoftReference#get(). The branch also changes the error handling slightly so that if there's an exception while loading a bitmap, listeners learn of the failure rather than getting a null result.Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/519Increase socket timeout for Tor sockets2017-04-19T16:54:08ZakwizgranIncrease socket timeout for Tor socketsThis is an experiment to see if #871 is caused by Tor connections timing out.This is an experiment to see if #871 is caused by Tor connections timing out.Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/486Make Tor boot more verbose2017-03-28T14:41:14ZJulian DehmMake Tor boot more verboseInclude stderr into the output from Tor.
Signed-off-by: noobie <noobie@goapunks.net>Include stderr into the output from Tor.
Signed-off-by: noobie <noobie@goapunks.net>Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/506Move HTML Sanitation to DbThread2017-04-04T16:54:32ZTorsten GroteMove HTML Sanitation to DbThreadCloses #928Closes #928Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/512Prevent conversation actions from being executed twice2017-04-07T14:03:52ZTorsten GrotePrevent conversation actions from being executed twiceThis prevents introduction sessions from being aborted really nastily when the user presses accept two times in short sequence. This might already be a sufficent work-around for #890.
It prevents double actions in other contexts as well...This prevents introduction sessions from being aborted really nastily when the user presses accept two times in short sequence. This might already be a sufficent work-around for #890.
It prevents double actions in other contexts as well.
Closes #893Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/504Prevent multiple instances of PasswordActivity2017-03-31T13:42:13ZakwizgranPrevent multiple instances of PasswordActivityThis branch fixes the last part of #909: multiple instances of PasswordActivity being shown when multiple activities are started via intents. It also fixes a bug where PasswordActivity would be shown after signing out if the account was ...This branch fixes the last part of #909: multiple instances of PasswordActivity being shown when multiple activities are started via intents. It also fixes a bug where PasswordActivity would be shown after signing out if the account was deleted at the previous sign in. (I thought we had a ticket for that but I can't find it.)
Closes #909Milestone Ghttps://code.briarproject.org/briar/briar/-/merge_requests/511Refine the panic app list tap behavior2017-04-07T10:17:55ZJulian DehmRefine the panic app list tap behavior* Only open if a market is installed
fixes #925
Signed-off-by: goapunk <noobie@goapunks.net>* Only open if a market is installed
fixes #925
Signed-off-by: goapunk <noobie@goapunks.net>Milestone G