Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • briar briar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 784
    • Issues 784
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briarbriar
  • briarbriar
  • Merge requests
  • !1366

Introduce ViewModel for RssFeed*Activity

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Daniel Lublin requested to merge 1894-viewmodel-for-rssfeed-activities into master Feb 09, 2021
  • Overview 113
  • Commits 1
  • Pipelines 37
  • Changes 57

Closes #1894 (closed)

Testing instructions

This MR refactors the whole RSS Feed system.

Access RSS Feeds-screen in the "action overflow" (3 dots-icon) in the app bar of the Blogs activity.

It is at all times during testing -- like after actions taken, events occuring etc -- relevant to rotate the device and ensure that:

  • Text entered in fields, switches toggled etc remain so
  • Visibility of progressbars and buttons are the same
  • Labels on buttons remain the same
  • Opened dialog boxes remain so

Import a feed

  • Tap Plus-icon in the app bar
  • Enter a feed URL
    • example valid feed: https://briarproject.org/news/index.xml
    • invalid feed (a HTML page): https://briarproject.org
  • Tap import
  • Wait for import to succeed, and to be returned to RSS Feeds-screen.
    • or expect import-failed dialog, if feed was invalid
  • Verify that successfully added feed appears in list on RSS Feeds-screen.

Be impatient, after "Tap import" above:

  • Return to previous screen ◁
  • Wait for successfully added feed to appear in list
    • Or, in the case of an invalid feed, expect import-failed dialog.

Be even more impatient, after "Tap import" above:

  • Return to previous screen ◁
  • Tap Plus-icon to add a new feed while the first one is being processed
  • Expect the progressbar to be visible
  • Expect to be returned to RSS Feeds-screen once ongoing import is successful
Edited Apr 28, 2021 by Daniel Lublin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1894-viewmodel-for-rssfeed-activities