Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • briar briar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 780
    • Issues 780
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briar
  • briarbriar
  • Merge requests
  • !1620

Fix race condition in DB shutdown

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged akwizgran requested to merge db-shutdown-race into master Apr 08, 2022
  • Overview 12
  • Commits 3
  • Pipelines 2
  • Changes 1
  • Fix a potential race condition where startTransaction() is called concurrently with closeAllConnections(), such that closeAllConnections() sets closed = true after startTransaction() has checked that it's false
  • When a transaction is aborted, close the connection instead of returning it to the pool
  • When a transaction fails to commit, close the connection instead of returning it to the pool
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: db-shutdown-race