Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • briar briar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 779
    • Issues 779
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briar
  • briarbriar
  • Merge requests
  • !1681

Start from default Tor config every time, don't apply redundant settings

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged akwizgran requested to merge 1499-do-not-apply-redundant-settings into master Jun 29, 2022
  • Overview 9
  • Commits 2
  • Pipelines 3
  • Changes 1

This branch makes the following changes to the Tor plugin:

  • Always start from the default settings, rather than reusing the torrc from the previous session
  • Apply the ClientTransportPlugin settings once via torrc, rather than repeatedly applying them via the control port
  • Keep track of the network settings that have been applied, and don't apply them to the control port unless the settings have changed
  • Make fewer redundant calls to PluginCallback#pluginStateChanged()

These changes may help with #1499, specifically the cases where the crash happens at startup when bridges are enabled. My theory is that the crash may be caused by rapidly starting and stopping pluggable transport processes when the bridge settings are reapplied in quick succession.

Edited Jun 29, 2022 by akwizgran
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 1499-do-not-apply-redundant-settings