Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • briar briar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 788
    • Issues 788
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • briarbriar
  • briarbriar
  • Merge requests
  • !1697

Don't create files for upload while directly connected to contact

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged akwizgran requested to merge 2352-do-not-create-files-for-upload-while-connected into master Aug 10, 2022
  • Overview 11
  • Commits 4
  • Pipelines 4
  • Changes 11

This branch updates the MailboxUploadWorker to pause the creation of new files while we're directly connected to the contact. If an upload is in progress when we connect to the contact, it will be completed.

This branch also attaches extra information to MessageSharedEvent so that the receivers of that event (DuplexOutgoingSession and MailboxUploadWorker) can decide whether to act on the event. This should avoid unnecessary DB queries when a message is shared and there are multiple sessions and/or workers waiting for data to send.

Closes #2352 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 2352-do-not-create-files-for-upload-while-connected