Skip to content

Don't show tap protection dialog until it's needed

akwizgran requested to merge 956-tap-protection-ux into master

This branch aims to resolve the tap protection UX issues by not showing the tap protection dialog until we receive a touch event that's obscured by another app. This is achieved by wrapping BaseActivity's content view in a layout that implements onFilterTouchEventForSecurity. Custom toolbars are included in the content view and therefore protected. The standard toolbar is not protected, so we look it up and set filterTouchesWhenObscured to true. This creates a slight inconsistency: touching a custom toolbar while it's obscured will show the dialog, whereas touching a standard toolbar while it's obscured will have no effect. This could be fixed by using custom toolbars everywhere.

Dialogs (except the tap protection dialog) have filterTouchesWhenObscured set to true, so touching a dialog while it's obscured will have no effect.

The "don't warn me again" checkbox has been removed from the tap protection dialog because it no longer makes sense - if the dialog is shown, we know that one of the apps in the list must be drawing over Briar.

Closes #956 (closed)

Merge request reports