Skip to content

Singletons that call registration methods must be eager

akwizgran requested to merge eager-singletons into master

Registration methods like LifecycleManager#registerService() are meant to be called at injection time and we use eager singletons to ensure this. We've forgotten to make some recently created singletons eager, so they're registered when they're lazily instantiated, which could be after injection time, causing bugs such as services not being started.

Merge request reports