briar issueshttps://code.briarproject.org/briar/briar/-/issues2017-12-18T07:40:27Zhttps://code.briarproject.org/briar/briar/-/issues/769Test whether wake lock is still needed with Tor 0.2.82017-12-18T07:40:27ZakwizgranTest whether wake lock is still needed with Tor 0.2.8Test whether Tor 0.2.8 still needs a wake lock in order to keep the hidden service available when the device is idle. The wake lock is a major source of battery drain.
Related to #44, #574.Test whether Tor 0.2.8 still needs a wake lock in order to keep the hidden service available when the device is idle. The wake lock is a major source of battery drain.
Related to #44, #574.Milestone Fakwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/768KeyAgreementConnector regression: UnsupportedOperationException2017-12-18T07:40:27ZTorsten GroteKeyAgreementConnector regression: UnsupportedOperationException```
11-21 08:33:07.371 W/KeyAgreementConnector: java.util.concurrent.ExecutionException: java.lang.UnsupportedOperationException
java.util.concurrent.ExecutionException: java.lang.UnsupportedOp...```
11-21 08:33:07.371 W/KeyAgreementConnector: java.util.concurrent.ExecutionException: java.lang.UnsupportedOperationException
java.util.concurrent.ExecutionException: java.lang.UnsupportedOperationException
at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:223)
at java.util.concurrent.FutureTask.get(FutureTask.java:82)
at org.briarproject.keyagreement.KeyAgreementConnector.connect(KeyAgreementConnector.java:124)
at org.briarproject.keyagreement.KeyAgreementTaskImpl.run(KeyAgreementTaskImpl.java:89)
Caused by: java.lang.UnsupportedOperationException
at org.briarproject.plugins.tor.TorPlugin.createKeyAgreementConnection(TorPlugin.java:585)
at org.briarproject.keyagreement.KeyAgreementConnector$ConnectorTask.call(KeyAgreementConnector.java:195)
at org.briarproject.keyagreement.KeyAgreementConnector$ConnectorTask.call(KeyAgreementConnector.java:174)
at org.briarproject.keyagreement.KeyAgreementConnector$ReadableTask.call(KeyAgreementConnector.java:221)
at org.briarproject.keyagreement.KeyAgreementConnector$ReadableTask.call(KeyAgreementConnector.java:209)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
``Milestone FTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/766Unit tests for group invitation client2017-12-18T07:40:36ZTorsten GroteUnit tests for group invitation clientMilestone FTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/763Remove old signature API2017-12-18T07:40:36ZakwizgranRemove old signature APIRemove the Signature and SignatureImpl classes, which aren't needed any more. CryptoComponentImpl can directly use the Bouncy Castle class that they wrap.Remove the Signature and SignatureImpl classes, which aren't needed any more. CryptoComponentImpl can directly use the Bouncy Castle class that they wrap.Milestone Fakwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/762Text input does not increase to three lines anymore2017-12-18T07:40:36ZTorsten GroteText input does not increase to three lines anymoreWe had changed the input field for forums and private conversations once to automatically enlarge when lots of text is entered (up to three lines). The emoji changes introduced a regression, so the input field does not extend anymore.We had changed the input field for forums and private conversations once to automatically enlarge when lots of text is entered (up to three lines). The emoji changes introduced a regression, so the input field does not extend anymore.Milestone FJulian DehmJulian Dehmhttps://code.briarproject.org/briar/briar/-/issues/761Keyboard doesn't close when navigating up2017-12-18T07:40:36ZakwizgranKeyboard doesn't close when navigating upA user on IRC reported this. Steps to reproduce:
* Open the keyboard in the coversation screen
* Press the up button in the action bar to leave the conversation screenA user on IRC reported this. Steps to reproduce:
* Open the keyboard in the coversation screen
* Press the up button in the action bar to leave the conversation screenMilestone FJulian DehmJulian Dehmhttps://code.briarproject.org/briar/briar/-/issues/760Integration tests for private group invitation protocol2017-12-18T07:40:36ZakwizgranIntegration tests for private group invitation protocolMilestone FTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/759Introduction responses are not marked as read2017-12-18T07:40:36ZTorsten GroteIntroduction responses are not marked as readStep to reproduce:
1. invite two contacts to each other
2. accept the introduction from both contacts and wait for new contacts to be added
3. enter and leave private conversations with introducer with both contacts
4. return to contact ...Step to reproduce:
1. invite two contacts to each other
2. accept the introduction from both contacts and wait for new contacts to be added
3. enter and leave private conversations with introducer with both contacts
4. return to contact list and observe one unread messageMilestone FTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/757Remove DeviceId code2017-12-18T07:40:36ZakwizgranRemove DeviceId codeThe DeviceId is a leftover from an early attempt to add multi-device support. Remove it as part of the Grand Refactoring of #136.The DeviceId is a leftover from an early attempt to add multi-device support. Remove it as part of the Grand Refactoring of #136.Milestone FTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/754Add visibility information to group member list2017-12-18T07:40:36ZTorsten GroteAdd visibility information to group member listThe member list currently only says if the group is shared with a contact or not using a sharing icon. It does not give any details on whether the relationship to that user is revealed or not.The member list currently only says if the group is shared with a contact or not using a sharing icon. It does not give any details on whether the relationship to that user is revealed or not.Milestone FTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/752Break up ActivityModule so controller implementations can be package-private2017-12-18T07:40:36ZakwizgranBreak up ActivityModule so controller implementations can be package-privateController implementations need to be public so that ActivityModule can access them. Break up ActivityModule into smaller package-specific modules, like we do in the core, so we can reduce the visibility of the controllers.
Related to #...Controller implementations need to be public so that ActivityModule can access them. Break up ActivityModule into smaller package-specific modules, like we do in the core, so we can reduce the visibility of the controllers.
Related to #368.Milestone Fhttps://code.briarproject.org/briar/briar/-/issues/748Re-encoding of QR code payloads may produce different results2017-12-18T07:40:37ZakwizgranRe-encoding of QR code payloads may produce different resultsSince !394, adding a contact sometimes fails at the confirmation stage.
The Payload class contains a map from TransportIds to BdfLists. When calculating confirmation records, the Payload object received from the contact is re-encoded us...Since !394, adding a contact sometimes fails at the confirmation stage.
The Payload class contains a map from TransportIds to BdfLists. When calculating confirmation records, the Payload object received from the contact is re-encoded using the map's iteration order. The map is implemented as a HashMap, which doesn't have a defined iteration order. Devices with different HashMap implementations may re-encode each other's payloads differently from the original encoding, thus producing different confirmation records.Milestone Fakwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/747Remove injected field from BlogManagerImplTest2017-12-18T07:40:37ZakwizgranRemove injected field from BlogManagerImplTestBlogManagerImplTest has an @Inject annotated field, but injections aren't used in the briar-tests module. Replace it with a mock.BlogManagerImplTest has an @Inject annotated field, but injections aren't used in the briar-tests module. Replace it with a mock.Milestone Fakwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/742Use unique request IDs across the app2017-12-18T07:40:37ZakwizgranUse unique request IDs across the app@ernir came up with a nice solution for this: a static method that returns an incrementing counter.
```
private final static int REQUEST_INVITE = SomeUtil.getUniqueRequestId();
```@ernir came up with a nice solution for this: a static method that returns an incrementing counter.
```
private final static int REQUEST_INVITE = SomeUtil.getUniqueRequestId();
```Milestone FTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/741Move events into their respective packages2017-12-18T07:40:37ZakwizgranMove events into their respective packagesAll events are currently in the package `org.briarproject.api.event`. Events that are specific to a given package should be moved into the package that uses them.
Sub-task of #136All events are currently in the package `org.briarproject.api.event`. Events that are specific to a given package should be moved into the package that uses them.
Sub-task of #136Milestone Fakwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/738Older devices show overflow icon on some screens but not others2017-12-18T07:40:37ZakwizgranOlder devices show overflow icon on some screens but not othersOn the Sony Xperia Tipo (Android 4.0.4), which has a hardware menu button, the action bar overflow icon is shown on some screens but not others. For example, it's shown in the private conversation, but not in private groups. This should ...On the Sony Xperia Tipo (Android 4.0.4), which has a hardware menu button, the action bar overflow icon is shown on some screens but not others. For example, it's shown in the private conversation, but not in private groups. This should be consistent across the app.
In screens where it's shown, the menu can be opened by pressing either the overflow icon or the hardware button.Milestone FTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/731Open BDF Lists and Dictionary throw IllegalStateException2017-12-18T07:40:38ZTorsten GroteOpen BDF Lists and Dictionary throw IllegalStateExceptionThese tests should not fail:
```java
@Test(expected = FormatException.class)
public void testOpenList() throws Exception {
// A list that is not closed
String list = "60";
setContents(list);
r.readList();
}
@Test(expected = ...These tests should not fail:
```java
@Test(expected = FormatException.class)
public void testOpenList() throws Exception {
// A list that is not closed
String list = "60";
setContents(list);
r.readList();
}
@Test(expected = FormatException.class)
public void testOpenDictionary() throws Exception {
// A dictionary that is not closed
String dicts = "70" + "41" + "03" + "666F6F";
setContents(dicts);
r.readDictionary();
}
```Milestone Fakwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/727Refactor integration tests2017-12-18T07:40:38ZakwizgranRefactor integration testsSome of the code for delivering messages could be factored out of integration tests into a common superclass or utility class. Some tests create more component instances than they need.Some of the code for delivering messages could be factored out of integration tests into a common superclass or utility class. Some tests create more component instances than they need.Milestone FTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/724Unit tests for ClientHelperImpl2017-12-18T07:40:38ZakwizgranUnit tests for ClientHelperImplMilestone FTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/723Unit tests for ContactManagerImpl2017-12-18T07:40:38ZakwizgranUnit tests for ContactManagerImplMilestone FTorsten GroteTorsten Grote