briar issueshttps://code.briarproject.org/briar/briar/-/issues2017-12-18T07:40:26Zhttps://code.briarproject.org/briar/briar/-/issues/796Unclear what RSS Import will do2017-12-18T07:40:26ZTorsten GroteUnclear what RSS Import will doDuring a testing session (#788), a user found the RSS import feature, liked it and started to import a feed. However, the user was very surprised to find lots of RSS entries posted to their personal blog and shared with all contacts auto...During a testing session (#788), a user found the RSS import feature, liked it and started to import a feed. However, the user was very surprised to find lots of RSS entries posted to their personal blog and shared with all contacts automatically. The expectation of the user was that the RSS feed is only imported for the user alone. Automatic publishing was not expected.Android Beta 1https://code.briarproject.org/briar/briar/-/issues/795Use different notification icons for different features2017-12-18T07:40:26ZTorsten GroteUse different notification icons for different featuresDuring a testing session (#788), a user was confused by the fact that all notifications were using the little envelop icon, especially when a new blog post arrived. They asked for different icons for different kinds of notifications.During a testing session (#788), a user was confused by the fact that all notifications were using the little envelop icon, especially when a new blog post arrived. They asked for different icons for different kinds of notifications.Milestone FTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/794Message can be sent after group was dissolved2017-12-18T07:40:27ZTorsten GroteMessage can be sent after group was dissolvedDuring a testing session (#788), a user reported that they were able to send a message after a group had been resolved. Another user who had the group open at the same time, did get the dialog informing him that the group had been dissol...During a testing session (#788), a user reported that they were able to send a message after a group had been resolved. Another user who had the group open at the same time, did get the dialog informing him that the group had been dissolved, but the user who was writing a messaging, did not get the dialog and could still send the message.
We would need to try to reproduce this as it is possible that the dissolve notice did not arrive in time and the user could sent the message before the dissolve notice arrived.https://code.briarproject.org/briar/briar/-/issues/793Show open button after accepting invitations2017-12-18T07:40:26ZTorsten GroteShow open button after accepting invitationsDuring a testing session (#788), a user was confused about where to find the private group they just had been invited to. This could partly be addressed by opening the group after accepting the invitation. The other part can be addressed...During a testing session (#788), a user was confused about where to find the private group they just had been invited to. This could partly be addressed by opening the group after accepting the invitation. The other part can be addressed by #792.Milestone FTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/792Tester could not find a private group they'd been invited to2020-11-21T12:57:05ZTorsten GroteTester could not find a private group they'd been invited toDuring a testing session (#788), a user was confused about where to find the private group they just had been invited to. They expected to find the group in the contact list screen. The group agreed that this is where they would expect t...During a testing session (#788), a user was confused about where to find the private group they just had been invited to. They expected to find the group in the contact list screen. The group agreed that this is where they would expect to find groups, because they know this from other messengers that have a list of conversation that include private conversations and group conversations in one screen.
The list of contacts could be made available elsewhere.https://code.briarproject.org/briar/briar/-/issues/791Permanent Message Input for Threaded Conversations2017-12-18T07:40:26ZTorsten GrotePermanent Message Input for Threaded ConversationsUsers in a testing session (#788) were confused that they had to press the pen icon in the toolbar to write a message. The group of testers agreed that they all would expect the text input at the bottom to be there permanently like they ...Users in a testing session (#788) were confused that they had to press the pen icon in the toolbar to write a message. The group of testers agreed that they all would expect the text input at the bottom to be there permanently like they know it from all other messengers they use and like Briar also does it for private messages.
![device-2016-11-30-102956](/uploads/6c588c41b1d95334dcff3c252d4ccff4/device-2016-11-30-102956.png)![device-2016-11-30-103007](/uploads/53d638f92738463dfa8e154e822a1ecb/device-2016-11-30-103007.png)Android Beta 1Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/790Ask before turning on Bluetooth2018-02-01T10:39:35ZTorsten GroteAsk before turning on BluetoothWhen adding contacts in a testing session (#788), a user noticed immediately that Bluetooth was suddenly turned on. The user didn't like that and wants to at least be asked before Bluetooth is being turned on by Briar.When adding contacts in a testing session (#788), a user noticed immediately that Bluetooth was suddenly turned on. The user didn't like that and wants to at least be asked before Bluetooth is being turned on by Briar.akwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/789Initial Account Creation Unclear2018-04-29T12:57:06ZTorsten GroteInitial Account Creation UnclearDuring a user testing session (#788) a user installed the app and failed to create the initial account that is required to use the app.
The user saw the disabled button, tried to click it several times, but eventually gave up and turned...During a user testing session (#788) a user installed the app and failed to create the initial account that is required to use the app.
The user saw the disabled button, tried to click it several times, but eventually gave up and turned to other members of the group saying that it doesn't work. The user did not take time to read the explanatory text and either did not see or understand the toolbar title "Briar Setup" (in Spanish translation).
![device-2016-11-30-101817](/uploads/cc23f59cf11e5553eeae3d3fe7b753ff/device-2016-11-30-101817.png)Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/788Sao Paulo User Testing Session2017-12-18T07:40:26ZTorsten GroteSao Paulo User Testing Session[![300px-Garoa_Briar](/uploads/738b5c18e042969a3e48771b4f9f84e1/300px-Garoa_Briar.png)](https://garoa.net.br/wiki/Workshop_Briar:_Comunica%C3%A7%C3%A3o_Criptografada_P2P)
Subticket of #140[![300px-Garoa_Briar](/uploads/738b5c18e042969a3e48771b4f9f84e1/300px-Garoa_Briar.png)](https://garoa.net.br/wiki/Workshop_Briar:_Comunica%C3%A7%C3%A3o_Criptografada_P2P)
Subticket of #140Milestone FTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/787Blog: Tap on name opens individual blog while being open already2017-12-18T07:40:26ZMegaloxBlog: Tap on name opens individual blog while being open alreadyIf I'm in the individual blog of a user the tap on her name opens her individual blog again and again (with a slide animation). Shouldn't it simply do nothing?
I made a recording:
![device-2016-11-30-110230](/uploads/54d5db04cf7e5af9...If I'm in the individual blog of a user the tap on her name opens her individual blog again and again (with a slide animation). Shouldn't it simply do nothing?
I made a recording:
![device-2016-11-30-110230](/uploads/54d5db04cf7e5af939eb030ce015d993/device-2016-11-30-110230.mp4)Android Beta 1akwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/786Handle whitespace consistently2022-11-18T17:24:07ZakwizgranHandle whitespace consistentlyText with leading or trailing whitespace is treated inconsistently:
* Nicknames: whitespace isn't trimmed, whitespace-only names are allowed
* Private messages: whitespace is trimmed, whitespace-only messages are allowed but become empt...Text with leading or trailing whitespace is treated inconsistently:
* Nicknames: whitespace isn't trimmed, whitespace-only names are allowed
* Private messages: whitespace is trimmed, whitespace-only messages are allowed but become empty after trimming
* Forum names: whitespace isn't trimmed, whitespace-only names are allowed
* Forum invitations: whitespace isn't trimmed, whitespace-only messages are allowed
* Forum posts: whitespace is trimmed, whitespace-only posts aren't allowed
* Private group names: whitespace isn't trimmed, whitespace-only names are allowed
* Private group invitations: whitespace isn't trimmed, whitespace-only messages are allowed
* Private group posts: whitespace is trimmed, whitespace-only posts aren't allowed
* Blog posts: whitespace is trimmed, whitespace-only posts are allowed but become empty after trimming
* Blog comments: whitespace isn't trimmed, whitespace-only comments are allowed
Let's do the following everywhere:
When entering text:
1. Trim leading and trailing whitespace
2. If the trimmed text is empty and the input is optional (for example a blog comment), pass null to the backend
3. If the trimmed text is empty and the input isn't optional (for example a blog post), don't accept the input
4. If the trimmed text is too long, don't accept the input
5. If the trimmed text isn't empty or too long, pass it to the backend
When validating messages (including author names and group names):
1. Reject null if the text isn't optional
2. Reject the text if it's empty or too long
3. Reject the text if it has leading or trailing whitespacehttps://code.briarproject.org/briar/briar/-/issues/785Blogs: Interface bug while reblogging2018-05-31T09:01:35ZMegaloxBlogs: Interface bug while rebloggingOne more reproducable interface bug:
![device-2016-11-29-094211](/uploads/fde68dd00c24f3d938c0cb6059475bd1/device-2016-11-29-094211.mp4)
When I hit the reblog icon the blog entry shortly covers the software keys.One more reproducable interface bug:
![device-2016-11-29-094211](/uploads/fde68dd00c24f3d938c0cb6059475bd1/device-2016-11-29-094211.mp4)
When I hit the reblog icon the blog entry shortly covers the software keys.https://code.briarproject.org/briar/briar/-/issues/784Blogs: Reblogging snackbar is not shown correctly2019-02-25T10:10:11ZMegaloxBlogs: Reblogging snackbar is not shown correctlyPlease take a look at the recording:
![device-2016-11-29-092645](/uploads/d013b9f701f6ae4230808354ceb6fc6f/device-2016-11-29-092645.mp4)
First I'm creating a blogpost (everything is fine) but when I reblog, the snackbar is not shown...Please take a look at the recording:
![device-2016-11-29-092645](/uploads/d013b9f701f6ae4230808354ceb6fc6f/device-2016-11-29-092645.mp4)
First I'm creating a blogpost (everything is fine) but when I reblog, the snackbar is not shown correctly. The first time you can only see a small upper part above the software keys, the second time I reblog without commentary and there is no snackbar at all and the third time I reblog you can see a little bit more of the snackbar, but it gets definitley cut. I could reproduce this several times.https://code.briarproject.org/briar/briar/-/issues/783Make build process meet f-droid norms (no binaries)2018-05-11T14:19:12ZGreg TroxelMake build process meet f-droid norms (no binaries)(This ticket is not about actually getting briar into f-droid.)
Currently, the build downloads binaries, at least tor. My understanding is that f-droid, as part of reproducible builds, wants apps to build from source.
In addition to ...(This ticket is not about actually getting briar into f-droid.)
Currently, the build downloads binaries, at least tor. My understanding is that f-droid, as part of reproducible builds, wants apps to build from source.
In addition to f-droid issues, not being able to build tor from source easily makes it harder to debug #769.https://code.briarproject.org/briar/briar/-/issues/782Wrong item selected in nav drawer after going back2017-12-18T07:40:26ZakwizgranWrong item selected in nav drawer after going backA tester reported this ages ago, but it looks like I forgot to create a ticket.
Steps to reproduce:
* Start from the contact list
* Select an item from the nav drawer, for example Forums
* Use the back button to return to the contact li...A tester reported this ages ago, but it looks like I forgot to create a ticket.
Steps to reproduce:
* Start from the contact list
* Select an item from the nav drawer, for example Forums
* Use the back button to return to the contact list
* The nav drawer still shows the previous item as selected
A variant:
* Start from a nav drawer fragment other than the contact list, for example Forums
* Select Settings from the nav drawer
* Use the back button (or up button) to return to the previous screen
* The nav drawer still shows Settings as selected
I mention the variant to show that there are cases that don't involve switching between nav drawer fragments.
A related question: should navigating back from Settings return us to the previous screen, or to the contact list, as with other nav drawer destinations?Milestone Fhttps://code.briarproject.org/briar/briar/-/issues/781Use H2's small build target2021-12-03T14:26:41ZakwizgranUse H2's small build targetH2 provides a 'jarSmall' build target that produces a smaller jar containing fewer optional features and resources. The smaller jar includes everything we need, and would reduce our APK size by around 500 k. Unfortunately it's not availa...H2 provides a 'jarSmall' build target that produces a smaller jar containing fewer optional features and resources. The smaller jar includes everything we need, and would reduce our APK size by around 500 k. Unfortunately it's not available from JCenter.
Removing the unneeded features and resources with ProGuard isn't simple, as most of the savings come from resources in a zip file embedded in the jar.https://code.briarproject.org/briar/briar/-/issues/780Temporarily leaked Activities on orientation changes2021-04-26T14:01:29ZErnir ErlingssonTemporarily leaked Activities on orientation changesWhile working on #725, I noticed something: we're leaking Activities temporarily.
We are using anonymous inner classes as callbacks for asynchronous tasks, during their execution it's possible that an orientation change occurs that des...While working on #725, I noticed something: we're leaking Activities temporarily.
We are using anonymous inner classes as callbacks for asynchronous tasks, during their execution it's possible that an orientation change occurs that destroys the old Activity/Fragment. The task stores a reference to the callback, and therefore implicitly to the Activity. This means that the initial Activity will be kept alive until the task finishes execution. Multiple orientation changes will might result in multiple Activities being temporarily leaked, although !415 relieves some of that by ensuring there is only one leaked Activity maximum.
Not sure what the best course of action here is, we could try to handle the orientation changes ourselves which re-uses the initial Activity but will require careful programming.
https://developer.android.com/guide/topics/resources/runtime-changes.html#HandlingTheChangehttps://code.briarproject.org/briar/briar/-/issues/779Use HTTPS for fetching RSS feeds where possible2020-11-21T16:18:44ZakwizgranUse HTTPS for fetching RSS feeds where possibleOn the first fetch:
* If the user enters an HTTP URL, try HTTPS first, then fall back to HTTP
* If the user enters a URL without a scheme, try HTTPS first, then fall back to HTTP
* If the user enters an HTTPS URL, don't fall back to HTTP...On the first fetch:
* If the user enters an HTTP URL, try HTTPS first, then fall back to HTTP
* If the user enters a URL without a scheme, try HTTPS first, then fall back to HTTP
* If the user enters an HTTPS URL, don't fall back to HTTP
* If HTTPS succeeds, save the HTTPS URL
On subsequent fetches, use the scheme from the URL with no fallbacks.https://code.briarproject.org/briar/briar/-/issues/778Move unit tests into their respective modules2017-12-18T07:40:26ZakwizgranMove unit tests into their respective modulesThe briar-tests module contains a mixture of Briar and Bramble tests. Move the tests into their respective modules.
Subtask of #136.The briar-tests module contains a mixture of Briar and Bramble tests. Move the tests into their respective modules.
Subtask of #136.Milestone FTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/777Move integration tests into their respective modules2017-12-18T07:40:27ZakwizgranMove integration tests into their respective modulesWhen we switched from Guice to Dagger, we put the integration tests in an Android module because the android-apt plugin didn't support Java modules. An APT plugin that supports Java modules is now available, so we can move the integratio...When we switched from Guice to Dagger, we put the integration tests in an Android module because the android-apt plugin didn't support Java modules. An APT plugin that supports Java modules is now available, so we can move the integration tests into their respective modules and remove the briar-android-tests module.
https://bitbucket.org/hvisser/android-apt/issues/18/support-java-plugin#comment-20327914
https://plugins.gradle.org/plugin/net.ltgt.apt
The "idea" plugin should also be used so that Android Studio recognises the generated classes:
http://stackoverflow.com/a/37963784
Subtask of #136.Milestone FTorsten GroteTorsten Grote