Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
briar
briar
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 579
    • Issues 579
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 8
    • Merge Requests 8
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • briar
  • briarbriar
  • Merge Requests
  • !928

Open
Opened Sep 19, 2018 by Julian Dehm@goapunk
  • Report abuse
Report abuse

Fix nonlocalized timestamp

On Android < 6 DateUtils picks up the system language to build strings, therefore the timestamps are shown in the wrong language when anything else than System default is used as language in Briar.

This MR fixes the following things:

  • Update the system configuration on API < 23 so DateUtils picks up the right language
  • Respect the deprecation of updateConfiguration where possible.
  • Skips setting the locale if the os language is used
  • Set the locale only once (on start).
  • Hide languages using the Devanagari script on API 15
  • Hides Asturian on API < 21 because it won't be picked up by Android.
  • Fixes the foreground notification using the old language after account deletion.

I tested the changes (mostly) in the emulator an APIs 15,16, 21,23,28.

closes #1470

Edited Mar 04, 2019 by Julian Dehm

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

-# All repo/branch refs have been quoted to allow support for special characters (such as #my-branch)
git fetch "https://code.briarproject.org/goapunk/briar.git" "fix_nonlocalized_timestamp"
git checkout -b "goapunk/briar-fix_nonlocalized_timestamp" FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "goapunk/briar-fix_nonlocalized_timestamp"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 46
  • Commits 9
  • Pipelines 21
  • Changes 6
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: briar/briar!928