Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
Python Briar Wrapper
Python Briar Wrapper
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • External Wiki
    • External Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • briar
  • Python Briar WrapperPython Briar Wrapper
  • Issues
  • #19

Closed
Open
Opened Oct 05, 2020 by Torsten Grote@groteOwner

Adding contacts remotely does not check return value, hides errors

It looks like, the result of the POST request isn't checked here:

https://code.briarproject.org/briar/python-briar-wrapper/-/blob/b8ac26b21dd5b3580d49a582c7b16cebd6c3dc3e/briar_wrapper/models/contacts.py#L37

I found this when debugging why failed pending contacts don't get re-added. Check how the Android UI handles this:

  • https://code.briarproject.org/briar/briar/-/blob/1f246637e25a9e53e7b9ec8961e1ad6bf26a7daf/briar-android/src/main/java/org/briarproject/briar/android/contact/add/remote/NicknameFragment.java#L123

  • https://code.briarproject.org/briar/briar/-/blob/1f246637e25a9e53e7b9ec8961e1ad6bf26a7daf/briar-android/src/main/java/org/briarproject/briar/android/contact/add/remote/AddContactViewModel.java#L124

Assignee
Assign to
Wrapper 0.0.7
Milestone
Wrapper 0.0.7
Assign milestone
Time tracking
None
Due date
None
Reference: briar/python-briar-wrapper#19