From 02c23f1378fa1d4db8b0c2a4bdf7d566dfec312e Mon Sep 17 00:00:00 2001
From: akwizgran <michael@briarproject.org>
Date: Tue, 2 Apr 2013 12:10:26 +0100
Subject: [PATCH] Don't erase the original password array, erase the copy.
---
briar-core/src/net/sf/briar/db/H2Database.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/briar-core/src/net/sf/briar/db/H2Database.java b/briar-core/src/net/sf/briar/db/H2Database.java
index 5bb1dcc525..1727ee9dd8 100644
--- a/briar-core/src/net/sf/briar/db/H2Database.java
+++ b/briar-core/src/net/sf/briar/db/H2Database.java
@@ -74,13 +74,14 @@ class H2Database extends JdbcDatabase {
@Override
protected Connection createConnection() throws SQLException {
+ char[] passwordCopy = password.clone();
Properties props = new Properties();
props.setProperty("user", "user");
- props.put("password", password);
+ props.put("password", passwordCopy);
try {
return DriverManager.getConnection(url, props);
} finally {
- Arrays.fill(password, (char) 0);
+ Arrays.fill(passwordCopy, (char) 0);
}
}
}
--
GitLab