diff --git a/briar-api/src/net/sf/briar/api/protocol/Transport.java b/briar-api/src/net/sf/briar/api/protocol/Transport.java index 4ac071160b95a1d5ce3e7e28cb68c4f26473d365..a8ea4a31517ba155ebe1e3d1e0de9c7739d40dd1 100644 --- a/briar-api/src/net/sf/briar/api/protocol/Transport.java +++ b/briar-api/src/net/sf/briar/api/protocol/Transport.java @@ -26,6 +26,11 @@ public class Transport { return properties; } + @Override + public int hashCode() { + return id.hashCode() ^ properties.hashCode(); + } + @Override public boolean equals(Object o) { if(o instanceof Transport) { @@ -34,9 +39,4 @@ public class Transport { } return false; } - - @Override - public int hashCode() { - return id.hashCode(); - } } diff --git a/briar-core/src/net/sf/briar/plugins/PollerImpl.java b/briar-core/src/net/sf/briar/plugins/PollerImpl.java index 3448070de90124e9826814965519ec7c28a5e8c7..29ea3c91326972e72f8bd1f8ec4a185c6c4b8f0b 100644 --- a/briar-core/src/net/sf/briar/plugins/PollerImpl.java +++ b/briar-core/src/net/sf/briar/plugins/PollerImpl.java @@ -96,15 +96,17 @@ class PollerImpl implements Poller, Runnable { this.plugin = plugin; } + // Must be consistent with equals() public int compareTo(PollTime p) { if(time < p.time) return -1; if(time > p.time) return 1; return 0; } + // Must be consistent with equals() @Override public int hashCode() { - return (int) time; + return (int) (time ^ (time >>> 32)) ^ plugin.hashCode(); } @Override diff --git a/briar-core/src/net/sf/briar/plugins/modem/Frame.java b/briar-core/src/net/sf/briar/plugins/modem/Frame.java index fc80bd6b88ab0388a57eb1db572af1898752d56b..288c606844b1ac9b9dc349803ef9a43c0df65d84 100644 --- a/briar-core/src/net/sf/briar/plugins/modem/Frame.java +++ b/briar-core/src/net/sf/briar/plugins/modem/Frame.java @@ -42,7 +42,8 @@ abstract class Frame { @Override public int hashCode() { - return (int) getSequenceNumber(); + long sequenceNumber = getSequenceNumber(); + return buf[0] ^ (int) (sequenceNumber ^ (sequenceNumber >>> 32)); } @Override diff --git a/briar-core/src/net/sf/briar/transport/KeyManagerImpl.java b/briar-core/src/net/sf/briar/transport/KeyManagerImpl.java index 5117562d4c9b1b92ff4b94265bcce6294ca819c3..39136daf31bcad5b97af11f94bd265763678fbc3 100644 --- a/briar-core/src/net/sf/briar/transport/KeyManagerImpl.java +++ b/briar-core/src/net/sf/briar/transport/KeyManagerImpl.java @@ -352,7 +352,7 @@ class KeyManagerImpl extends TimerTask implements KeyManager, DatabaseListener { @Override public int hashCode() { - return contactId.hashCode() + transportId.hashCode(); + return contactId.hashCode() ^ transportId.hashCode(); } @Override diff --git a/briar-core/src/net/sf/briar/transport/TransportConnectionRecogniser.java b/briar-core/src/net/sf/briar/transport/TransportConnectionRecogniser.java index 079f9e09e1b944e168c1716a9fa9e62cb843fd7a..dfada60a59e3485baed940d4c1372d780fd51bb2 100644 --- a/briar-core/src/net/sf/briar/transport/TransportConnectionRecogniser.java +++ b/briar-core/src/net/sf/briar/transport/TransportConnectionRecogniser.java @@ -164,7 +164,7 @@ class TransportConnectionRecogniser { @Override public int hashCode() { - return contactId.hashCode() + (int) period; + return contactId.hashCode() ^ (int) (period ^ (period >>> 32)); } @Override