diff --git a/briar-android/src/org/briarproject/android/ActivityModule.java b/briar-android/src/org/briarproject/android/ActivityModule.java index 47d8d134183a59a2b91420434d5b153b3d3ad99a..0e13fbd0d7aa59311bf86b0b664a8afd6bfc5f46 100644 --- a/briar-android/src/org/briarproject/android/ActivityModule.java +++ b/briar-android/src/org/briarproject/android/ActivityModule.java @@ -10,8 +10,8 @@ import org.briarproject.android.controller.BriarController; import org.briarproject.android.controller.BriarControllerImpl; import org.briarproject.android.controller.ConfigController; import org.briarproject.android.controller.ConfigControllerImpl; -import org.briarproject.android.controller.DBController; -import org.briarproject.android.controller.DBControllerImpl; +import org.briarproject.android.controller.DbController; +import org.briarproject.android.controller.DbControllerImpl; import org.briarproject.android.controller.NavDrawerController; import org.briarproject.android.controller.NavDrawerControllerImpl; import org.briarproject.android.controller.PasswordController; @@ -93,8 +93,8 @@ public class ActivityModule { @ActivityScope @Provides - protected DBController provideDBController( - DBControllerImpl dbController) { + protected DbController provideDBController( + DbControllerImpl dbController) { return dbController; } diff --git a/briar-android/src/org/briarproject/android/BriarActivity.java b/briar-android/src/org/briarproject/android/BriarActivity.java index b175224da86c6e09a149dc4a0e8caba43c12ddf7..24cc0dd974c3b9dc03ca8e0ccecf5b76d89b46e8 100644 --- a/briar-android/src/org/briarproject/android/BriarActivity.java +++ b/briar-android/src/org/briarproject/android/BriarActivity.java @@ -5,7 +5,7 @@ import android.content.Intent; import android.os.Build; import org.briarproject.android.controller.BriarController; -import org.briarproject.android.controller.DBController; +import org.briarproject.android.controller.DbController; import org.briarproject.android.controller.handler.UiResultHandler; import org.briarproject.android.panic.ExitActivity; @@ -36,7 +36,7 @@ public abstract class BriarActivity extends BaseActivity { protected BriarController briarController; // TODO remove this when the deprecated method runOnDbThread is removed @Inject - protected DBController dbController; + protected DbController dbController; @Override protected void onActivityResult(int request, int result, Intent data) { diff --git a/briar-android/src/org/briarproject/android/NavDrawerActivity.java b/briar-android/src/org/briarproject/android/NavDrawerActivity.java index 3db285f5a33ddad0ea47d86b0ba512e84f893491..3c61bbf4883ae8fe5754c69c8d6cbb89b6750cb6 100644 --- a/briar-android/src/org/briarproject/android/NavDrawerActivity.java +++ b/briar-android/src/org/briarproject/android/NavDrawerActivity.java @@ -67,14 +67,13 @@ public class NavDrawerActivity extends BriarFragmentActivity implements @Override protected void onNewIntent(Intent intent) { super.onNewIntent(intent); - if (!isStartupFailed(intent)) { - checkAuthorHandle(intent); - clearBackStack(); - if (intent.getBooleanExtra(INTENT_FORUMS, false)) - startFragment(activityComponent.newForumListFragment()); - else if (intent.getBooleanExtra(INTENT_CONTACTS, false)) - startFragment(activityComponent.newContactListFragment()); - } + exitIfStartupFailed(intent); + checkAuthorHandle(intent); + clearBackStack(); + if (intent.getBooleanExtra(INTENT_FORUMS, false)) + startFragment(activityComponent.newForumListFragment()); + else if (intent.getBooleanExtra(INTENT_CONTACTS, false)) + startFragment(activityComponent.newContactListFragment()); } @Override @@ -86,10 +85,7 @@ public class NavDrawerActivity extends BriarFragmentActivity implements @Override public void onCreate(Bundle state) { super.onCreate(state); - - if (isStartupFailed(getIntent())) - return; - + exitIfStartupFailed(getIntent()); setContentView(R.layout.activity_nav_drawer); toolbar = (Toolbar) findViewById(R.id.toolbar); @@ -106,7 +102,6 @@ public class NavDrawerActivity extends BriarFragmentActivity implements R.string.nav_drawer_open_description, R.string.nav_drawer_close_description); drawerLayout.setDrawerListener(drawerToggle); - LOG.info("NavDrawerActivity created: " + (state == null)); if (state == null) { startFragment(activityComponent.newContactListFragment()); } else { @@ -154,14 +149,12 @@ public class NavDrawerActivity extends BriarFragmentActivity implements } } - private boolean isStartupFailed(Intent intent) { + private void exitIfStartupFailed(Intent intent) { if (intent.getBooleanExtra(KEY_STARTUP_FAILED, false)) { finish(); LOG.info("Exiting"); System.exit(0); - return true; } - return false; } private void storeLocalAuthor(LocalAuthor a) { diff --git a/briar-android/src/org/briarproject/android/controller/DBController.java b/briar-android/src/org/briarproject/android/controller/DbController.java similarity index 72% rename from briar-android/src/org/briarproject/android/controller/DBController.java rename to briar-android/src/org/briarproject/android/controller/DbController.java index 1117080399a133971fc233f6271d36db003589b5..f0c186bf3485f062e3cc1fa93f7d60bf213d0d1b 100644 --- a/briar-android/src/org/briarproject/android/controller/DBController.java +++ b/briar-android/src/org/briarproject/android/controller/DbController.java @@ -1,7 +1,6 @@ package org.briarproject.android.controller; -public interface DBController { +public interface DbController { void runOnDbThread(Runnable task); - } diff --git a/briar-android/src/org/briarproject/android/controller/DBControllerImpl.java b/briar-android/src/org/briarproject/android/controller/DbControllerImpl.java similarity index 85% rename from briar-android/src/org/briarproject/android/controller/DBControllerImpl.java rename to briar-android/src/org/briarproject/android/controller/DbControllerImpl.java index 34d8b69e4a31f6984015526106d99687ee229296..14f5d41aee85232372bddc96743962c10ad150c5 100644 --- a/briar-android/src/org/briarproject/android/controller/DBControllerImpl.java +++ b/briar-android/src/org/briarproject/android/controller/DbControllerImpl.java @@ -8,10 +8,10 @@ import java.util.logging.Logger; import javax.inject.Inject; -public class DBControllerImpl implements DBController { +public class DbControllerImpl implements DbController { private static final Logger LOG = - Logger.getLogger(BriarControllerImpl.class.getName()); + Logger.getLogger(DbControllerImpl.class.getName()); // Fields that are accessed from background threads must be volatile @Inject @@ -21,7 +21,7 @@ public class DBControllerImpl implements DBController { protected volatile LifecycleManager lifecycleManager; @Inject - public DBControllerImpl() { + public DbControllerImpl() { } diff --git a/briar-android/src/org/briarproject/android/controller/NavDrawerControllerImpl.java b/briar-android/src/org/briarproject/android/controller/NavDrawerControllerImpl.java index 1e492b3dbc4044f21460e5588d28a52bb42ee20f..7ca4fe4758440d7bd6c4664ce817e369979a9db5 100644 --- a/briar-android/src/org/briarproject/android/controller/NavDrawerControllerImpl.java +++ b/briar-android/src/org/briarproject/android/controller/NavDrawerControllerImpl.java @@ -23,7 +23,7 @@ import javax.inject.Inject; import static java.util.logging.Level.INFO; import static java.util.logging.Level.WARNING; -public class NavDrawerControllerImpl extends DBControllerImpl +public class NavDrawerControllerImpl extends DbControllerImpl implements NavDrawerController, EventListener { private static final Logger LOG =