From 1e5e78cc44e3c2e4217e6151d1b7f423ab64b12f Mon Sep 17 00:00:00 2001
From: akwizgran <michael@briarproject.org>
Date: Thu, 25 Apr 2013 05:07:26 +0100
Subject: [PATCH] Use Integer.parseInt(String) to get a primitive int.
---
.../src/net/sf/briar/android/invitation/CodeEntryWidget.java | 2 +-
briar-core/src/net/sf/briar/plugins/tcp/LanTcpPlugin.java | 2 +-
briar-core/src/net/sf/briar/plugins/tcp/TcpPlugin.java | 2 +-
briar-core/src/net/sf/briar/plugins/tcp/WanTcpPlugin.java | 2 +-
briar-tests/src/net/sf/briar/plugins/tcp/LanTcpPluginTest.java | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/briar-android/src/net/sf/briar/android/invitation/CodeEntryWidget.java b/briar-android/src/net/sf/briar/android/invitation/CodeEntryWidget.java
index 68f73f2982..657cb5c3d9 100644
--- a/briar-android/src/net/sf/briar/android/invitation/CodeEntryWidget.java
+++ b/briar-android/src/net/sf/briar/android/invitation/CodeEntryWidget.java
@@ -84,7 +84,7 @@ implements OnEditorActionListener, OnClickListener {
String remoteCodeString = codeEntry.getText().toString();
int remoteCode;
try {
- remoteCode = Integer.valueOf(remoteCodeString);
+ remoteCode = Integer.parseInt(remoteCodeString);
} catch(NumberFormatException e) {
return false;
}
diff --git a/briar-core/src/net/sf/briar/plugins/tcp/LanTcpPlugin.java b/briar-core/src/net/sf/briar/plugins/tcp/LanTcpPlugin.java
index e67697d5d4..aeb307c6f4 100644
--- a/briar-core/src/net/sf/briar/plugins/tcp/LanTcpPlugin.java
+++ b/briar-core/src/net/sf/briar/plugins/tcp/LanTcpPlugin.java
@@ -73,7 +73,7 @@ class LanTcpPlugin extends TcpPlugin {
!StringUtils.isNullOrEmpty(portString)) {
try {
addr = InetAddress.getByName(addrString);
- int port = Integer.valueOf(portString);
+ int port = Integer.parseInt(portString);
addrs.add(new InetSocketAddress(addr, port));
addrs.add(new InetSocketAddress(addr, 0));
} catch(NumberFormatException e) {
diff --git a/briar-core/src/net/sf/briar/plugins/tcp/TcpPlugin.java b/briar-core/src/net/sf/briar/plugins/tcp/TcpPlugin.java
index 230bbd4e1c..5f8fb8195f 100644
--- a/briar-core/src/net/sf/briar/plugins/tcp/TcpPlugin.java
+++ b/briar-core/src/net/sf/briar/plugins/tcp/TcpPlugin.java
@@ -191,7 +191,7 @@ abstract class TcpPlugin implements DuplexPlugin {
if(StringUtils.isNullOrEmpty(portString)) return null;
try {
InetAddress addr = InetAddress.getByName(addrString);
- int port = Integer.valueOf(portString);
+ int port = Integer.parseInt(portString);
return new InetSocketAddress(addr, port);
} catch(NumberFormatException e) {
if(LOG.isLoggable(WARNING)) LOG.log(WARNING, e.toString(), e);
diff --git a/briar-core/src/net/sf/briar/plugins/tcp/WanTcpPlugin.java b/briar-core/src/net/sf/briar/plugins/tcp/WanTcpPlugin.java
index 008e118555..962d52ccc5 100644
--- a/briar-core/src/net/sf/briar/plugins/tcp/WanTcpPlugin.java
+++ b/briar-core/src/net/sf/briar/plugins/tcp/WanTcpPlugin.java
@@ -64,7 +64,7 @@ class WanTcpPlugin extends TcpPlugin {
!StringUtils.isNullOrEmpty(portString)) {
try {
addr = InetAddress.getByName(addrString);
- port = Integer.valueOf(portString);
+ port = Integer.parseInt(portString);
addrs.add(new InetSocketAddress(addr, port));
addrs.add(new InetSocketAddress(addr, 0));
} catch(NumberFormatException e) {
diff --git a/briar-tests/src/net/sf/briar/plugins/tcp/LanTcpPluginTest.java b/briar-tests/src/net/sf/briar/plugins/tcp/LanTcpPluginTest.java
index 80d6eec797..61d563c34d 100644
--- a/briar-tests/src/net/sf/briar/plugins/tcp/LanTcpPluginTest.java
+++ b/briar-tests/src/net/sf/briar/plugins/tcp/LanTcpPluginTest.java
@@ -45,7 +45,7 @@ public class LanTcpPluginTest extends BriarTestCase {
assertEquals("127.0.0.1", host);
String portString = callback.local.get("port");
assertNotNull(portString);
- int port = Integer.valueOf(portString);
+ int port = Integer.parseInt(portString);
assertTrue(port > 0 && port < 65536);
// The plugin should be listening on the port
InetSocketAddress addr = new InetSocketAddress(host, port);
--
GitLab