From 25324697acc636f5c1578aeb0aeff9a9d287b2a9 Mon Sep 17 00:00:00 2001 From: Ernir Erlingsson <ernir@ymirmobile.com> Date: Thu, 3 Mar 2016 10:49:57 +0100 Subject: [PATCH] cleanup and added missing desktop modules --- .../sync/SimplexMessagingComponent.java | 3 -- .../android/SplashScreenActivity.java | 3 -- .../lifecycle/DesktopLifecycleModule.java | 35 ++++++++++++------- .../system/DesktopSystemModule.java | 28 ++++++++++----- 4 files changed, 43 insertions(+), 26 deletions(-) diff --git a/briar-android-tests/src/test/java/org/briarproject/sync/SimplexMessagingComponent.java b/briar-android-tests/src/test/java/org/briarproject/sync/SimplexMessagingComponent.java index 83bc5f1c84..2e3e194427 100644 --- a/briar-android-tests/src/test/java/org/briarproject/sync/SimplexMessagingComponent.java +++ b/briar-android-tests/src/test/java/org/briarproject/sync/SimplexMessagingComponent.java @@ -28,9 +28,6 @@ import javax.inject.Singleton; import dagger.Component; -/** - * Created by Ernir Erlingsson (ernir@ymirmobile.com) on 3.3.2016. - */ @Singleton @Component(modules = {TestDatabaseModule.class, TestSystemModule.class, LifecycleModule.class, ContactModule.class, CryptoModule.class, diff --git a/briar-android/src/org/briarproject/android/SplashScreenActivity.java b/briar-android/src/org/briarproject/android/SplashScreenActivity.java index c79f9a3505..ef374c1130 100644 --- a/briar-android/src/org/briarproject/android/SplashScreenActivity.java +++ b/briar-android/src/org/briarproject/android/SplashScreenActivity.java @@ -1,8 +1,6 @@ package org.briarproject.android; -import android.app.Activity; import android.content.Intent; -import android.content.SharedPreferences; import android.graphics.Color; import android.os.Bundle; import android.os.Handler; @@ -16,7 +14,6 @@ import android.widget.LinearLayout; import org.briarproject.R; import org.briarproject.android.util.LayoutUtils; import org.briarproject.api.db.DatabaseConfig; -import org.briarproject.api.ui.UiCallback; import org.briarproject.util.FileUtils; import java.util.logging.Logger; diff --git a/briar-desktop/src/org/briarproject/lifecycle/DesktopLifecycleModule.java b/briar-desktop/src/org/briarproject/lifecycle/DesktopLifecycleModule.java index 63c913cca5..4986668b1e 100644 --- a/briar-desktop/src/org/briarproject/lifecycle/DesktopLifecycleModule.java +++ b/briar-desktop/src/org/briarproject/lifecycle/DesktopLifecycleModule.java @@ -1,25 +1,36 @@ package org.briarproject.lifecycle; +import org.briarproject.api.db.DatabaseComponent; +import org.briarproject.api.event.EventBus; import org.briarproject.api.lifecycle.LifecycleManager; import org.briarproject.api.lifecycle.ShutdownManager; +import org.briarproject.api.system.Clock; import org.briarproject.util.OsUtils; +import javax.inject.Singleton; +import dagger.Module; +import dagger.Provides; + +@Module public class DesktopLifecycleModule extends LifecycleModule { - /* - // TODO - @Override - protected void configure() { - bind(LifecycleManager.class).to( - LifecycleManagerImpl.class).in(Singleton.class); + @Provides + @Singleton + LifecycleManager provideLifecycleManager(Clock clock, DatabaseComponent db, + EventBus eventBus) { + return new LifecycleManagerImpl(clock, db, eventBus); + } + + @Provides + @Singleton + ShutdownManager provideDesktopShutdownManager() { if (OsUtils.isWindows()) { - bind(ShutdownManager.class).to( - WindowsShutdownManagerImpl.class).in(Singleton.class); - } else { - bind(ShutdownManager.class).to( - ShutdownManagerImpl.class).in(Singleton.class); + return new WindowsShutdownManagerImpl(); + } + else { + return new ShutdownManagerImpl(); } } - */ + } diff --git a/briar-desktop/src/org/briarproject/system/DesktopSystemModule.java b/briar-desktop/src/org/briarproject/system/DesktopSystemModule.java index d3186ed1b6..ab811ebba8 100644 --- a/briar-desktop/src/org/briarproject/system/DesktopSystemModule.java +++ b/briar-desktop/src/org/briarproject/system/DesktopSystemModule.java @@ -5,15 +5,27 @@ import org.briarproject.api.system.SeedProvider; import org.briarproject.api.system.Timer; import org.briarproject.util.OsUtils; +import dagger.Module; +import dagger.Provides; + +@Module public class DesktopSystemModule { - /* - // TODO - protected void configure() { - bind(Clock.class).to(SystemClock.class); - bind(Timer.class).to(SystemTimer.class); - if (OsUtils.isLinux()) - bind(SeedProvider.class).to(LinuxSeedProvider.class); + @Provides + Clock provideClock() { + return new SystemClock(); + } + + @Provides + Timer provideTimer() { + return new SystemTimer(); + } + + @Provides + SeedProvider provideSeedProvider() { + if (OsUtils.isLinux()) { + return new LinuxSeedProvider(); + } + return null; } - */ } -- GitLab