From 39b7a97267d6ac271dfc9d3f102882efcaea61c8 Mon Sep 17 00:00:00 2001
From: akwizgran <akwizgran@users.sourceforge.net>
Date: Tue, 4 Mar 2014 14:22:19 +0000
Subject: [PATCH] "Implicit intents with startService are not safe" - use an
explicit one.
---
briar-android/src/org/briarproject/android/BriarActivity.java | 4 ++--
briar-android/src/org/briarproject/android/BriarService.java | 2 --
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/briar-android/src/org/briarproject/android/BriarActivity.java b/briar-android/src/org/briarproject/android/BriarActivity.java
index 2ee5ae119f..09f1dfe84f 100644
--- a/briar-android/src/org/briarproject/android/BriarActivity.java
+++ b/briar-android/src/org/briarproject/android/BriarActivity.java
@@ -69,8 +69,8 @@ public class BriarActivity extends RoboFragmentActivity {
}
private void startAndBindService() {
- startService(new Intent(BriarService.class.getName()));
- bound = bindService(new Intent(BriarService.class.getName()),
+ startService(new Intent(this, BriarService.class));
+ bound = bindService(new Intent(this, BriarService.class),
serviceConnection, 0);
}
diff --git a/briar-android/src/org/briarproject/android/BriarService.java b/briar-android/src/org/briarproject/android/BriarService.java
index 2781d2a7b9..4e556b2db7 100644
--- a/briar-android/src/org/briarproject/android/BriarService.java
+++ b/briar-android/src/org/briarproject/android/BriarService.java
@@ -124,12 +124,10 @@ public class BriarService extends RoboService implements EventListener {
@Override
public int onStartCommand(Intent intent, int flags, int startId) {
- if(LOG.isLoggable(INFO)) LOG.info("Started");
return START_NOT_STICKY; // Don't restart automatically if killed
}
public IBinder onBind(Intent intent) {
- if(LOG.isLoggable(INFO)) LOG.info("Bound");
return binder;
}
--
GitLab