From 421ce904698de22cde49fdf3dc29383b411b8b34 Mon Sep 17 00:00:00 2001
From: akwizgran <michael@briarproject.org>
Date: Fri, 26 Apr 2013 18:50:55 +0100
Subject: [PATCH] Replaced a FIXME with an explanation of why it doesn't need
to be fixed.
---
.../net/sf/briar/android/invitation/AddContactActivity.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/briar-android/src/net/sf/briar/android/invitation/AddContactActivity.java b/briar-android/src/net/sf/briar/android/invitation/AddContactActivity.java
index c197ac8f58..dac361defa 100644
--- a/briar-android/src/net/sf/briar/android/invitation/AddContactActivity.java
+++ b/briar-android/src/net/sf/briar/android/invitation/AddContactActivity.java
@@ -259,9 +259,9 @@ implements InvitationListener {
task = invitationTaskFactory.createTask(localAuthorId,
localInvitationCode, code);
taskHandle = referenceManager.putReference(task, InvitationTask.class);
- // FIXME: Why can't the activity clean up the reference? If the task
- // has a reference to the activity (as a listener), it won't be GCed
task.addListener(AddContactActivity.this);
+ // Add a second listener so we can remove the first in onDestroy(),
+ // allowing the activity to be garbage collected if it's destroyed
task.addListener(new ReferenceCleaner(referenceManager, taskHandle));
task.connect();
}
--
GitLab