From 4e0990d865260c4043516a17882632a22e0bebee Mon Sep 17 00:00:00 2001 From: akwizgran <akwizgran@users.sourceforge.net> Date: Fri, 26 Feb 2016 11:12:31 +0000 Subject: [PATCH] Removed unused dependencies from invitation classes. --- .../briarproject/invitation/AliceConnector.java | 7 ++----- .../briarproject/invitation/BobConnector.java | 7 ++----- .../org/briarproject/invitation/Connector.java | 9 +-------- .../briarproject/invitation/ConnectorGroup.java | 17 +++++------------ .../invitation/InvitationTaskFactoryImpl.java | 14 +++----------- 5 files changed, 13 insertions(+), 41 deletions(-) diff --git a/briar-core/src/org/briarproject/invitation/AliceConnector.java b/briar-core/src/org/briarproject/invitation/AliceConnector.java index 47c7b0a16d..39945bf6b6 100644 --- a/briar-core/src/org/briarproject/invitation/AliceConnector.java +++ b/briar-core/src/org/briarproject/invitation/AliceConnector.java @@ -15,9 +15,7 @@ import org.briarproject.api.identity.LocalAuthor; import org.briarproject.api.plugins.ConnectionManager; import org.briarproject.api.plugins.duplex.DuplexPlugin; import org.briarproject.api.plugins.duplex.DuplexTransportConnection; -import org.briarproject.api.sync.GroupFactory; import org.briarproject.api.system.Clock; -import org.briarproject.api.transport.KeyManager; import org.briarproject.api.transport.StreamReaderFactory; import org.briarproject.api.transport.StreamWriterFactory; @@ -41,12 +39,11 @@ class AliceConnector extends Connector { BdfWriterFactory bdfWriterFactory, StreamReaderFactory streamReaderFactory, StreamWriterFactory streamWriterFactory, - AuthorFactory authorFactory, GroupFactory groupFactory, - KeyManager keyManager, ConnectionManager connectionManager, + AuthorFactory authorFactory, ConnectionManager connectionManager, ContactManager contactManager, Clock clock, ConnectorGroup group, DuplexPlugin plugin, LocalAuthor localAuthor, PseudoRandom random) { super(crypto, bdfReaderFactory, bdfWriterFactory, streamReaderFactory, - streamWriterFactory, authorFactory, groupFactory, keyManager, + streamWriterFactory, authorFactory, connectionManager, contactManager, clock, group, plugin, localAuthor, random); } diff --git a/briar-core/src/org/briarproject/invitation/BobConnector.java b/briar-core/src/org/briarproject/invitation/BobConnector.java index 945c56d1c6..53bdbe3e47 100644 --- a/briar-core/src/org/briarproject/invitation/BobConnector.java +++ b/briar-core/src/org/briarproject/invitation/BobConnector.java @@ -15,9 +15,7 @@ import org.briarproject.api.identity.LocalAuthor; import org.briarproject.api.plugins.ConnectionManager; import org.briarproject.api.plugins.duplex.DuplexPlugin; import org.briarproject.api.plugins.duplex.DuplexTransportConnection; -import org.briarproject.api.sync.GroupFactory; import org.briarproject.api.system.Clock; -import org.briarproject.api.transport.KeyManager; import org.briarproject.api.transport.StreamReaderFactory; import org.briarproject.api.transport.StreamWriterFactory; @@ -41,12 +39,11 @@ class BobConnector extends Connector { BdfWriterFactory bdfWriterFactory, StreamReaderFactory streamReaderFactory, StreamWriterFactory streamWriterFactory, - AuthorFactory authorFactory, GroupFactory groupFactory, - KeyManager keyManager, ConnectionManager connectionManager, + AuthorFactory authorFactory, ConnectionManager connectionManager, ContactManager contactManager, Clock clock, ConnectorGroup group, DuplexPlugin plugin, LocalAuthor localAuthor, PseudoRandom random) { super(crypto, bdfReaderFactory, bdfWriterFactory, streamReaderFactory, - streamWriterFactory, authorFactory, groupFactory, keyManager, + streamWriterFactory, authorFactory, connectionManager, contactManager, clock, group, plugin, localAuthor, random); } diff --git a/briar-core/src/org/briarproject/invitation/Connector.java b/briar-core/src/org/briarproject/invitation/Connector.java index 702671364f..8b26b16295 100644 --- a/briar-core/src/org/briarproject/invitation/Connector.java +++ b/briar-core/src/org/briarproject/invitation/Connector.java @@ -22,9 +22,7 @@ import org.briarproject.api.identity.LocalAuthor; import org.briarproject.api.plugins.ConnectionManager; import org.briarproject.api.plugins.duplex.DuplexPlugin; import org.briarproject.api.plugins.duplex.DuplexTransportConnection; -import org.briarproject.api.sync.GroupFactory; import org.briarproject.api.system.Clock; -import org.briarproject.api.transport.KeyManager; import org.briarproject.api.transport.StreamReaderFactory; import org.briarproject.api.transport.StreamWriterFactory; @@ -52,8 +50,6 @@ abstract class Connector extends Thread { protected final StreamReaderFactory streamReaderFactory; protected final StreamWriterFactory streamWriterFactory; protected final AuthorFactory authorFactory; - protected final GroupFactory groupFactory; - protected final KeyManager keyManager; protected final ConnectionManager connectionManager; protected final ContactManager contactManager; protected final Clock clock; @@ -74,8 +70,7 @@ abstract class Connector extends Thread { BdfWriterFactory bdfWriterFactory, StreamReaderFactory streamReaderFactory, StreamWriterFactory streamWriterFactory, - AuthorFactory authorFactory, GroupFactory groupFactory, - KeyManager keyManager, ConnectionManager connectionManager, + AuthorFactory authorFactory, ConnectionManager connectionManager, ContactManager contactManager, Clock clock, ConnectorGroup group, DuplexPlugin plugin, LocalAuthor localAuthor, PseudoRandom random) { super("Connector"); @@ -85,8 +80,6 @@ abstract class Connector extends Thread { this.streamReaderFactory = streamReaderFactory; this.streamWriterFactory = streamWriterFactory; this.authorFactory = authorFactory; - this.groupFactory = groupFactory; - this.keyManager = keyManager; this.connectionManager = connectionManager; this.contactManager = contactManager; this.clock = clock; diff --git a/briar-core/src/org/briarproject/invitation/ConnectorGroup.java b/briar-core/src/org/briarproject/invitation/ConnectorGroup.java index 9025c9dff4..30447a06bc 100644 --- a/briar-core/src/org/briarproject/invitation/ConnectorGroup.java +++ b/briar-core/src/org/briarproject/invitation/ConnectorGroup.java @@ -17,9 +17,7 @@ import org.briarproject.api.invitation.InvitationTask; import org.briarproject.api.plugins.ConnectionManager; import org.briarproject.api.plugins.PluginManager; import org.briarproject.api.plugins.duplex.DuplexPlugin; -import org.briarproject.api.sync.GroupFactory; import org.briarproject.api.system.Clock; -import org.briarproject.api.transport.KeyManager; import org.briarproject.api.transport.StreamReaderFactory; import org.briarproject.api.transport.StreamWriterFactory; @@ -48,8 +46,6 @@ class ConnectorGroup extends Thread implements InvitationTask { private final StreamReaderFactory streamReaderFactory; private final StreamWriterFactory streamWriterFactory; private final AuthorFactory authorFactory; - private final GroupFactory groupFactory; - private final KeyManager keyManager; private final ConnectionManager connectionManager; private final IdentityManager identityManager; private final ContactManager contactManager; @@ -74,8 +70,7 @@ class ConnectorGroup extends Thread implements InvitationTask { BdfWriterFactory bdfWriterFactory, StreamReaderFactory streamReaderFactory, StreamWriterFactory streamWriterFactory, - AuthorFactory authorFactory, GroupFactory groupFactory, - KeyManager keyManager, ConnectionManager connectionManager, + AuthorFactory authorFactory, ConnectionManager connectionManager, IdentityManager identityManager, ContactManager contactManager, Clock clock, PluginManager pluginManager, AuthorId localAuthorId, int localInvitationCode, int remoteInvitationCode) { @@ -86,8 +81,6 @@ class ConnectorGroup extends Thread implements InvitationTask { this.streamReaderFactory = streamReaderFactory; this.streamWriterFactory = streamWriterFactory; this.authorFactory = authorFactory; - this.groupFactory = groupFactory; - this.keyManager = keyManager; this.connectionManager = connectionManager; this.identityManager = identityManager; this.contactManager = contactManager; @@ -181,8 +174,8 @@ class ConnectorGroup extends Thread implements InvitationTask { remoteInvitationCode); return new AliceConnector(crypto, bdfReaderFactory, bdfWriterFactory, streamReaderFactory, streamWriterFactory, authorFactory, - groupFactory, keyManager, connectionManager, contactManager, - clock, this, plugin, localAuthor, random); + connectionManager, contactManager, clock, this, plugin, + localAuthor, random); } private Connector createBobConnector(DuplexPlugin plugin, @@ -191,8 +184,8 @@ class ConnectorGroup extends Thread implements InvitationTask { localInvitationCode); return new BobConnector(crypto, bdfReaderFactory, bdfWriterFactory, streamReaderFactory, streamWriterFactory, authorFactory, - groupFactory, keyManager, connectionManager, contactManager, - clock, this, plugin, localAuthor, random); + connectionManager, contactManager, clock, this, plugin, + localAuthor, random); } public void localConfirmationSucceeded() { diff --git a/briar-core/src/org/briarproject/invitation/InvitationTaskFactoryImpl.java b/briar-core/src/org/briarproject/invitation/InvitationTaskFactoryImpl.java index 0b6b4cdf82..49874be45d 100644 --- a/briar-core/src/org/briarproject/invitation/InvitationTaskFactoryImpl.java +++ b/briar-core/src/org/briarproject/invitation/InvitationTaskFactoryImpl.java @@ -11,9 +11,7 @@ import org.briarproject.api.invitation.InvitationTask; import org.briarproject.api.invitation.InvitationTaskFactory; import org.briarproject.api.plugins.ConnectionManager; import org.briarproject.api.plugins.PluginManager; -import org.briarproject.api.sync.GroupFactory; import org.briarproject.api.system.Clock; -import org.briarproject.api.transport.KeyManager; import org.briarproject.api.transport.StreamReaderFactory; import org.briarproject.api.transport.StreamWriterFactory; @@ -27,8 +25,6 @@ class InvitationTaskFactoryImpl implements InvitationTaskFactory { private final StreamReaderFactory streamReaderFactory; private final StreamWriterFactory streamWriterFactory; private final AuthorFactory authorFactory; - private final GroupFactory groupFactory; - private final KeyManager keyManager; private final ConnectionManager connectionManager; private final IdentityManager identityManager; private final ContactManager contactManager; @@ -40,8 +36,7 @@ class InvitationTaskFactoryImpl implements InvitationTaskFactory { BdfReaderFactory bdfReaderFactory, BdfWriterFactory bdfWriterFactory, StreamReaderFactory streamReaderFactory, StreamWriterFactory streamWriterFactory, - AuthorFactory authorFactory, GroupFactory groupFactory, - KeyManager keyManager, ConnectionManager connectionManager, + AuthorFactory authorFactory, ConnectionManager connectionManager, IdentityManager identityManager, ContactManager contactManager, Clock clock, PluginManager pluginManager) { this.crypto = crypto; @@ -50,8 +45,6 @@ class InvitationTaskFactoryImpl implements InvitationTaskFactory { this.streamReaderFactory = streamReaderFactory; this.streamWriterFactory = streamWriterFactory; this.authorFactory = authorFactory; - this.groupFactory = groupFactory; - this.keyManager = keyManager; this.connectionManager = connectionManager; this.identityManager = identityManager; this.contactManager = contactManager; @@ -63,8 +56,7 @@ class InvitationTaskFactoryImpl implements InvitationTaskFactory { int remoteCode) { return new ConnectorGroup(crypto, bdfReaderFactory, bdfWriterFactory, streamReaderFactory, streamWriterFactory, authorFactory, - groupFactory, keyManager, connectionManager, identityManager, - contactManager, clock, pluginManager, localAuthorId, localCode, - remoteCode); + connectionManager, identityManager, contactManager, clock, + pluginManager, localAuthorId, localCode, remoteCode); } } -- GitLab