From 8fc97157d3b244708e6b27e2b3bcebbe7e4c8d51 Mon Sep 17 00:00:00 2001 From: akwizgran <akwizgran@users.sourceforge.net> Date: Mon, 18 Jul 2011 16:17:01 +0100 Subject: [PATCH] Fun fact: it's never worth writing a length as an int8. --- components/net/sf/briar/serial/WriterImpl.java | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/components/net/sf/briar/serial/WriterImpl.java b/components/net/sf/briar/serial/WriterImpl.java index 42083227a1..1a9359aec1 100644 --- a/components/net/sf/briar/serial/WriterImpl.java +++ b/components/net/sf/briar/serial/WriterImpl.java @@ -125,12 +125,10 @@ class WriterImpl implements Writer { } private void writeLength(int i) throws IOException { - if(i >= 0 && i <= Byte.MAX_VALUE) - writeUint7((byte) i); - else if(i >= Byte.MIN_VALUE && i <= Byte.MAX_VALUE) - writeInt8((byte) i); - else if(i >= Short.MIN_VALUE && i <= Short.MAX_VALUE) - writeInt16((short) i); + assert i >= 0; + // Fun fact: it's never worth writing a length as an int8 + if(i <= Byte.MAX_VALUE) writeUint7((byte) i); + else if(i <= Short.MAX_VALUE) writeInt16((short) i); else writeInt32(i); } -- GitLab