diff --git a/briar-tests/src/org/briarproject/ValidatorTestCase.java b/briar-tests/src/org/briarproject/ValidatorTestCase.java index a340994ed9371986352fb3a72fb845cd0c155422..4e5a3b5e62392abe2cd2333bf73e164c5eb24e57 100644 --- a/briar-tests/src/org/briarproject/ValidatorTestCase.java +++ b/briar-tests/src/org/briarproject/ValidatorTestCase.java @@ -1,13 +1,22 @@ package org.briarproject; +import org.briarproject.api.clients.ClientHelper; +import org.briarproject.api.data.MetadataEncoder; import org.briarproject.api.sync.ClientId; import org.briarproject.api.sync.Group; import org.briarproject.api.sync.GroupId; import org.briarproject.api.sync.Message; import org.briarproject.api.sync.MessageId; +import org.briarproject.api.system.Clock; public abstract class ValidatorTestCase extends BriarMockTestCase { + protected final ClientHelper clientHelper = + context.mock(ClientHelper.class); + protected final MetadataEncoder metadataEncoder = + context.mock(MetadataEncoder.class); + protected final Clock clock = context.mock(Clock.class); + protected final MessageId messageId = new MessageId(TestUtils.getRandomId()); protected final GroupId groupId = new GroupId(TestUtils.getRandomId()); diff --git a/briar-tests/src/org/briarproject/clients/BdfMessageValidatorTest.java b/briar-tests/src/org/briarproject/clients/BdfMessageValidatorTest.java index 8c567e295ec6b21d08c22ab89371214e46e1a3a2..65d856dc00913ac65e352713a7e64eb8e9dcdc67 100644 --- a/briar-tests/src/org/briarproject/clients/BdfMessageValidatorTest.java +++ b/briar-tests/src/org/briarproject/clients/BdfMessageValidatorTest.java @@ -3,16 +3,13 @@ package org.briarproject.clients; import org.briarproject.ValidatorTestCase; import org.briarproject.api.FormatException; import org.briarproject.api.clients.BdfMessageContext; -import org.briarproject.api.clients.ClientHelper; import org.briarproject.api.data.BdfDictionary; import org.briarproject.api.data.BdfList; -import org.briarproject.api.data.MetadataEncoder; import org.briarproject.api.db.Metadata; import org.briarproject.api.sync.Group; import org.briarproject.api.sync.InvalidMessageException; import org.briarproject.api.sync.Message; import org.briarproject.api.sync.MessageContext; -import org.briarproject.api.system.Clock; import org.jmock.Expectations; import org.jmock.lib.legacy.ClassImposteriser; import org.junit.Test; @@ -25,11 +22,6 @@ import static org.junit.Assert.fail; public class BdfMessageValidatorTest extends ValidatorTestCase { - private final ClientHelper clientHelper = context.mock(ClientHelper.class); - private final MetadataEncoder metadataEncoder = - context.mock(MetadataEncoder.class); - private final Clock clock = context.mock(Clock.class); - private final BdfList body = BdfList.of(123, 456); private final BdfDictionary dictionary = new BdfDictionary(); private final Metadata meta = new Metadata(); diff --git a/briar-tests/src/org/briarproject/forum/ForumPostValidatorTest.java b/briar-tests/src/org/briarproject/forum/ForumPostValidatorTest.java index 512b6f3d169cb8c0eccd7f34e54e1473dfda8555..17e5c1266dca74739f381392f5deb9815fa34dfb 100644 --- a/briar-tests/src/org/briarproject/forum/ForumPostValidatorTest.java +++ b/briar-tests/src/org/briarproject/forum/ForumPostValidatorTest.java @@ -5,16 +5,13 @@ import org.briarproject.ValidatorTestCase; import org.briarproject.api.FormatException; import org.briarproject.api.UniqueId; import org.briarproject.api.clients.BdfMessageContext; -import org.briarproject.api.clients.ClientHelper; import org.briarproject.api.data.BdfDictionary; import org.briarproject.api.data.BdfList; -import org.briarproject.api.data.MetadataEncoder; import org.briarproject.api.identity.Author; import org.briarproject.api.identity.AuthorFactory; import org.briarproject.api.identity.AuthorId; import org.briarproject.api.sync.InvalidMessageException; import org.briarproject.api.sync.MessageId; -import org.briarproject.api.system.Clock; import org.jmock.Expectations; import org.junit.Test; @@ -33,10 +30,6 @@ public class ForumPostValidatorTest extends ValidatorTestCase { private final AuthorFactory authorFactory = context.mock(AuthorFactory.class); - private final ClientHelper clientHelper = context.mock(ClientHelper.class); - private final MetadataEncoder metadataEncoder = - context.mock(MetadataEncoder.class); - private final Clock clock = context.mock(Clock.class); private final MessageId parentId = new MessageId(TestUtils.getRandomId()); private final String authorName = diff --git a/briar-tests/src/org/briarproject/messaging/PrivateMessageValidatorTest.java b/briar-tests/src/org/briarproject/messaging/PrivateMessageValidatorTest.java index fd99b31bb4c6c820f10989df9efa25708776364c..3d5fad97a6c95ea9335f8b67ebcaf116fd0104d4 100644 --- a/briar-tests/src/org/briarproject/messaging/PrivateMessageValidatorTest.java +++ b/briar-tests/src/org/briarproject/messaging/PrivateMessageValidatorTest.java @@ -4,11 +4,8 @@ import org.briarproject.TestUtils; import org.briarproject.ValidatorTestCase; import org.briarproject.api.FormatException; import org.briarproject.api.clients.BdfMessageContext; -import org.briarproject.api.clients.ClientHelper; import org.briarproject.api.data.BdfDictionary; import org.briarproject.api.data.BdfList; -import org.briarproject.api.data.MetadataEncoder; -import org.briarproject.api.system.Clock; import org.junit.Test; import static org.briarproject.api.messaging.MessagingConstants.MAX_PRIVATE_MESSAGE_BODY_LENGTH; @@ -18,11 +15,6 @@ import static org.junit.Assert.assertFalse; public class PrivateMessageValidatorTest extends ValidatorTestCase { - private final ClientHelper clientHelper = context.mock(ClientHelper.class); - private final MetadataEncoder metadataEncoder = - context.mock(MetadataEncoder.class); - private final Clock clock = context.mock(Clock.class); - @Test(expected = FormatException.class) public void testRejectsTooShortBody() throws Exception { PrivateMessageValidator v = new PrivateMessageValidator(clientHelper, diff --git a/briar-tests/src/org/briarproject/sharing/ForumSharingValidatorTest.java b/briar-tests/src/org/briarproject/sharing/ForumSharingValidatorTest.java index 099fa26327ff8c97a81cb4c246071ac56aa47b58..7d3c6e22b25012af428b554a5c7018419643e53c 100644 --- a/briar-tests/src/org/briarproject/sharing/ForumSharingValidatorTest.java +++ b/briar-tests/src/org/briarproject/sharing/ForumSharingValidatorTest.java @@ -5,12 +5,9 @@ import org.briarproject.ValidatorTestCase; import org.briarproject.api.FormatException; import org.briarproject.api.UniqueId; import org.briarproject.api.clients.BdfMessageContext; -import org.briarproject.api.clients.ClientHelper; import org.briarproject.api.clients.SessionId; import org.briarproject.api.data.BdfDictionary; import org.briarproject.api.data.BdfList; -import org.briarproject.api.data.MetadataEncoder; -import org.briarproject.api.system.Clock; import org.junit.Test; import javax.annotation.Nullable; @@ -35,11 +32,6 @@ import static org.junit.Assert.assertFalse; public class ForumSharingValidatorTest extends ValidatorTestCase { - private final ClientHelper clientHelper = context.mock(ClientHelper.class); - private final MetadataEncoder metadataEncoder = - context.mock(MetadataEncoder.class); - private final Clock clock = context.mock(Clock.class); - private final SessionId sessionId = new SessionId(TestUtils.getRandomId()); private final String forumName = TestUtils.getRandomString(MAX_FORUM_NAME_LENGTH);