diff --git a/briar-android/src/main/java/org/briarproject/briar/android/login/DozeFragment.java b/briar-android/src/main/java/org/briarproject/briar/android/login/DozeFragment.java index 38376b2a953e7d748cec3c86332b0ed275f4474f..68dc243458121bf857d0780feae8a51142ef091b 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/login/DozeFragment.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/login/DozeFragment.java @@ -40,12 +40,7 @@ public class DozeFragment extends SetupFragment { dozeButton = (Button) v.findViewById(R.id.dozeButton); progressBar = (ProgressBar) v.findViewById(R.id.progress); - dozeButton.setOnClickListener(new View.OnClickListener() { - @Override - public void onClick(View view) { - askForDozeWhitelisting(); - } - }); + dozeButton.setOnClickListener(view -> askForDozeWhitelisting()); return v; } diff --git a/briar-android/src/main/java/org/briarproject/briar/android/login/SetupController.java b/briar-android/src/main/java/org/briarproject/briar/android/login/SetupController.java index 96ea253f87b1837d0a60e070249dae6ce4c93dd5..cf75077fe5ca294902c4aa41f0d4fc78e5b9c166 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/login/SetupController.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/login/SetupController.java @@ -25,6 +25,6 @@ public interface SetupController { void createAccount(); - void createAccount(final ResultHandler<Void> resultHandler); + void createAccount(ResultHandler<Void> resultHandler); } diff --git a/briar-android/src/main/java/org/briarproject/briar/android/login/SetupControllerImpl.java b/briar-android/src/main/java/org/briarproject/briar/android/login/SetupControllerImpl.java index 731cae02a73ae471e3ec7b6f00edfcc8b4954242..4d1f7ee7397ade65adab858d280824b723bd8cec 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/login/SetupControllerImpl.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/login/SetupControllerImpl.java @@ -70,7 +70,7 @@ public class SetupControllerImpl extends PasswordControllerImpl @Override public void createAccount() { - final UiResultHandler<Void> resultHandler = + UiResultHandler<Void> resultHandler = new UiResultHandler<Void>(setupActivity) { @Override public void onResultUi(Void result) { @@ -83,7 +83,7 @@ public class SetupControllerImpl extends PasswordControllerImpl } @Override - public void createAccount(final ResultHandler<Void> resultHandler) { + public void createAccount(ResultHandler<Void> resultHandler) { if (authorName == null || password == null) throw new IllegalStateException(); cryptoExecutor.execute(() -> { diff --git a/briar-android/src/main/java/org/briarproject/briar/android/privategroup/conversation/GroupControllerImpl.java b/briar-android/src/main/java/org/briarproject/briar/android/privategroup/conversation/GroupControllerImpl.java index 911a96da230b60f1743314d2c77ade74a6a36b5b..f1a844cafbbb29f6fc5d53868114f0722c8ba54f 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/privategroup/conversation/GroupControllerImpl.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/privategroup/conversation/GroupControllerImpl.java @@ -230,8 +230,8 @@ class GroupControllerImpl extends } @Override - public void isDissolved(final - ResultExceptionHandler<Boolean, DbException> handler) { + public void isDissolved( + ResultExceptionHandler<Boolean, DbException> handler) { runOnDbThread(() -> { try { boolean isDissolved = diff --git a/briar-android/src/test/java/org/briarproject/briar/android/login/PasswordControllerImplTest.java b/briar-android/src/test/java/org/briarproject/briar/android/login/PasswordControllerImplTest.java index 34ad19fc5a7c97b3036bd1fa5bba89a75b4f83b6..9fee37d7091dbc8192633b20d96c55dc14bfdde4 100644 --- a/briar-android/src/test/java/org/briarproject/briar/android/login/PasswordControllerImplTest.java +++ b/briar-android/src/test/java/org/briarproject/briar/android/login/PasswordControllerImplTest.java @@ -7,7 +7,6 @@ import org.briarproject.bramble.api.crypto.PasswordStrengthEstimator; import org.briarproject.bramble.api.db.DatabaseConfig; import org.briarproject.bramble.test.BrambleMockTestCase; import org.briarproject.bramble.test.ImmediateExecutor; -import org.briarproject.briar.android.controller.handler.ResultHandler; import org.jmock.Expectations; import org.junit.Test; @@ -61,14 +60,8 @@ public class PasswordControllerImplTest extends BrambleMockTestCase { PasswordControllerImpl p = new PasswordControllerImpl(briarPrefs, databaseConfig, cryptoExecutor, crypto, estimator); - final AtomicBoolean capturedResult = new AtomicBoolean(false); - p.changePassword(oldPassword, newPassword, - new ResultHandler<Boolean>() { - @Override - public void onResult(Boolean result) { - capturedResult.set(result); - } - }); + AtomicBoolean capturedResult = new AtomicBoolean(false); + p.changePassword(oldPassword, newPassword, capturedResult::set); assertTrue(capturedResult.get()); } @@ -86,14 +79,8 @@ public class PasswordControllerImplTest extends BrambleMockTestCase { PasswordControllerImpl p = new PasswordControllerImpl(briarPrefs, databaseConfig, cryptoExecutor, crypto, estimator); - final AtomicBoolean capturedResult = new AtomicBoolean(true); - p.changePassword(oldPassword, newPassword, - new ResultHandler<Boolean>() { - @Override - public void onResult(Boolean result) { - capturedResult.set(result); - } - }); + AtomicBoolean capturedResult = new AtomicBoolean(true); + p.changePassword(oldPassword, newPassword, capturedResult::set); assertFalse(capturedResult.get()); } } diff --git a/briar-android/src/test/java/org/briarproject/briar/android/login/SetupControllerImplTest.java b/briar-android/src/test/java/org/briarproject/briar/android/login/SetupControllerImplTest.java index f181e2881439e44f55bc56436b201ab579447853..9dbfd17afdaba19a4621a117449112edcd57e475 100644 --- a/briar-android/src/test/java/org/briarproject/briar/android/login/SetupControllerImplTest.java +++ b/briar-android/src/test/java/org/briarproject/briar/android/login/SetupControllerImplTest.java @@ -8,7 +8,6 @@ import org.briarproject.bramble.api.crypto.SecretKey; import org.briarproject.bramble.api.db.DatabaseConfig; import org.briarproject.bramble.test.BrambleMockTestCase; import org.briarproject.bramble.test.ImmediateExecutor; -import org.briarproject.briar.android.controller.handler.ResultHandler; import org.jmock.Expectations; import org.jmock.lib.legacy.ClassImposteriser; import org.junit.Test; @@ -72,15 +71,10 @@ public class SetupControllerImplTest extends BrambleMockTestCase { databaseConfig, cryptoExecutor, crypto, estimator); s.setSetupActivity(setupActivity); - final AtomicBoolean called = new AtomicBoolean(false); + AtomicBoolean called = new AtomicBoolean(false); s.setAuthorName(authorName); s.setPassword(password); - s.createAccount(new ResultHandler<Void>() { - @Override - public void onResult(Void result) { - called.set(true); - } - }); + s.createAccount(result -> called.set(true)); assertTrue(called.get()); } }