From ecf417c93bc62b2e6a54a3feeda516257de4f48d Mon Sep 17 00:00:00 2001 From: Torsten Grote <t@grobox.de> Date: Wed, 31 Oct 2018 12:26:32 -0300 Subject: [PATCH] [android] Show contact alias in remaining places --- .../android/introduction/IntroductionMessageFragment.java | 5 +++-- .../privategroup/invitation/GroupInvitationViewHolder.java | 4 +++- .../privategroup/reveal/RevealableContactViewHolder.java | 3 ++- .../briar/android/sharing/SharingInvitationViewHolder.java | 4 +++- 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/briar-android/src/main/java/org/briarproject/briar/android/introduction/IntroductionMessageFragment.java b/briar-android/src/main/java/org/briarproject/briar/android/introduction/IntroductionMessageFragment.java index 194641f075..ea7858e487 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/introduction/IntroductionMessageFragment.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/introduction/IntroductionMessageFragment.java @@ -38,6 +38,7 @@ import static android.view.View.VISIBLE; import static android.widget.Toast.LENGTH_SHORT; import static java.util.logging.Level.WARNING; import static org.briarproject.bramble.util.LogUtils.logException; +import static org.briarproject.briar.android.util.UiUtils.getContactDisplayName; import static org.briarproject.briar.api.introduction.IntroductionConstants.MAX_INTRODUCTION_TEXT_LENGTH; public class IntroductionMessageFragment extends BaseFragment @@ -148,8 +149,8 @@ public class IntroductionMessageFragment extends BaseFragment c2.getAuthor().getId().getBytes())); // set contact names - ui.contactName1.setText(c1.getAuthor().getName()); - ui.contactName2.setText(c2.getAuthor().getName()); + ui.contactName1.setText(getContactDisplayName(c1)); + ui.contactName2.setText(getContactDisplayName(c2)); // hide progress bar ui.progressBar.setVisibility(GONE); diff --git a/briar-android/src/main/java/org/briarproject/briar/android/privategroup/invitation/GroupInvitationViewHolder.java b/briar-android/src/main/java/org/briarproject/briar/android/privategroup/invitation/GroupInvitationViewHolder.java index fae57b85e4..b205e2409e 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/privategroup/invitation/GroupInvitationViewHolder.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/privategroup/invitation/GroupInvitationViewHolder.java @@ -9,6 +9,8 @@ import org.briarproject.briar.api.privategroup.invitation.GroupInvitationItem; import javax.annotation.Nullable; +import static org.briarproject.briar.android.util.UiUtils.getContactDisplayName; + class GroupInvitationViewHolder extends InvitationViewHolder<GroupInvitationItem> { @@ -24,7 +26,7 @@ class GroupInvitationViewHolder sharedBy.setText( sharedBy.getContext().getString(R.string.groups_created_by, - item.getCreator().getAuthor().getName())); + getContactDisplayName(item.getCreator()))); } } \ No newline at end of file diff --git a/briar-android/src/main/java/org/briarproject/briar/android/privategroup/reveal/RevealableContactViewHolder.java b/briar-android/src/main/java/org/briarproject/briar/android/privategroup/reveal/RevealableContactViewHolder.java index ab7777f4bd..f32c34522d 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/privategroup/reveal/RevealableContactViewHolder.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/privategroup/reveal/RevealableContactViewHolder.java @@ -14,6 +14,7 @@ import javax.annotation.Nullable; import static org.briarproject.briar.android.privategroup.VisibilityHelper.getVisibilityIcon; import static org.briarproject.briar.android.privategroup.VisibilityHelper.getVisibilityString; import static org.briarproject.briar.android.util.UiUtils.GREY_OUT; +import static org.briarproject.briar.android.util.UiUtils.getContactDisplayName; @UiThread @NotNullByDefault @@ -36,7 +37,7 @@ class RevealableContactViewHolder icon.setImageResource(getVisibilityIcon(item.getVisibility())); info.setText( getVisibilityString(info.getContext(), item.getVisibility(), - item.getContact().getAuthor().getName())); + getContactDisplayName(item.getContact()))); } @Override diff --git a/briar-android/src/main/java/org/briarproject/briar/android/sharing/SharingInvitationViewHolder.java b/briar-android/src/main/java/org/briarproject/briar/android/sharing/SharingInvitationViewHolder.java index 6d4eae9292..9b65e1c8c9 100644 --- a/briar-android/src/main/java/org/briarproject/briar/android/sharing/SharingInvitationViewHolder.java +++ b/briar-android/src/main/java/org/briarproject/briar/android/sharing/SharingInvitationViewHolder.java @@ -13,6 +13,8 @@ import java.util.Collection; import javax.annotation.Nullable; +import static org.briarproject.briar.android.util.UiUtils.getContactDisplayName; + class SharingInvitationViewHolder extends InvitationViewHolder<SharingInvitationItem> { @@ -28,7 +30,7 @@ class SharingInvitationViewHolder Collection<String> names = new ArrayList<>(); for (Contact c : item.getNewSharers()) - names.add(c.getAuthor().getName()); + names.add(getContactDisplayName(c)); sharedBy.setText( sharedBy.getContext().getString(R.string.shared_by_format, StringUtils.join(names, ", "))); -- GitLab