From f9d5873385d74606158c24c29ddfb3d7fd7f8add Mon Sep 17 00:00:00 2001 From: akwizgran <michael@briarproject.org> Date: Thu, 2 Aug 2018 15:51:28 +0100 Subject: [PATCH] Fix Tor bridge test. --- .../bramble/plugin/tor/BridgeTest.java | 13 +++++++----- .../bramble/test/ApplicationModule.java | 20 +++++++++++++++++++ ...ambleAndroidIntegrationTestComponent.java} | 7 +++++-- 3 files changed, 33 insertions(+), 7 deletions(-) create mode 100644 bramble-android/src/androidTest/java/org/briarproject/bramble/test/ApplicationModule.java rename bramble-android/src/androidTest/java/org/briarproject/bramble/{IntegrationTestComponent.java => test/BrambleAndroidIntegrationTestComponent.java} (69%) diff --git a/bramble-android/src/androidTest/java/org/briarproject/bramble/plugin/tor/BridgeTest.java b/bramble-android/src/androidTest/java/org/briarproject/bramble/plugin/tor/BridgeTest.java index 0cb2d4232e..53fdc4a186 100644 --- a/bramble-android/src/androidTest/java/org/briarproject/bramble/plugin/tor/BridgeTest.java +++ b/bramble-android/src/androidTest/java/org/briarproject/bramble/plugin/tor/BridgeTest.java @@ -3,14 +3,15 @@ package org.briarproject.bramble.plugin.tor; import android.content.Context; import android.support.test.runner.AndroidJUnit4; -import org.briarproject.bramble.DaggerIntegrationTestComponent; -import org.briarproject.bramble.IntegrationTestComponent; import org.briarproject.bramble.api.event.EventBus; +import org.briarproject.bramble.api.network.NetworkManager; import org.briarproject.bramble.api.plugin.BackoffFactory; import org.briarproject.bramble.api.plugin.duplex.DuplexPlugin; import org.briarproject.bramble.api.system.Clock; import org.briarproject.bramble.api.system.LocationUtils; +import org.briarproject.bramble.test.BrambleAndroidIntegrationTestComponent; import org.briarproject.bramble.test.BrambleTestCase; +import org.briarproject.bramble.test.DaggerBrambleAndroidIntegrationTestComponent; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -41,6 +42,8 @@ public class BridgeTest extends BrambleTestCase { private final static Logger LOG = Logger.getLogger(BridgeTest.class.getSimpleName()); + @Inject + NetworkManager networkManager; @Inject EventBus eventBus; @Inject @@ -77,8 +80,8 @@ public class BridgeTest extends BrambleTestCase { @Before public void setUp() { - IntegrationTestComponent component = - DaggerIntegrationTestComponent.builder().build(); + BrambleAndroidIntegrationTestComponent component = + DaggerBrambleAndroidIntegrationTestComponent.builder().build(); component.inject(this); Executor ioExecutor = Executors.newCachedThreadPool(); @@ -87,7 +90,7 @@ public class BridgeTest extends BrambleTestCase { SocketFactory torSocketFactory = SocketFactory.getDefault(); factory = new TorPluginFactory(ioExecutor, scheduler, appContext, - locationUtils, eventBus, torSocketFactory, + networkManager, locationUtils, eventBus, torSocketFactory, backoffFactory, circumventionProvider, clock); } diff --git a/bramble-android/src/androidTest/java/org/briarproject/bramble/test/ApplicationModule.java b/bramble-android/src/androidTest/java/org/briarproject/bramble/test/ApplicationModule.java new file mode 100644 index 0000000000..f67f32edbf --- /dev/null +++ b/bramble-android/src/androidTest/java/org/briarproject/bramble/test/ApplicationModule.java @@ -0,0 +1,20 @@ +package org.briarproject.bramble.test; + +import android.app.Application; +import android.support.test.InstrumentationRegistry; + +import javax.inject.Singleton; + +import dagger.Module; +import dagger.Provides; + +@Module +class ApplicationModule { + + @Provides + @Singleton + Application provideApplication() { + return (Application) InstrumentationRegistry.getTargetContext() + .getApplicationContext(); + } +} diff --git a/bramble-android/src/androidTest/java/org/briarproject/bramble/IntegrationTestComponent.java b/bramble-android/src/androidTest/java/org/briarproject/bramble/test/BrambleAndroidIntegrationTestComponent.java similarity index 69% rename from bramble-android/src/androidTest/java/org/briarproject/bramble/IntegrationTestComponent.java rename to bramble-android/src/androidTest/java/org/briarproject/bramble/test/BrambleAndroidIntegrationTestComponent.java index bb5875ac33..2c7f7b9712 100644 --- a/bramble-android/src/androidTest/java/org/briarproject/bramble/IntegrationTestComponent.java +++ b/bramble-android/src/androidTest/java/org/briarproject/bramble/test/BrambleAndroidIntegrationTestComponent.java @@ -1,5 +1,6 @@ -package org.briarproject.bramble; +package org.briarproject.bramble.test; +import org.briarproject.bramble.BrambleAndroidModule; import org.briarproject.bramble.event.EventModule; import org.briarproject.bramble.plugin.PluginModule; import org.briarproject.bramble.plugin.tor.BridgeTest; @@ -12,11 +13,13 @@ import dagger.Component; @Singleton @Component(modules = { BrambleAndroidModule.class, + TestLifecycleModule.class, + ApplicationModule.class, PluginModule.class, // needed for BackoffFactory EventModule.class, SystemModule.class, }) -public interface IntegrationTestComponent { +public interface BrambleAndroidIntegrationTestComponent { void inject(BridgeTest init); -- GitLab