briar issueshttps://code.briarproject.org/groups/briar/-/issues2022-01-21T11:47:11Zhttps://code.briarproject.org/briar/briar-desktop/-/issues/251CI-builds have <unknown> branch in BuildData2022-01-21T11:47:11ZSebastianCI-builds have <unknown> branch in BuildDataSee this:
![Screenshot_from_2022-01-21_07-51-42](/uploads/c4f2ac678e007fdf948514433781edc4/Screenshot_from_2022-01-21_07-51-42.png)
Changing the CI settings the way it clones didn't help to change this.
Apparently after cloning, the ...See this:
![Screenshot_from_2022-01-21_07-51-42](/uploads/c4f2ac678e007fdf948514433781edc4/Screenshot_from_2022-01-21_07-51-42.png)
Changing the CI settings the way it clones didn't help to change this.
Apparently after cloning, the CI does something like `git checkout abcdef12345` and therefore is in detached state.
Possible solution: https://stackoverflow.com/a/69268083/1268759Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/241Wrong string format according to Transifex2022-01-19T17:16:24ZMikolai GütschowWrong string format according to TransifexWe've just got this mail from Transifex:
> A resource could not be auto-updated
>
> Transifex was unable to auto update the file Briar Desktop. Fetching from the following URL failed https://code.briarproject.org/briar/briar-desktop/-/...We've just got this mail from Transifex:
> A resource could not be auto-updated
>
> Transifex was unable to auto update the file Briar Desktop. Fetching from the following URL failed https://code.briarproject.org/briar/briar-desktop/-/raw/main/src/main/resources/strings/BriarDesktop.properties. The error message from the server was:
>
> Invalid plural types for string: expiration.banner.part1. Language supports: ['one', 'other'], but found: ['zero', 'one', 'other'] instead.
>
> Please make sure the URL provided for the file is accessible, or update the link to the file.
> If you plan to stop auto-update for this file, please disregard this message.
That's a regression from the expiration banner MR since I used the message format to also have a special version for "today" (daysLeft = zero). I didn't know it was not possible to use this form in English. I guess the fix would be to manually check for today (tomorrow?) in the code and have two different strings then?Desktop 0.1.0NicoNicohttps://code.briarproject.org/briar/briar-desktop/-/issues/225Version numbering in deb inconsistent with our versioning scheme2022-01-19T19:28:55ZSebastianVersion numbering in deb inconsistent with our versioning schemeI think according to our current versioning scheme we're working on version `0.1.0`.
When installing the deb package, it prints:
```
Unpacking briar-desktop (0.0.1-1) over (0.0.1-1) ...
Setting up briar-desktop (0.0.1-1) ...
```
which l...I think according to our current versioning scheme we're working on version `0.1.0`.
When installing the deb package, it prints:
```
Unpacking briar-desktop (0.0.1-1) over (0.0.1-1) ...
Setting up briar-desktop (0.0.1-1) ...
```
which looks like it has somehow a different version number set.Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/220NPE when viewing introduction request with null text2022-01-18T16:11:33ZSebastianNPE when viewing introduction request with null text```
Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
at org.briarproject.briar.desktop.conversation.ConversationRequestItemViewKt$ConversationRequestItemView$4.invoke(ConversationRequestItemView.kt:85)
at org...```
Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
at org.briarproject.briar.desktop.conversation.ConversationRequestItemViewKt$ConversationRequestItemView$4.invoke(ConversationRequestItemView.kt:85)
at org.briarproject.briar.desktop.conversation.ConversationRequestItemViewKt$ConversationRequestItemView$4.invoke(ConversationRequestItemView.kt:82)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:107)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)
at org.briarproject.briar.desktop.conversation.ConversationItemViewKt$ConversationItemView$2$1$2$1.invoke(ConversationItemView.kt:181)
at org.briarproject.briar.desktop.conversation.ConversationItemViewKt$ConversationItemView$2$1$2$1.invoke(ConversationItemView.kt:180)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:107)
```Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/218Contact Search Field Bug2022-01-18T15:26:32ZpaulContact Search Field BugCurrently on the main branch, when your search string causes the filtered contact list to return no contacts (i.e. search Fred and have no contacts whos names match that string) the screen switches to the newly added screen for a user wi...Currently on the main branch, when your search string causes the filtered contact list to return no contacts (i.e. search Fred and have no contacts whos names match that string) the screen switches to the newly added screen for a user with no contacts.
The attached gif is me typing an 'a' and then an 'f'.![briar_searchbar_bug](/uploads/8f93826d5b0f4c1c70130c62c095ca9b/briar_searchbar_bug.gif)Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/216Strip leading/trailing whitespace from messages2022-01-18T15:38:58ZNicoStrip leading/trailing whitespace from messagesBriar Android seems to strip whitespace from messages, even if the actual messages contains whitespace. To reproduce:
* send a message from Briar Desktop with trailing whitespace/newlines
* see how the whitespace gets stripped in Briar A...Briar Android seems to strip whitespace from messages, even if the actual messages contains whitespace. To reproduce:
* send a message from Briar Desktop with trailing whitespace/newlines
* see how the whitespace gets stripped in Briar Android, it's not visible in the received message
* see how the whitespace is displayed in Briar Desktop
When sending trailing whitespace from Briar Android, it seems to strip that, because the received message on Briar Desktop no more contains the whitespace.Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/214It's possible to add one's own briar:// links when appending one or multiple ...2022-01-18T16:18:52ZSebastianIt's possible to add one's own briar:// links when appending one or multiple charsWhen checking wheter the user-provided link is our own link, we use the whole string and compare that to our own link while we really should only compare the valid part found by `HandshakeLinkConstants.LINK_REGEX.matcher(link).find()`When checking wheter the user-provided link is our own link, we use the whole string and compare that to our own link while we really should only compare the valid part found by `HandshakeLinkConstants.LINK_REGEX.matcher(link).find()`Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/199Show different placeholder screen if pending contact is selected2022-01-12T11:32:46ZMikolai GütschowShow different placeholder screen if pending contact is selectedCurrently, it looks like the following. It would be best to display some information about what it means for a contact to be pending.
![image](/uploads/451a4a64648af2face680c6ef6330253/image.png)Currently, it looks like the following. It would be best to display some information about what it means for a contact to be pending.
![image](/uploads/451a4a64648af2face680c6ef6330253/image.png)Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/197Display avatars in contact intro drawer, if available2022-01-12T10:58:39ZSebastianDisplay avatars in contact intro drawer, if availableDesktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/195Provide build data to app at runtime2022-01-09T17:31:22ZSebastianProvide build data to app at runtimeLet's generate a class using Gradle that provides some data about the build:
* time of the build (for the #183)
* version of the app (for #194)
* git hash app was built from (for #194)Let's generate a class using Gradle that provides some data about the build:
* time of the build (for the #183)
* version of the app (for #194)
* git hash app was built from (for #194)Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/194Add About/Credits dialog2022-01-19T16:11:03ZSebastianAdd About/Credits dialogCould show:
* Copyright
* Authors
* License
* Thanks notices
* Libraries used and their licenses
* Donation addresses Bitcoin/Ether etc
* Version number
* Git hash app was built fromCould show:
* Copyright
* Authors
* License
* Thanks notices
* Libraries used and their licenses
* Donation addresses Bitcoin/Ether etc
* Version number
* Git hash app was built fromDesktop 0.1.0https://code.briarproject.org/briar/briar-desktop/-/issues/193Remove conversation menu items that do not work yet2022-01-12T11:36:06ZSebastianRemove conversation menu items that do not work yet* self-destructing messages
* Connections submenu
* rename contact (unless we move #158 into the 0.1.0 milestone)* self-destructing messages
* Connections submenu
* rename contact (unless we move #158 into the 0.1.0 milestone)Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/189Improve main screen when having no chat open2022-01-09T16:38:14ZNicoImprove main screen when having no chat openRelated to https://code.briarproject.org/briar/briar-desktop/-/issues/83, could be done like in Briar GTK:
![Screenshot_from_2021-10-05_17-05-14](/uploads/47a4fe4c9e94ce490c5eea35375868c1/Screenshot_from_2021-10-05_17-05-14.png)Related to https://code.briarproject.org/briar/briar-desktop/-/issues/83, could be done like in Briar GTK:
![Screenshot_from_2021-10-05_17-05-14](/uploads/47a4fe4c9e94ce490c5eea35375868c1/Screenshot_from_2021-10-05_17-05-14.png)Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/187Kick out logout button for now2022-01-07T23:53:51ZNicoKick out logout button for nowThe logout button currently does nothing. While we could do the same as when closing windows, in the most recent meeting we decided to don't do that for now and instead keep the logout button as a visual indication for the upcoming featu...The logout button currently does nothing. While we could do the same as when closing windows, in the most recent meeting we decided to don't do that for now and instead keep the logout button as a visual indication for the upcoming feature https://code.briarproject.org/briar/briar-desktop/-/issues/186.
So once we implement https://code.briarproject.org/briar/briar-desktop/-/issues/186, we show the users that there is a separate logout button now. When clicking that logout button or the window exit button, it will then shortly explain that these are different features: the logout button kills the Briar process while the window exit button really only minimizes the window but keeps the process running.Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/183Add warning message with 90-day countdown before Alpha/Beta releases expire2022-02-22T08:42:11ZMikolai GütschowAdd warning message with 90-day countdown before Alpha/Beta releases expire- the days should start counting from the date of the build
- after max 90 days, it should not be possible to log in to Briar Desktop anymore to nudge users to update- the days should start counting from the date of the build
- after max 90 days, it should not be possible to log in to Briar Desktop anymore to nudge users to updateDesktop 0.1.0Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/briar-desktop/-/issues/182Profile pictures don't yet update when contact changes it2022-01-07T21:45:26ZSebastianProfile pictures don't yet update when contact changes itIt might have to do with the `FeatureFlags` still not having profile pictures enabled:
```
@Provides
internal fun provideFeatureFlags() = object : FeatureFlags {
override fun shouldEnableImageAttachments() = false
...It might have to do with the `FeatureFlags` still not having profile pictures enabled:
```
@Provides
internal fun provideFeatureFlags() = object : FeatureFlags {
override fun shouldEnableImageAttachments() = false
override fun shouldEnableProfilePictures() = false
override fun shouldEnableDisappearingMessages() = false
}
```
but even if I enable it, I need to restart briar desktop to receive an updated profile picture.Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/178Create Ubuntu-compatible deb packages2022-01-20T13:39:10ZSebastianCreate Ubuntu-compatible deb packagesCurrently, our nightly build deb packages work on debian, but not on Ubuntu, see:
https://code.briarproject.org/briar/briar-desktop/-/merge_requests/44#note_58849
Would be nice to have nightly-built packages for this as Ubuntu and some ...Currently, our nightly build deb packages work on debian, but not on Ubuntu, see:
https://code.briarproject.org/briar/briar-desktop/-/merge_requests/44#note_58849
Would be nice to have nightly-built packages for this as Ubuntu and some of its derivatives such as Mint are very popular distros.Desktop 0.1.0NicoNicohttps://code.briarproject.org/briar/briar-desktop/-/issues/173Introduction with empty message raises exception2022-01-18T13:36:35ZSebastianIntroduction with empty message raises exceptionwhen making an introduction and leaving the introduction message blank I get this exception:
```
java.lang.IllegalArgumentException: null
at org.briarproject.briar.introduction.MessageEncoderImpl.encodeRequestMessage(MessageEncoderImpl...when making an introduction and leaving the introduction message blank I get this exception:
```
java.lang.IllegalArgumentException: null
at org.briarproject.briar.introduction.MessageEncoderImpl.encodeRequestMessage(MessageEncoderImpl.java:114)
at org.briarproject.briar.introduction.AbstractProtocolEngine.sendRequestMessage(AbstractProtocolEngine.java:115)
at org.briarproject.briar.introduction.IntroducerProtocolEngine.onLocalRequest(IntroducerProtocolEngine.java:230)
at org.briarproject.briar.introduction.IntroducerProtocolEngine.onRequestAction(IntroducerProtocolEngine.java:76)
at org.briarproject.briar.introduction.IntroductionManagerImpl.makeIntroduction(IntroductionManagerImpl.java:363)
at org.briarproject.briar.desktop.introduction.IntroductionViewModel$makeIntroduction$1.invoke(IntroductionViewModel.kt:77)
at org.briarproject.briar.desktop.introduction.IntroductionViewModel$makeIntroduction$1.invoke(IntroductionViewModel.kt:74)
at org.briarproject.briar.desktop.viewmodel.DbViewModel$runOnDbThread$1.invoke(DbViewModel.kt:29)
at org.briarproject.briar.desktop.viewmodel.DbViewModel$runOnDbThread$1.invoke(DbViewModel.kt:26)
at org.briarproject.briar.desktop.threading.BriarExecutorsImpl.onDbThread$lambda-0(BriarExecutorsImpl.kt:15)
at org.briarproject.bramble.TimeLoggingExecutor.lambda$execute$0(TimeLoggingExecutor.java:35)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
at java.base/java.lang.Thread.run(Thread.java:832)
```
where I read:
```java
@Override
public Message encodeRequestMessage(GroupId contactGroupId, long timestamp,
@Nullable MessageId previousMessageId, Author author,
@Nullable String text) {
if (text != null && text.isEmpty()) {
throw new IllegalArgumentException();
}
BdfList body = BdfList.of(
REQUEST.getValue(),
previousMessageId,
clientHelper.toList(author),
text
);
return createMessage(contactGroupId, timestamp, body);
}
```
We copied from Android that the message is optional, and I just confirmed it is optional there, however, I don't know how. Maybe we replace a `null` message with an empty string there.Desktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/172Add test instructions to the HACKING guide2022-01-06T17:04:06ZSebastianAdd test instructions to the HACKING guideDesktop 0.1.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/168Prepare website for release2022-01-21T13:10:43ZSebastianPrepare website for releaseDepends on #167Depends on #167Desktop 0.1.0SebastianSebastian