briar issueshttps://code.briarproject.org/groups/briar/-/issues2023-05-31T16:58:06Zhttps://code.briarproject.org/briar/briar/-/issues/2434IllegalArgumentException when pairing mailbox2023-05-31T16:58:06ZakwizgranIllegalArgumentException when pairing mailbox* Android version: 11
* Phone model: Xiaomi Redmi Not 6 Pro (lineage_twolip)
* Briar version: 1.5.3 (1f1a97f)
Stacktrace:
```
java.lang.IllegalArgumentException: Invalid URL host: \"[scrubbed].onion\"
at okhttp3.HttpUrl$Builder....* Android version: 11
* Phone model: Xiaomi Redmi Not 6 Pro (lineage_twolip)
* Briar version: 1.5.3 (1f1a97f)
Stacktrace:
```
java.lang.IllegalArgumentException: Invalid URL host: \"[scrubbed].onion\"
at okhttp3.HttpUrl$Builder.parse$okhttp(HttpUrl.kt:1338)
at okhttp3.HttpUrl$Companion.get(HttpUrl.kt:1634)
at okhttp3.Request$Builder.url(Request.kt:184)
at org.briarproject.bramble.mailbox.MailboxApiImpl.setup(MailboxApiImpl.java:85)
at org.briarproject.bramble.mailbox.MailboxPairingTaskImpl.pairMailbox(MailboxPairingTaskImpl.java:140)
at org.briarproject.bramble.mailbox.MailboxPairingTaskImpl.run(MailboxPairingTaskImpl.java:125)
at org.briarproject.bramble.mailbox.MailboxManagerImpl.lambda$startPairingTask$0(MailboxManagerImpl.java:97)
at org.briarproject.bramble.mailbox.MailboxManagerImpl.$r8$lambda$OqqL4NbxBrCG5gMD-GnzDqowbVk(Unknown Source:0)
at org.briarproject.bramble.mailbox.MailboxManagerImpl$$ExternalSyntheticLambda0.run(Unknown Source:4)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.lang.Thread.run(Thread.java:923)
```
I've scrubbed the hostname for privacy, but it was 56 valid-looking chars.
Last lines of log:
```
05-26 22:34:31.304 I/CameraView: Starting preview
05-26 22:34:33.480 I/MailboxViewModel: Got result from decoder
05-26 22:34:33.482 I/MailboxPairingTaskImpl: QR code is valid
05-26 22:34:33.482 I/MailboxViewModel: New pairing state: QrCodeReceived
05-26 22:34:33.484 I/CameraView: Stopping preview
```Mailbox: Releasehttps://code.briarproject.org/briar/briar-mailbox/-/issues/193Handle unchecking all bridges2023-05-17T11:34:12ZTorsten GroteHandle unchecking all bridgeshttps://code.briarproject.org/briar/briar-mailbox/-/merge_requests/169#note_76780https://code.briarproject.org/briar/briar-mailbox/-/merge_requests/169#note_76780Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar-mailbox/-/issues/189BindException when debug and release versions are running at the same time2023-03-07T12:55:40ZakwizgranBindException when debug and release versions are running at the same time```
2023-02-14 13:46:49.069 13109-13109 o.b.m.a.StatusManager org.briarproject.mailbox.debug I [main] state: StartedSettingUp
2023-02-14 13:46:49.166 13109-13191 o.b.m.c.t....tTorPlugin org.briarproject.mailbox.debug I [T...```
2023-02-14 13:46:49.069 13109-13109 o.b.m.a.StatusManager org.briarproject.mailbox.debug I [main] state: StartedSettingUp
2023-02-14 13:46:49.166 13109-13191 o.b.m.c.t....tTorPlugin org.briarproject.mailbox.debug I [Thread-6] V3 descriptor uploaded
2023-02-14 13:46:49.210 13109-13191 o.b.m.c.t....tTorPlugin org.briarproject.mailbox.debug I [Thread-6] V3 descriptor uploaded
2023-02-14 13:46:49.309 13109-13191 o.b.m.c.t....tTorPlugin org.briarproject.mailbox.debug I [Thread-6] V3 descriptor uploaded
2023-02-14 13:46:49.459 13109-13191 o.b.m.c.t....tTorPlugin org.briarproject.mailbox.debug I [Thread-6] V3 descriptor uploaded
2023-02-14 13:46:50.103 13109-13191 o.b.m.c.t....tTorPlugin org.briarproject.mailbox.debug I [Thread-6] V3 descriptor uploaded
2023-02-14 13:46:50.103 13109-13191 o.b.m.c.t....tTorPlugin org.briarproject.mailbox.debug I [Thread-6] V3 descriptor uploaded
2023-02-14 13:46:50.211 13109-13191 o.b.m.c.t....tTorPlugin org.briarproject.mailbox.debug I [Thread-6] V3 descriptor uploaded
2023-02-14 13:46:51.757 13109-13191 o.b.m.c.t....tTorPlugin org.briarproject.mailbox.debug I [Thread-6] V3 descriptor uploaded
2023-02-14 13:46:53.896 13109-13191 o.b.m.c.t....tTorPlugin org.briarproject.mailbox.debug I [Thread-6] V3 descriptor uploaded
2023-02-14 13:46:55.160 13109-13191 o.b.m.c.t....tTorPlugin org.briarproject.mailbox.debug I [Thread-6] V3 descriptor uploaded
2023-02-14 13:46:56.460 13109-13191 o.b.m.c.t....tTorPlugin org.briarproject.mailbox.debug I [Thread-6] V3 descriptor uploaded
2023-02-14 13:46:57.786 13109-13191 o.b.m.c.t....tTorPlugin org.briarproject.mailbox.debug I [Thread-6] V3 descriptor uploaded
2023-02-14 13:47:00.449 13109-13191 o.b.m.c.t....tTorPlugin org.briarproject.mailbox.debug I [Thread-6] V3 descriptor uploaded
2023-02-14 13:47:30.228 13109-13176 o.b.m.c.s....leWakeLock org.briarproject.mailbox.debug I [pool-1-thread-1] Renewing wake lock org.briarproject.mailbox.debug
2023-02-14 13:47:30.229 13109-13176 o.b.m.c.s....leWakeLock org.briarproject.mailbox.debug V [pool-1-thread-1] Wake lock org.briarproject.mailbox.debug has 2 holders
2023-02-14 13:48:30.242 13109-13176 o.b.m.c.s....leWakeLock org.briarproject.mailbox.debug I [pool-1-thread-1] Renewing wake lock org.briarproject.mailbox.debug
2023-02-14 13:48:30.243 13109-13176 o.b.m.c.s....leWakeLock org.briarproject.mailbox.debug V [pool-1-thread-1] Wake lock org.briarproject.mailbox.debug has 2 holders
2023-02-14 13:49:23.338 14060-14108 AndroidRuntime pid-14060 E FATAL EXCEPTION: AndroidExecutor
Process: org.briarproject.mailbox, PID: 14060
java.net.BindException: Address already in use
at sun.nio.ch.Net.bind0(Native Method)
at sun.nio.ch.Net.bind(Net.java:454)
at sun.nio.ch.Net.bind(Net.java:446)
at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:214)
at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
at io.netty.channel.socket.nio.NioServerSocketChannel.doBind(NioServerSocketChannel.java:32)
at io.netty.channel.AbstractChannel$AbstractUnsafe.bind(AbstractChannel.java:114)
at io.netty.channel.DefaultChannelPipeline$HeadContext.bind(DefaultChannelPipeline.java:3)
at io.netty.channel.AbstractChannelHandlerContext.bind(AbstractChannelHandlerContext.java:40)
at io.netty.channel.AbstractChannel.bind(AbstractChannel.java:5)
at io.netty.bootstrap.AbstractBootstrap$2.run(AbstractBootstrap.java:15)
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:17)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:204)
at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:35)
at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:11)
at io.ktor.server.netty.EventLoopGroupProxy$Companion$$ExternalSyntheticLambda1.run(R8$$SyntheticClass:20)
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:3)
at java.lang.Thread.run(Thread.java:761)
2023-02-14 13:49:23.342 1274-3841 ActivityManager pid-1274 E App crashed! Process: org.briarproject.mailbox
at java.lang.Thread.run(Thread.java:761)
```
It looks like this is thrown after the hidden service has been published, so it's not the Tor port that's causing the conflict.Mailbox: ReleaseTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/public-mesh-research/-/issues/22Write report2023-09-12T12:22:53ZSebastianWrite reporthttps://code.briarproject.org/briar/briar-mailbox/-/issues/187Add cancel button in STARTING state2023-03-13T14:23:03ZTorsten GroteAdd cancel button in STARTING stateTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar-mailbox/-/issues/186Add support for Snowflake2023-03-29T13:41:38ZakwizgranAdd support for SnowflakeTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar-mailbox/-/issues/185Add Gradle task for verifying translations2023-04-20T09:36:48ZakwizgranAdd Gradle task for verifying translationsAdd a Gradle task for verifying the translations, similar to the one we have for Briar.Add a Gradle task for verifying the translations, similar to the one we have for Briar.Mailbox: ReleaseTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar-mailbox/-/issues/184Add Mailbox strings to Transifex2023-02-07T13:24:02ZakwizgranAdd Mailbox strings to TransifexMailbox: ReleaseTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar-mailbox/-/issues/183ContactsManagerIntegrationTest is flaky2023-04-20T09:39:50ZSebastianContactsManagerIntegrationTest is flakySometimes, these checks fail on the CI:
* `ContactsManagerIntegrationTest > get contacts is initially empty() FAILED`
* `ContactsManagerIntegrationTest > owner can add contacts() FAILED`
Usually, a restart of the pipeline has fixed this...Sometimes, these checks fail on the CI:
* `ContactsManagerIntegrationTest > get contacts is initially empty() FAILED`
* `ContactsManagerIntegrationTest > owner can add contacts() FAILED`
Usually, a restart of the pipeline has fixed this.
Examples:
* https://code.briarproject.org/briar/briar-mailbox/-/jobs/25250
* https://code.briarproject.org/briar/briar-mailbox/-/jobs/24937
* https://code.briarproject.org/briar/briar-mailbox/-/jobs/25241
I have not been able to reproduce this locally yet.Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar-mailbox/-/issues/182No logs on Android since minification is enabled2023-01-27T11:40:24ZSebastianNo logs on Android since minification is enabledMailbox: ReleaseSebastianSebastianhttps://code.briarproject.org/briar/public-mesh-research/-/issues/21Initial investigations: Bluetooth Mesh2022-12-16T13:08:29ZakwizgranInitial investigations: Bluetooth MeshInvestigate whether the Bluetooth Mesh standard could be useful.
https://www.bluetooth.com/wp-content/uploads/2019/03/Mesh-Technology-Overview.pdf
https://www.bluetooth.com/bluetooth-resources/controlling-bluetooth-mesh-networks-with-a...Investigate whether the Bluetooth Mesh standard could be useful.
https://www.bluetooth.com/wp-content/uploads/2019/03/Mesh-Technology-Overview.pdf
https://www.bluetooth.com/bluetooth-resources/controlling-bluetooth-mesh-networks-with-android-applications/Public mesh researchhttps://code.briarproject.org/briar/briar-mailbox/-/issues/180Outline button style2022-12-16T17:22:01ZSebastianOutline button styleIt wasn't mentioned in the usability report that users had problems to find the non-outlined buttons on the mailbox app. But now that we have that style in the briar app, I'm thinking it might make sense for visual consistency between bo...It wasn't mentioned in the usability report that users had problems to find the non-outlined buttons on the mailbox app. But now that we have that style in the briar app, I'm thinking it might make sense for visual consistency between both apps to also use that style on the mailbox app.
Related: https://code.briarproject.org/briar/briar/-/merge_requests/1746Mailbox: Usability testingSebastianSebastianhttps://code.briarproject.org/briar/briar-mailbox/-/issues/179Dialogs from Do-not-kill-library have different style than other dialogs2022-12-02T16:04:52ZSebastianDialogs from Do-not-kill-library have different style than other dialogsOriginally reported [here](https://code.briarproject.org/briar/briar-mailbox/-/issues/92#note_72869).
![Screenshot_20221128_114031](/uploads/2cd65cb6de1ce905a2ee44406230874e/Screenshot_20221128_114031.png)
![Screenshot_20221128_114216](...Originally reported [here](https://code.briarproject.org/briar/briar-mailbox/-/issues/92#note_72869).
![Screenshot_20221128_114031](/uploads/2cd65cb6de1ce905a2ee44406230874e/Screenshot_20221128_114031.png)
![Screenshot_20221128_114216](/uploads/050ecee3f0642e7cb5947591e3ae56b0/Screenshot_20221128_114216.png)https://code.briarproject.org/briar/public-mesh-research/-/issues/19Investigate whether Android devices can connect via internet when no internet...2023-08-28T16:02:46ZakwizgranInvestigate whether Android devices can connect via internet when no internet access is detectedDuring a partial internet shutdown where a national network is disconnected from the internet but routing still works within the national network, Android devices may report that they don't have internet access because they can't fetch t...During a partial internet shutdown where a national network is disconnected from the internet but routing still works within the national network, Android devices may report that they don't have internet access because they can't fetch the URL that's used for detecting internet access (see https://stackoverflow.com/questions/33431931/how-does-android-know-if-the-wifi-connection-has-internet-access-or-not/39475588#39475588).
In this situation it would be useful to know whether an app can still route traffic to addresses on the national network. We might be able to simulate this situation by blocking access to the captive portal detection URL and perhaps also blocking DNS.Public mesh researchSebastianSebastianhttps://code.briarproject.org/briar/briar/-/issues/2403Not enough feedback while connecting to Mailbox2022-12-15T13:02:08ZakwizgranNot enough feedback while connecting to Mailbox> Sometimes the connection took a long time while setting up the Mailbox. In these cases, a few participants assumed that they were having problems with either the app or the internet connection. There is not enough feedback for the user...> Sometimes the connection took a long time while setting up the Mailbox. In these cases, a few participants assumed that they were having problems with either the app or the internet connection. There is not enough feedback for the user on this screen.Mailbox: Usability testingIvanaIvanahttps://code.briarproject.org/briar/briar-mailbox/-/issues/178Testers didn't understand purpose of stop button2023-01-19T13:03:25ZakwizgranTesters didn't understand purpose of stop button> Do users understand what the Stop button is for (and that they are not going to receive any messages in their Mailbox when it is stopped?)
>
> Most participants were confused by this question. They were trying to guess but they weren’t...> Do users understand what the Stop button is for (and that they are not going to receive any messages in their Mailbox when it is stopped?)
>
> Most participants were confused by this question. They were trying to guess but they weren’t sure if their answers were right. Some guessed that they would receive the messages and they would be saved in the mailbox, they would be able to get them after they run the Mailbox app again. Some assumed that they would lose all messages when they stop it. Others assumed that they would be able to get their messages if they stop
but they wouldn’t be able to get them if they Unlink the device, as in that case the Mailbox itself would be deleted.Mailbox: Usability testingSebastianSebastianhttps://code.briarproject.org/briar/briar/-/issues/2402Check that text in Briar's mailbox connection troubleshooter matches text in ...2023-04-24T13:05:32ZakwizgranCheck that text in Briar's mailbox connection troubleshooter matches text in Mailbox appMailbox: Releaseakwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/2400Testers didn't realise that text buttons were buttons2022-12-07T16:54:37ZakwizgranTesters didn't realise that text buttons were buttons![buttons-1](/uploads/72a3c9f24adea51777db39592588ef50/buttons-1.png)
> A few participants didn’t notice the “Check connection settings” button. In this case, the “Try again” button grabs the attention and it’s hard to tell that “Check ...![buttons-1](/uploads/72a3c9f24adea51777db39592588ef50/buttons-1.png)
> A few participants didn’t notice the “Check connection settings” button. In this case, the “Try again” button grabs the attention and it’s hard to tell that “Check connection settings” is a button, it looks like a text/link.
![buttons-2](/uploads/965fe0ae27bc7520d2f1b1dc9e32ca31/buttons-2.png)
> The same goes for the screenshot on the right, “Fix problem” and “Unlink” look like links. There is a mismatch in these patterns. Use buttons in every case the user is required to take action and use colors to distinguish their importance.
We're using the Material 2 "text button" style for these buttons. Maybe we should use the "outlined button" style instead.
https://m2.material.io/components/buttons/android#using-buttons
There's also some inconsistency in the colouring: we're using the link colour for the "fix problem" button (like the positive button in dialogs), but the app's primary colour for the "check connection settings" button.Mailbox: Usability testingakwizgranakwizgranhttps://code.briarproject.org/briar/briar-mailbox/-/issues/177Having stop button beside connection indicator is confusing2022-12-16T15:22:50ZakwizgranHaving stop button beside connection indicator is confusing> Having the “Stop” button near the check mark is confusing as it makes it look like a button instead of an indicator. I’d suggest you move the “Stop” button below the “Last connection...” text.> Having the “Stop” button near the check mark is confusing as it makes it look like a button instead of an indicator. I’d suggest you move the “Stop” button below the “Last connection...” text.Mailbox: Usability testingSebastianSebastianhttps://code.briarproject.org/briar/briar-mailbox/-/issues/176Not enough feedback while Mailbox is starting2022-11-30T11:04:52ZakwizgranNot enough feedback while Mailbox is starting> Sometimes the connection took a long time while setting up the Mailbox. In these cases, a few participants assumed that they were having problems with either the app or the internet connection. There is not enough feedback for the user...> Sometimes the connection took a long time while setting up the Mailbox. In these cases, a few participants assumed that they were having problems with either the app or the internet connection. There is not enough feedback for the user on this screen.Mailbox: Usability testing