briar issueshttps://code.briarproject.org/groups/briar/-/issues2018-04-16T16:24:37Zhttps://code.briarproject.org/briar/briar/-/issues/402Blog Client Implementation2018-04-16T16:24:37ZTorsten GroteBlog Client ImplementationA [BSP](https://code.briarproject.org/akwizgran/briar/wikis/BSP) Client similar to the `ForumManager` should be written that allows the user to
* create a new blog
* add posts to the blog
* get all blogs to be shown in the UI
* get ...A [BSP](https://code.briarproject.org/akwizgran/briar/wikis/BSP) Client similar to the `ForumManager` should be written that allows the user to
* create a new blog
* add posts to the blog
* get all blogs to be shown in the UI
* get blog posts for one blog
Here's an initial sketch of how the interface could look like:
```java
ClientId getClientId();
void addBlog(Blog b) throws DbException;
void addLocalPost(BlogPost p) throws DbException;
Blog getBlog(GroupId g) throws DbException;
Blog getBlog(Transaction txn, GroupId g) throws DbException;
Collection<Blog> getBlogs() throws DbException;
Collection<BlogPost> getBlogPosts(Blog b) throws DbException;
void registerRemoveBlogHook(RemoveBlogHook hook);
interface RemoveBlogHook {
void removingBlog(Transaction txn, Blog b) throws DbException;
}
```
# Open Questions
1. Should it be possible to delete a blog and if yes, how will all subscribers be informed about it?
2. Do we split `BlogPost` in a blog header and a blog body like done for private and forum messages?Milestone DTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/401Blog Protocol2018-04-16T16:24:37ZTorsten GroteBlog ProtocolDesign a protocol to be used for blog.
It should also be documented [in the wiki](https://code.briarproject.org/akwizgran/briar/wikis/BlogClient).
# Message types
Each blog has its own group. For exchanging invitations, the clie...Design a protocol to be used for blog.
It should also be documented [in the wiki](https://code.briarproject.org/akwizgran/briar/wikis/BlogClient).
# Message types
Each blog has its own group. For exchanging invitations, the client uses a separate group for each pair of contacts.
## Blog Group
The group descriptor is a BDF list with three elements: `name` (string), `author_name` (string) and `public_key` (raw). Posts are signed with the corresponding private key.
**0: POST** - The content is a BDF list with two elements: `content` (list) and `signature` (raw).
`content` is a list with six elements: `parent_id` (raw or null), `content_type` (string), `title` (string or null), `body` (raw), and `attachments` (dictionary or null). `parent_id` is the identifier of a post to which this is a follow-up. This parent post needs to be in the same blog group as this post. A blog clients must support a `content_type` of 'text/plain' for posts. Each key in `attachments` is the name of an attachment, and the value is a list with two elements: `content_type` (string) and `message_id` (raw).
`signature` is a signature over a list with three elements: `group_id` (raw), `timestamp` (int), and `content` (list). `group_id` and `timestamp` are taken from the [message header](BSP#message-format). `content` is described above.
**1: ATTACHMENT** - The content is raw data.
## Invitation Group
The group descriptor is a BDF list containing the unique IDs of the contacts' identities, sorted in ascending order as byte strings.
**0: INVITATION** - The content is a BDF list with four elements: `name` (string), `description` (string), `author` (list), and `message` (string or null).
The `author` is a list with two elements: `author_name` (string) and `public_key` (raw).
The identifier of the blog group to which the invitation refers can be calculated from `name`, `author_name` and `public_key`, as described above. `message` is an optional message from the inviter to the invitee.
**1: ACCEPT RESPONSE** - Response that indicates the peer wants to subscribe to the blog. The content is a BDF list with one element: `invitation_id` (raw) which is the identifier of an invitation created by the opposite peer.
**2: DECLINE RESPONSE** - Response that indicates the peer does not want to subscribe to the blog. The content is a BDF list with one element: `invitation_id` (raw) which is the identifier of an invitation created by the opposite peer.
**3: LEAVE** - The content is a BDF list with one element: `invitation_id` (raw), which is the identifier of an invitation created by either peer.
![blog-sharing](/uploads/3086686b3a8380d8c2e80c0014e20edf/blog-sharing.png)
# Open Questions
1. ~~Who can invite to blogs? Only the creator or everybody who subscribes to the blog?~~
* Every subscriber can invite others.
2. ~~Who can send a LEAVE message? Only subscribers or the creator as well?~~
* Both, the creator and the subscribers can send LEAVE messages at any time.
3. ~~How can we enforce that only the creator can post to the blog group? Should other clients reject message based on signature? If so, how do they verify?~~
* The signature on blog posts is verified using the public_key of the blog.
4. Which key pair is used for the blog? The long-term key-pair of its creator or a special blog key-pair?
5. What will be the `content_type` of blog posts? Are we going to support HTML initially? How will people create/edit the HTML?
* This has been outsourced to #421, but we need to know what kind of content type to accept and validate for the protocol.
* All blog clients should support `text/html` for the content type.
6. ~~Should blog posts not have a title as well? It is currently not part of the **POST** message.~~
* A `title` has been added to the **POST** message.
7. ~~Do we really need a note/message to be send along with the response?~~
* No! It has been removed from both responses.
8. Will blog authors be able to edit their post after they have published it already? If so, how? Special update message or re-use of `MessageId`?
* For the first phase, we'll assume that blog authors cannot edit published posts
9. Are we really going to use the 'sharing as action' paradigm for blogs? Maybe 'sharing as state' would be more suitable and allow for blogs to be available to more people more easily. ([discussion](https://code.briarproject.org/akwizgran/briar/issues/405#note_6043))
* akwizgran decided to do sharing as action as with forums, because this is easier to understand for users due to familiar metaphors.
* later we can add automatic sharing on top of the current mechanism
10. Should there be an option/flag that signals contacts you share the blog with that they automatically should share it with all of their contacts? (metadata leak?)
* If we do sharing as action, then no. At least, initially. Later we can add automatic sharing, but don't necessarily need a flag for it.
11. Are we going to support comments initially? If not, it might still be worth looking into how they could work, so the protocol does not need to be changed too much later on.
* WordPress-style comments won't be supported
* However, we could support Tumblr-style "reblog and add your own text" comments
* Reblogging would not be a phase 1 feature however
12. How do we tie the creator's identity to the blog (and its key pair)?
* the blog descriptor includes the creator's public key and she uses her private key to sign all posts.
13. Should the blog description be part of the group descriptor? If yes, it can never be changed, if no, it could be changed by sharers.Milestone DTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/397Remove unused Java layout helpers2018-06-12T11:32:27ZakwizgranRemove unused Java layout helpersVarious classes in org.briarproject.android.util can be removed once the last layouts have been converted to XML.
Subtask of #53.Various classes in org.briarproject.android.util can be removed once the last layouts have been converted to XML.
Subtask of #53.Milestone DTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/396Convert ExpiredActivity to XML2018-06-12T11:32:27ZakwizgranConvert ExpiredActivity to XMLSubtask of #53.Subtask of #53.Milestone CTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/395Convert CreateIdentityActivity to XML2018-06-12T11:32:27ZakwizgranConvert CreateIdentityActivity to XMLSubtask of #53.Subtask of #53.Milestone CTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/393Sort threaded messages2018-06-12T11:32:27ZakwizgranSort threaded messagesWrite code for sorting a forest of threaded messages:
* Roots in timestamp order
* Children below their parents
* Siblings in timestamp order
The input will be an unsorted collection of messages with parent pointers. The code mus...Write code for sorting a forest of threaded messages:
* Roots in timestamp order
* Children below their parents
* Siblings in timestamp order
The input will be an unsorted collection of messages with parent pointers. The code must not use more than O(n log n) time or space. Algorithms presumably exist already, find them!
Subtask of #122.Milestone Chttps://code.briarproject.org/briar/briar/-/issues/392Use new metadata queries for forum client2018-06-12T11:32:27ZTorsten GroteUse new metadata queries for forum clientUse new queries introduced in !187.Use new queries introduced in !187.Milestone CTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/391Handle responses to forum invitations by multiple contacts2018-01-28T11:30:28ZTorsten GroteHandle responses to forum invitations by multiple contactsMilestone CTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/387Allow to Unshare Forum2021-10-21T15:47:36ZTorsten GroteAllow to Unshare ForumWe switched the forum sharing paradigm from sharing as state to sharing as action and now there's no way to unshare a forum with someone without leaving the forum. I guess we can just misuse the LEAVE messages without actually leaving th...We switched the forum sharing paradigm from sharing as state to sharing as action and now there's no way to unshare a forum with someone without leaving the forum. I guess we can just misuse the LEAVE messages without actually leaving the forum, so we don't have to alter the protocol.
However, where in the UI do we allow to unshare a forum with someone?https://code.briarproject.org/briar/briar/-/issues/385Add BQP support to the LAN plugin2018-06-12T11:32:27ZakwizgranAdd BQP support to the LAN pluginThis will allow us to work around Bluetooth issues when both devices are connected to the same LAN.This will allow us to work around Bluetooth issues when both devices are connected to the same LAN.Milestone Chttps://code.briarproject.org/briar/briar/-/issues/384Create conversation manager2021-07-05T13:41:40ZakwizgranCreate conversation managerThe UI combines private messages, introduction messages and forum sharing messages into a single conversation. This requires various parts of the UI (contact list, conversation view, notification manager) to combine messages from the mes...The UI combines private messages, introduction messages and forum sharing messages into a single conversation. This requires various parts of the UI (contact list, conversation view, notification manager) to combine messages from the messaging, introduction, and forum sharing clients. Create a ConversationManager in the core that deals with combining these messages and presents a unified API (including events) to the UI.https://code.briarproject.org/briar/briar/-/issues/382Deliver messages to incoming message hook after their dependencies2018-06-12T11:32:27ZakwizgranDeliver messages to incoming message hook after their dependenciesThe sync layer should keep track of each message's dependencies and deliver messages to the incoming message hook after their dependencies. If any dependency is invalid or in a different group, the message is invalid and should be delete...The sync layer should keep track of each message's dependencies and deliver messages to the incoming message hook after their dependencies. If any dependency is invalid or in a different group, the message is invalid and should be deleted.
Messages that are waiting for dependencies should not be visible to clients.
Subtask of #122.Milestone CTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/381Extract dependencies from messages in validation hook2018-06-12T11:32:27ZakwizgranExtract dependencies from messages in validation hookThe validation hook should return a list of dependencies to the validation manager.The validation hook should return a list of dependencies to the validation manager.Milestone DTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/379Safe publication audit2020-11-21T19:01:53ZakwizgranSafe publication auditAudit the codebase for safe publication issues:
* Allowing `this` to escape the constructor (including indirectly via non-static inner classes)
* Passing mutable objects between threads (including mutable collections)Audit the codebase for safe publication issues:
* Allowing `this` to escape the constructor (including indirectly via non-static inner classes)
* Passing mutable objects between threads (including mutable collections)https://code.briarproject.org/briar/briar/-/issues/378Replace BDF data structures with classes in forum sharing client2018-06-12T11:32:28ZakwizgranReplace BDF data structures with classes in forum sharing clientThe forum sharing client uses BdfDictionary and BdfList for its internal data structures, rather than just for serialisation. This tends to push type checking from compile time to run time. Create classes to represent the protocol messag...The forum sharing client uses BdfDictionary and BdfList for its internal data structures, rather than just for serialisation. This tends to push type checking from compile time to run time. Create classes to represent the protocol messages and other internal state.Milestone CTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/377Replace BDF data structures with classes in introduction client2018-04-28T00:17:04ZakwizgranReplace BDF data structures with classes in introduction clientThe introduction client uses BdfDictionary and BdfList for its internal data structures, rather than just for serialisation. This tends to push type checking from compile time to run time. Create classes to represent the client's interna...The introduction client uses BdfDictionary and BdfList for its internal data structures, rather than just for serialisation. This tends to push type checking from compile time to run time. Create classes to represent the client's internal state.Android 1.0Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/376Refactor clients based on ProtocolEngine2018-04-28T00:12:24ZakwizgranRefactor clients based on ProtocolEngineThe ProtocolEngine interface allows certain tasks to be performed in response to local actions and incoming messages: updating local state, sending messages, broadcasting events and deleting the incoming message. Clients based on Protoco...The ProtocolEngine interface allows certain tasks to be performed in response to local actions and incoming messages: updating local state, sending messages, broadcasting events and deleting the incoming message. Clients based on ProtocolEngine that need to perform other tasks are forced to store a task label in the local state, then retrieve it and perform the task outside the engine. This defeats the purpose of the engine interface, which is meant to encapsulate the protocol logic.
Alter or remove the ProtocolEngine interface so clients have the flexibility they need.Android 1.0Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/375Extract ForumFactory from ForumManager2018-06-12T11:32:28ZakwizgranExtract ForumFactory from ForumManagerThe code for creating forums in ForumManager is used by ForumSharingManager and also needed by InviteeEngine. Extract it into its own class.The code for creating forums in ForumManager is used by ForumSharingManager and also needed by InviteeEngine. Extract it into its own class.Milestone CTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/374Add Forum Avatars to Available Forums List2018-06-12T11:32:28ZTorsten GroteAdd Forum Avatars to Available Forums ListAs soon as !172 and !178 have both been merged, the forum avatars should also be added to the Available Forums List.
As soon as !172 and !178 have both been merged, the forum avatars should also be added to the Available Forums List.
Milestone CTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/372Clean up Introduction Session States when removing contact2018-06-12T11:32:28ZTorsten GroteClean up Introduction Session States when removing contactCurrently, when a contact is removed, any existing sessions will be aborted, but no session state messages are deleted from the local group.
Currently, when a contact is removed, any existing sessions will be aborted, but no session state messages are deleted from the local group.
Milestone CTorsten GroteTorsten Grote