briar issueshttps://code.briarproject.org/groups/briar/-/issues2021-03-10T06:23:13Zhttps://code.briarproject.org/briar/briar-reproducer/-/issues/1Build .deb containing briar-headless.jar2021-03-10T06:23:13ZNicoBuild .deb containing briar-headless.jarSince packaging briar-headless in Debian main (https://code.briarproject.org/briar/briar-debian/-/issues/1) is currently blocked, efforts will now focus on creating an official APT repository by The Briar Project (https://code.briarproje...Since packaging briar-headless in Debian main (https://code.briarproject.org/briar/briar-debian/-/issues/1) is currently blocked, efforts will now focus on creating an official APT repository by The Briar Project (https://code.briarproject.org/briar/briar-debian/-/issues/3). The *briar-headless.deb* provided in that repository will ideally come from briar-reproducer. We need to extend briar-reproducer to not only create a *briar-headless.jar*, but also a *briar-headless.deb* that contains the *.jar*.NicoNicohttps://code.briarproject.org/briar/briar-desktop/-/issues/65Update dependencies to newest versions2021-12-06T14:25:33ZMikolai GütschowUpdate dependencies to newest versionsIntelliJ currently proposes new versions for `jackson-databind` (what do we need that for actually?), `clikt`, `material-icons-extended`, `dagger` and `kotlin` itself.IntelliJ currently proposes new versions for `jackson-databind` (what do we need that for actually?), `clikt`, `material-icons-extended`, `dagger` and `kotlin` itself.Desktop 0.1.0Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/briar-gtk/-/issues/13Update Briar headless to 1.2.72020-03-22T00:53:57ZNicoUpdate Briar headless to 1.2.7* https://code.briarproject.org/briar/briar/-/wikis/changelog#anchor-127
* https://code.briarproject.org/briar/briar/-/tags/release-1.2.7
* https://media.dorfbrunnen.eu/briar/jars/009/* https://code.briarproject.org/briar/briar/-/wikis/changelog#anchor-127
* https://code.briarproject.org/briar/briar/-/tags/release-1.2.7
* https://media.dorfbrunnen.eu/briar/jars/009/GTK 0.1.0-alpha1NicoNicohttps://code.briarproject.org/briar/briar-gtk/-/issues/2Repair pytest on GitLab CI2020-07-19T13:59:52ZNicoRepair pytest on GitLab CISince fc91cbd8dac3db4dd8965b7ef1662b63bad047f6, _pytest_ fails on GitLab CI. Locally, everything works fine for me. [This is the first job](https://code.briarproject.org/nicoalt/briar-gtk/-/jobs/3893) failing for this commit:
```
$ tool...Since fc91cbd8dac3db4dd8965b7ef1662b63bad047f6, _pytest_ fails on GitLab CI. Locally, everything works fine for me. [This is the first job](https://code.briarproject.org/nicoalt/briar-gtk/-/jobs/3893) failing for this commit:
```
$ tools/tests/test-pytest.sh
============================= test session starts ==============================
platform linux -- Python 3.7.3, pytest-5.2.0, py-1.8.0, pluggy-0.13.0
rootdir: /builds/nicoalt/briar-gtk, inifile: pytest.ini
plugins: cov-2.7.1, mock-1.11.0, requests-mock-1.7.0
collected 20 items
tests/briar/api/test_constants.py .... [ 20%]
tests/briar/api/models/test_contacts.py . [ 25%]
tests/briar/api/models/test_private_chat.py .. [ 35%]
tests/briar/gtk/test_application.py .....tools/tests/test-pytest.sh: line 6: 4406 Trace/breakpoint trap (core dumped) PYTHONPATH=src pytest --cov=src tests/
ERROR: Job failed: exit code 1
```
Until this is fixed, I allowed the pipeline to fail with d519ebc7aa5e0d3ed76cba2a424c4e64acf4397a.GTK 0.1.0-alpha2https://code.briarproject.org/briar/python-briar-wrapper/-/issues/2flit as tool to package and upload python-briar-wrapper to pypi?2020-03-21T23:14:56Zfphemeralflit as tool to package and upload python-briar-wrapper to pypi?So far I quite ejoyed flit for packaging and uploading pypi packages:
https://pypi.org/project/flit/
@nicoalt if you are ok with it, I would set it for this repo.So far I quite ejoyed flit for packaging and uploading pypi packages:
https://pypi.org/project/flit/
@nicoalt if you are ok with it, I would set it for this repo.fphemeralfphemeralhttps://code.briarproject.org/briar/briar/-/issues/809Create tickets for things that need to be done before public beta2017-07-21T13:28:29ZakwizgranCreate tickets for things that need to be done before public betaAndroid Beta 1akwizgranakwizgranhttps://code.briarproject.org/briar/briar-gtk/-/issues/5Lazy loading of messages2021-01-11T08:03:51ZNicoLazy loading of messagesCurrently, all messages are loaded at once. With chat histories becoming bigger and bigger, this could result in serious performance problems.
Related issue in wrapper: https://code.briarproject.org/briar/python-briar-wrapper/issues/5Currently, all messages are loaded at once. With chat histories becoming bigger and bigger, this could result in serious performance problems.
Related issue in wrapper: https://code.briarproject.org/briar/python-briar-wrapper/issues/5https://code.briarproject.org/briar/briar/-/issues/629Test whether Tor hidden service patch is still needed2018-07-31T16:17:46ZakwizgranTest whether Tor hidden service patch is still needed~~Repeat the Tor performance experiments from #115 using Tor 0.2.6.7 with the old and new code to determine the impact of improvements to Tor itself, specifically issue #8239 (https://trac.torproject.org/projects/tor/ticket/8239).~~
Rep...~~Repeat the Tor performance experiments from #115 using Tor 0.2.6.7 with the old and new code to determine the impact of improvements to Tor itself, specifically issue #8239 (https://trac.torproject.org/projects/tor/ticket/8239).~~
Repeat the Tor performance experiments from #115 using Tor 0.2.9.15, with and without our hidden service patch, to see whether our patch still affects performance. Test the patch from issue #19522 (https://trac.torproject.org/projects/tor/ticket/19522) to see whether it would be a suitable alternative to our patch.
If our patch is still needed, update it to address the reviewers' comments from https://trac.torproject.org/projects/tor/ticket/18620. That ticket should be closed, as v2 hidden services are being deprecated. If we need a new patch for v3 hidden services we should open a new ticket.
See discussion on #115. ~~Subtask of #152.~~Android 1.1akwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/377Replace BDF data structures with classes in introduction client2018-04-28T00:17:04ZakwizgranReplace BDF data structures with classes in introduction clientThe introduction client uses BdfDictionary and BdfList for its internal data structures, rather than just for serialisation. This tends to push type checking from compile time to run time. Create classes to represent the client's interna...The introduction client uses BdfDictionary and BdfList for its internal data structures, rather than just for serialisation. This tends to push type checking from compile time to run time. Create classes to represent the client's internal state.Android 1.0Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar-mailbox/-/issues/9Register mailbox app signing key and package name with Google Play2022-02-07T09:46:53ZakwizgranRegister mailbox app signing key and package name with Google PlayRegister the package name and app signing key of the mailbox app with Google Play before the end of July 2021 so we're not required to let Google manage the signing key.
https://android-developers.googleblog.com/2020/11/new-android-app-...Register the package name and app signing key of the mailbox app with Google Play before the end of July 2021 so we're not required to let Google manage the signing key.
https://android-developers.googleblog.com/2020/11/new-android-app-bundle-and-target-api.htmlMailboxakwizgranakwizgran2021-07-31https://code.briarproject.org/briar/briar/-/issues/949Investigate error messages from CI runners2017-06-09T19:25:50ZakwizgranInvestigate error messages from CI runnersEvery hour the CI runners are logging errors similar to the following:
```
May 12 06:46:04 ci gitlab-runner[21146]: time="2017-05-12T06:46:04Z" level=error msg="Runner https://code.briarproject.org/ci733e[scrubbed] is not healthy, but wi...Every hour the CI runners are logging errors similar to the following:
```
May 12 06:46:04 ci gitlab-runner[21146]: time="2017-05-12T06:46:04Z" level=error msg="Runner https://code.briarproject.org/ci733e[scrubbed] is not healthy, but will be checked!" #012<nil>
May 12 06:46:04 ci gitlab-ci-multi-runner[21146]: time="2017-05-12T06:46:04Z" level=error msg="Runner https://code.briarproject.org/ci733e[scrubbed] is not healthy, but will be checked!"
May 12 06:46:04 ci gitlab-runner[21146]: time="2017-05-12T06:46:04Z" level=error msg="Checking for builds... forbidden" runner=733eb190 #012<nil>
May 12 06:46:04 ci gitlab-ci-multi-runner[21146]: time="2017-05-12T06:46:04Z" level=error msg="Checking for builds... forbidden" runner=733eb190
May 12 06:46:07 ci gitlab-runner[21146]: time="2017-05-12T06:46:07Z" level=error msg="Checking for builds... forbidden" runner=733eb190 #012<nil>
May 12 06:46:07 ci gitlab-ci-multi-runner[21146]: time="2017-05-12T06:46:07Z" level=error msg="Checking for builds... forbidden" runner=733eb190
May 12 06:46:10 ci gitlab-runner[21146]: time="2017-05-12T06:46:10Z" level=error msg="Checking for builds... forbidden" runner=733eb190 #012<nil>
May 12 06:46:10 ci gitlab-ci-multi-runner[21146]: time="2017-05-12T06:46:10Z" level=error msg="Checking for builds... forbidden" runner=733eb190
May 12 06:46:10 ci gitlab-runner[21146]: time="2017-05-12T06:46:10Z" level=error msg="Runner https://code.briarproject.org/ci733e[scrubbed] is not healthy and will be disabled!" #012<nil>
May 12 06:46:10 ci gitlab-ci-multi-runner[21146]: time="2017-05-12T06:46:10Z" level=error msg="Runner https://code.briarproject.org/ci733e[scrubbed] is not healthy and will be disabled!"
```Milestone GTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/943Use stable IDs in BriarAdapter2017-06-09T19:25:50ZJulian DehmUse stable IDs in BriarAdapterSince we already have everything at hand (a stable message id) we could use the stableId feature of the recyclerview to improve performance.
https://developer.android.com/reference/android/support/v7/widget/RecyclerView.Adapter.html#setH...Since we already have everything at hand (a stable message id) we could use the stableId feature of the recyclerview to improve performance.
https://developer.android.com/reference/android/support/v7/widget/RecyclerView.Adapter.html#setHasStableIds(boolean)https://code.briarproject.org/briar/python-briar-wrapper/-/issues/15Add option to use system's Tor binary2021-06-29T05:57:21ZNicoAdd option to use system's Tor binaryThis is most likely needed for a release to Debian (https://code.briarproject.org/briar/briar-gtk/issues/38).This is most likely needed for a release to Debian (https://code.briarproject.org/briar/briar-gtk/issues/38).https://code.briarproject.org/briar/briar/-/issues/937Research how to package Bramble as a Cordova plugin2017-06-09T19:25:50ZakwizgranResearch how to package Bramble as a Cordova pluginSubtask of #141.Subtask of #141.Milestone Fakwizgranakwizgranhttps://code.briarproject.org/briar/python-briar-wrapper/-/issues/19Adding contacts remotely does not check return value, hides errors2021-03-08T13:24:27ZTorsten GroteAdding contacts remotely does not check return value, hides errorsIt looks like, the result of the POST request isn't checked here:
https://code.briarproject.org/briar/python-briar-wrapper/-/blob/b8ac26b21dd5b3580d49a582c7b16cebd6c3dc3e/briar_wrapper/models/contacts.py#L37
I found this when debugging...It looks like, the result of the POST request isn't checked here:
https://code.briarproject.org/briar/python-briar-wrapper/-/blob/b8ac26b21dd5b3580d49a582c7b16cebd6c3dc3e/briar_wrapper/models/contacts.py#L37
I found this when debugging why failed pending contacts don't get re-added. Check how the Android UI handles this:
* https://code.briarproject.org/briar/briar/-/blob/1f246637e25a9e53e7b9ec8961e1ad6bf26a7daf/briar-android/src/main/java/org/briarproject/briar/android/contact/add/remote/NicknameFragment.java#L123
* https://code.briarproject.org/briar/briar/-/blob/1f246637e25a9e53e7b9ec8961e1ad6bf26a7daf/briar-android/src/main/java/org/briarproject/briar/android/contact/add/remote/AddContactViewModel.java#L124Wrapper 0.0.7NicoNicohttps://code.briarproject.org/briar/briar/-/issues/931Check whether getSystemService() returns null2017-06-09T19:25:50ZakwizgranCheck whether getSystemService() returns nullWe call Context#getSystemService() in various places without checking the return value. Apparently it can return null, so we should check it.We call Context#getSystemService() in various places without checking the return value. Apparently it can return null, so we should check it.https://code.briarproject.org/briar/briar/-/issues/928Move HTML sanitation to DbThread2017-06-09T19:25:50ZTorsten GroteMove HTML sanitation to DbThreadHTML Sanitation currently causes a StrictMode violation:
```
D/StrictMode: StrictMode policy violation; ~duration=407 ms: android.os.StrictMode$StrictModeDiskReadViolation: policy=31 violation=2
at an...HTML Sanitation currently causes a StrictMode violation:
```
D/StrictMode: StrictMode policy violation; ~duration=407 ms: android.os.StrictMode$StrictModeDiskReadViolation: policy=31 violation=2
at android.os.StrictMode$AndroidBlockGuardPolicy.onReadFromDisk(StrictMode.java:1152)
at libcore.io.BlockGuardOs.stat(BlockGuardOs.java:292)
at java.io.File.isDirectory(File.java:524)
at java.io.File.getAbsoluteName(File.java:1099)
at java.io.File.toURL(File.java:1085)
at dalvik.system.DexPathList$Element.findResource(DexPathList.java:477)
at dalvik.system.DexPathList.findResource(DexPathList.java:343)
at dalvik.system.BaseDexClassLoader.findResource(BaseDexClassLoader.java:67)
at java.lang.ClassLoader.getResource(ClassLoader.java:403)
at java.lang.ClassLoader.getResourceAsStream(ClassLoader.java:442)
at java.lang.Class.getResourceAsStream(Class.java:1368)
at org.jsoup.nodes.Entities.loadEntities(Entities.java:240)
at org.jsoup.nodes.Entities.<clinit>(Entities.java:225)
at org.jsoup.nodes.Entities.access$000(Entities.java:17)
at org.jsoup.nodes.Entities$EscapeMode.<clinit>(Entities.java:20)
at org.jsoup.nodes.Document$OutputSettings.<init>(Document.java:371)
at org.jsoup.nodes.Document.<init>(Document.java:18)
at org.jsoup.nodes.Document.createShell(Document.java:42)
at org.jsoup.parser.Parser.parseBodyFragment(Parser.java:128)
at org.jsoup.Jsoup.parseBodyFragment(Jsoup.java:148)
at org.jsoup.Jsoup.clean(Jsoup.java:198)
at org.jsoup.Jsoup.clean(Jsoup.java:215)
at org.briarproject.briar.util.HtmlUtils.clean(HtmlUtils.java:15)
```
The `clean()` method should be called right after the blog posts are retrieved from disk to prevent that.Milestone GTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/915Fix ForumActivityTest2017-06-09T19:25:51ZakwizgranFix ForumActivityTestForumActivityTest#testNestedEntries() has been failing since 17 December.
```
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework...ForumActivityTest#testNestedEntries() has been failing since 17 December.
```
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertTrue(Assert.java:31)
at org.briarproject.briar.android.forum.ForumActivityTest.testNestedEntries(ForumActivityTest.java:120)
```Milestone GTorsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/914Simplify SecureRandom implementation2017-06-09T19:25:51ZakwizgranSimplify SecureRandom implementationOur current SecureRandom implementation involves XORing a Fortuna-based PRNG with the system's default SecureRandom implementation. This is meant to help protect against any weaknesses in the system's PRNG, such as the Android SecureRand...Our current SecureRandom implementation involves XORing a Fortuna-based PRNG with the system's default SecureRandom implementation. This is meant to help protect against any weaknesses in the system's PRNG, such as the Android SecureRandom bug (CVE-2013-7372, https://android-developers.googleblog.com/2013/08/some-securerandom-thoughts.html). However, the construct is quite complex and not properly documented. We should simplify it and document it.Milestone Ghttps://code.briarproject.org/briar/briar-gtk/-/issues/27Refactor code2020-12-31T12:06:36ZNicoRefactor codeSo far, the code has grown organically. We should refactor the code to reduce duplication and improve maintainability.
#### Useful links
* https://refactoring.guruSo far, the code has grown organically. We should refactor the code to reduce duplication and improve maintainability.
#### Useful links
* https://refactoring.guruGTK 0.1.0-beta3NicoNico