briar issueshttps://code.briarproject.org/groups/briar/-/issues2023-08-25T13:33:36Zhttps://code.briarproject.org/briar/briar-desktop/-/issues/305Set windows' minimum size depending on Dp2023-08-25T13:33:36ZMikolai GütschowSet windows' minimum size depending on DpThe following discussion from !144 should be addressed:
- [ ] @sebkur started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/144#note_62513): (+4 comments)
> I think it probably makes sense to ad...The following discussion from !144 should be addressed:
- [ ] @sebkur started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/144#note_62513): (+4 comments)
> I think it probably makes sense to add a minimum size to the dialog's underlying window, too. Like we do in `BriarUi#start()`, i.e. we could add
> ```
> window.minimumSize = Dimension(450, 500)
> ```
> or even use the initial sizes used above (although the probably need to be converted to pixels somehow
quoting @paul-lorenc :
> From https://github.com/JetBrains/compose-jb/issues/1773, it looks like we can use the following line:
>
> `val density = LocalDensity.current`
>
> To get the current screen density, then calculate the dp to pixel conversion using this density (maybe?). For now I think `window.minimumSize = Dimension(x, y)` is good enough here, and we can further investigate this method to use here, and also for defining the minimum size of the main UI window.Desktop 0.7.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/332Update Conversation Search to Material Spec2023-08-25T13:33:35ZpaulUpdate Conversation Search to Material SpecI found https://material.io/design/navigation/search.html#expandable-search which covers how we likely should handle the contact list search bar in a "material way". If this looks good to everyone, I can try and implement this change.I found https://material.io/design/navigation/search.html#expandable-search which covers how we likely should handle the contact list search bar in a "material way". If this looks good to everyone, I can try and implement this change.Desktop 0.7.0https://code.briarproject.org/briar/briar-desktop/-/issues/349FAB in chat window not shown if older message arrives out-of-order2023-08-25T13:33:35ZMikolai GütschowFAB in chat window not shown if older message arrives out-of-orderThis issue was encountered while testing for release 0.2.1 #346. We would need to have a way to reproduce this (e.g. by sending some message from a test contact after a given time in TestData).
Nevertheless, the message counter in the c...This issue was encountered while testing for release 0.2.1 #346. We would need to have a way to reproduce this (e.g. by sending some message from a test contact after a given time in TestData).
Nevertheless, the message counter in the contact list was updated (directly after?) receiving the out-of-order message and after changing to another chat and navigating back to the chat with the new message, the scrollview was automatically scrolled to the new message.Desktop 0.7.0https://code.briarproject.org/briar/briar-desktop/-/issues/306Center AddContactDialog in current MainWindow2023-08-25T13:33:34ZMikolai GütschowCenter AddContactDialog in current MainWindowFollow-up of https://code.briarproject.org/briar/briar-desktop/-/merge_requests/144#note_62432
Currently it is centered in the center of the screen, no matter where the Briar Main Window is shown.Follow-up of https://code.briarproject.org/briar/briar-desktop/-/merge_requests/144#note_62432
Currently it is centered in the center of the screen, no matter where the Briar Main Window is shown.Desktop 0.7.0https://code.briarproject.org/briar/briar/-/issues/26Contact details screen2023-06-16T18:29:14ZakwizgranContact details screen* Indication of whether the contact is connected (and via which transports)
* Indication of whether the contact was added directly or introduced
* Indication of whether the contact is using a mailbox
* Indication of whether what features...* Indication of whether the contact is connected (and via which transports)
* Indication of whether the contact was added directly or introduced
* Indication of whether the contact is using a mailbox
* Indication of whether what features are supported by the contact (e.g forums, blogs)
* History of sharing and introduction events
* Button for introducing to another contact
* Button for deleting contacthttps://code.briarproject.org/briar/briar-desktop/-/issues/453Let user open forum from within request message (only) after accepting the in...2023-05-11T21:20:22ZMikolai GütschowLet user open forum from within request message (only) after accepting the invitationThis issue consists of two parts:
- Currently clicking on "Open" does not do anything (`ConversationRequestItem(onOpenRequestedShareable = {})` is the default)
- After declining an invitation, "Open" is also shown to the user which doesn...This issue consists of two parts:
- Currently clicking on "Open" does not do anything (`ConversationRequestItem(onOpenRequestedShareable = {})` is the default)
- After declining an invitation, "Open" is also shown to the user which doesn't make sense:
![image](/uploads/4c950cc496d574839b90d876ac1adf3a/image.png)https://code.briarproject.org/briar/briar-desktop/-/issues/366Improve screen-reader support2023-04-17T22:04:24ZMikolai GütschowImprove screen-reader supportTargeting issues raised in #341 and as part of #84.
- Heading structure: > not supported by upstream Compose (https://github.com/JetBrains/compose-jb/issues/2119)
- [ ] "Welcome to Briar" on login and main screen (no chats)
- [ ] co...Targeting issues raised in #341 and as part of #84.
- Heading structure: > not supported by upstream Compose (https://github.com/JetBrains/compose-jb/issues/2119)
- [ ] "Welcome to Briar" on login and main screen (no chats)
- [ ] contact name in chat screen
- [ ] "Settings" on SettingsScreen
- Image(Button) contentDescription:
- [ ] Briar logo on login > only of decorative nature, automatically skipped over by VoiceOver
- [x] back and info button on login > !223 and info button already "About Briar Desktop" on `main`
- [x] menu button in chat screen > already "Show Contact Menu" on `main`
- [x] add contact button without chats > fixed on `main`
- [x] attachment button in chat screen > fixed on `main`
- Missing context:
- [x] show password buttons on login/change password > automatically grouped on macOS/VoiceOver
- [x] labels for text fields (registration screen) > !225
- Missing list grouping:
- [x] contact list > !218
- [x] settings as list > !224
- Missing state information (expanded/collapsed): Dropdowns/Pop-Ups not supported by Compose https://github.com/JetBrains/compose-jb/issues/2185
- [ ] menu button in chat screen
- [ ] theme/language settings, also dynamic changes
- Misc:
- [ ] error message on login (not read out loud) > upstream bug: https://github.com/JetBrains/compose-jb/issues/2277
- [x] about dialog (no exit button, table not marked as such, email is not link) > !221
- [x] message count/online status in contact list > !218
- [x] "keyboard trap" in compose message text field (tab button is stuck in text field) > !222
- [ ] Missing landmarks on MainScreen to convey structure to screen-reader user > not supported by Compose
- [x] Keyboard focus does not go to close button on add contact dialog > probably missing OS-functionality on Ubuntu/Orca which is anyhow not supported, confirmed to work on macOS with VoiceOver as expected
- [ ] Dropdown not marked as such (settings) > Dropdowns/Pop-Ups not supported by Compose https://github.com/JetBrains/compose-jb/issues/2185
- [x] Briar link name/label on Add Contact dialog > !230
- [x] Add attachment button not keyboard-focusable on macOS > !222Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/briar/-/issues/2255Improve ContactExistsException2023-03-15T13:04:32ZSebastianImprove ContactExistsExceptionWhen Alice adds an existing proper contact again via `briar://` link, we throw a `ContactExistsException` that is used to show warnings to her to warn about a potential attack that might be in progress with one of the contacts trying to ...When Alice adds an existing proper contact again via `briar://` link, we throw a `ContactExistsException` that is used to show warnings to her to warn about a potential attack that might be in progress with one of the contacts trying to discover her contacts or non-contacts. The exception carries the local `AuthorId` as well as the remote `Author` so that a warning message can explain to Alice who the involved contacts are. However it lacks the alias Alice might have given to the existing contact. The result is that only the original self-given name of the contact can be displayed in warnings. I think this might confuse Alice as the contact name displayed in the warning can be different from the name displayed in her contact list and also can be rather ambiguous.
I propose we add the alias to the `ContactExistsException`. Among the three places where this exception gets created, in one place (in `DatabaseComponentImpl#addPendingContact()`) we already have the existing contact retrieved from the db readily available and could set the additional data right away. In the two other places (in `DatabaseComponentImpl#addContact()`), we don't yet have the contact retrieved. Instead we checked `containsIdentity()` and/or `containsContact()` there. I think we could either just retrieve the existing contact additionally there, shouldn't be a huge burden in terms of performance. We could also leave out the `containsContact()` check and just check if the contact retrieved is `!= null`. Maybe we can even leave out the `containsIdentity()` in this case? Either way I think performance shouldn't be an issue.https://code.briarproject.org/briar/briar/-/issues/42Show new messages/forum posts in navigation drawer2023-03-15T12:38:14ZakwizgranShow new messages/forum posts in navigation drawerFeedback from a user: "It would be good to have a place/notification for all new messages when you first go on the app, instead of separately clicking on contacts or forums and searching for messages."
We should show the number of unrea...Feedback from a user: "It would be good to have a place/notification for all new messages when you first go on the app, instead of separately clicking on contacts or forums and searching for messages."
We should show the number of unread private messages next to the Contacts button on the dashboard, and likewise for forum posts. Bonus points for putting the numbers in little red circles (long ago requested by another user).
Another user requested a timeline of recent activity on the dashboard - for example, this person replied to your post on this forum, or this person shared this forum with you.
**Update:** We have no dashboard anymore, but might want to show this in the navigation drawer (#431).https://code.briarproject.org/briar/briar-desktop/-/issues/177Event-driven loading of single (new) messages instead of reloading all of them2023-03-13T22:19:01ZMikolai GütschowEvent-driven loading of single (new) messages instead of reloading all of themCurrently, when an introduction is initiated, all messages in the current private chat are reloaded. It would be better to switch to an event-based loading of the single newly added message. `ConversationMessageTrackedEvent` which was ad...Currently, when an introduction is initiated, all messages in the current private chat are reloaded. It would be better to switch to an event-based loading of the single newly added message. `ConversationMessageTrackedEvent` which was added for updating group counts currently does not include message IDs, but this could be easily changed. However, Briar core currently does not support loading single messages by message ID.
Another approach would be to emit ConversationMessageSentEvents similar to the ConversationMessageReceivedEvent.
See https://code.briarproject.org/briar/briar-desktop/-/merge_requests/69#note_58749.https://code.briarproject.org/briar/briar-desktop/-/issues/262Redesign contact list2023-03-08T14:07:24ZNicoRedesign contact listThis is what I had in mind for Briar GTK:
![mobile-shell-convergence](https://code.briarproject.org/briar/briar-gtk/uploads/c7c585bd2133b1e37cd70487b7baf6a5/mobile-shell-convergence.png)
Source: https://gitlab.gnome.org/Teams/Design/os...This is what I had in mind for Briar GTK:
![mobile-shell-convergence](https://code.briarproject.org/briar/briar-gtk/uploads/c7c585bd2133b1e37cd70487b7baf6a5/mobile-shell-convergence.png)
Source: https://gitlab.gnome.org/Teams/Design/os-mockups/-/blob/f69fa82f8676582d900af8716522a27ddd77d87f/mobile-shell/mobile-shell-convergence.png
https://code.briarproject.org/briar/briar-gtk/-/issues/73
In particular I think we should at least show the latest message per chat.Desktop 1.0.0https://code.briarproject.org/briar/briar/-/issues/513Verify unverified contacts2023-02-07T08:56:41ZakwizgranVerify unverified contactsContacts who are added via introductions (or via long-distance transports, if we decide to support that) are considered "unverified" due to the possibility of a man-in-the-middle attack against the key exchange protocol. Contacts who are...Contacts who are added via introductions (or via long-distance transports, if we decide to support that) are considered "unverified" due to the possibility of a man-in-the-middle attack against the key exchange protocol. Contacts who are added face-to-face are considered "verified".
Design and implement a protocol and UI for verifying the identity of a previously unverified contact when the user meets the contact face-to-face.https://code.briarproject.org/briar/briar/-/issues/2378borders around threads in dark view theme have too little contrast2023-01-31T18:14:28ZRubenborders around threads in dark view theme have too little contrastIn dark mode it is hard to recognize the indentions in threads.
The borders around the messages should have more contrastIn dark mode it is hard to recognize the indentions in threads.
The borders around the messages should have more contrasthttps://code.briarproject.org/briar/briar-desktop/-/issues/475Visual bug with shadow in very long private messages2023-01-31T11:24:09ZMikolai GütschowVisual bug with shadow in very long private messagesHere encountered for a NoticeMessageItem:
![image](/uploads/277a6bcb5c23e69537cac25d7c678ebd/image.png)Here encountered for a NoticeMessageItem:
![image](/uploads/277a6bcb5c23e69537cac25d7c678ebd/image.png)https://code.briarproject.org/briar/briar-desktop/-/issues/462Reply TextField UI Proposal2023-01-16T19:34:03ZpaulReply TextField UI ProposalI wrote up a small UI change to the forum reply UI to make it (in my opinion) a bit cleaner:
Current:
![experimental-reply-ui-before](/uploads/cbd795875ae007495b86dcbec4cb1e6e/experimental-reply-ui-before.png)
Proposal:
![experimental-...I wrote up a small UI change to the forum reply UI to make it (in my opinion) a bit cleaner:
Current:
![experimental-reply-ui-before](/uploads/cbd795875ae007495b86dcbec4cb1e6e/experimental-reply-ui-before.png)
Proposal:
![experimental-reply-ui-after](/uploads/7ef4d40d81e829b50523d2792f29b62f/experimental-reply-ui-after.png)https://code.briarproject.org/briar/briar-desktop/-/issues/459Migrate to using compose built-in `Badge` for unread counters2023-01-13T22:17:18ZMikolai GütschowMigrate to using compose built-in `Badge` for unread counterssee https://developer.android.com/reference/kotlin/androidx/compose/material/package-summary#Badge(androidx.compose.ui.Modifier,androidx.compose.ui.graphics.Color,androidx.compose.ui.graphics.Color,kotlin.Function1)see https://developer.android.com/reference/kotlin/androidx/compose/material/package-summary#Badge(androidx.compose.ui.Modifier,androidx.compose.ui.graphics.Color,androidx.compose.ui.graphics.Color,kotlin.Function1)https://code.briarproject.org/briar/briar-desktop/-/issues/421Visual bug in forum with large author names2023-01-11T21:49:54ZMikolai GütschowVisual bug in forum with large author namesalthough the name is abbreviated (with ellipsis), the trust indicators are moved to the right:
![grafik](/uploads/258ace9883049e0d3364bc3f46ba8507/grafik.png)although the name is abbreviated (with ellipsis), the trust indicators are moved to the right:
![grafik](/uploads/258ace9883049e0d3364bc3f46ba8507/grafik.png)https://code.briarproject.org/briar/briar-desktop/-/issues/274Suggets users to put their password inside a password manager2023-01-09T21:39:56ZNicoSuggets users to put their password inside a password managerUsers might not know of password managers and we could therefore provide an incentive to start using them.Users might not know of password managers and we could therefore provide an incentive to start using them.Desktop 1.0.0https://code.briarproject.org/briar/briar-desktop/-/issues/236Use native windows for dialogs2023-01-09T21:39:56ZMikolai GütschowUse native windows for dialogse.g. for the AddContactDialog and AboutDialog, which do not strictly require to be modal.e.g. for the AddContactDialog and AboutDialog, which do not strictly require to be modal.Desktop 1.0.0https://code.briarproject.org/briar/briar-desktop/-/issues/44Support colorful Emojis 🤯️2023-01-09T21:29:50ZMikolai GütschowSupport colorful Emojis 🤯️Currently, only the black-and-white emojis are displayed (at least on Linux) and flags are only displayed as letters:
![image](/uploads/c2c6717f371fddab18d61f7d03f1395f/image.png)Currently, only the black-and-white emojis are displayed (at least on Linux) and flags are only displayed as letters:
![image](/uploads/c2c6717f371fddab18d61f7d03f1395f/image.png)Desktop 1.0.0