briar issueshttps://code.briarproject.org/groups/briar/-/issues2023-01-31T11:24:09Zhttps://code.briarproject.org/briar/briar-desktop/-/issues/475Visual bug with shadow in very long private messages2023-01-31T11:24:09ZMikolai GütschowVisual bug with shadow in very long private messagesHere encountered for a NoticeMessageItem:
![image](/uploads/277a6bcb5c23e69537cac25d7c678ebd/image.png)Here encountered for a NoticeMessageItem:
![image](/uploads/277a6bcb5c23e69537cac25d7c678ebd/image.png)https://code.briarproject.org/briar/briar-desktop/-/issues/462Reply TextField UI Proposal2023-01-16T19:34:03ZpaulReply TextField UI ProposalI wrote up a small UI change to the forum reply UI to make it (in my opinion) a bit cleaner:
Current:
![experimental-reply-ui-before](/uploads/cbd795875ae007495b86dcbec4cb1e6e/experimental-reply-ui-before.png)
Proposal:
![experimental-...I wrote up a small UI change to the forum reply UI to make it (in my opinion) a bit cleaner:
Current:
![experimental-reply-ui-before](/uploads/cbd795875ae007495b86dcbec4cb1e6e/experimental-reply-ui-before.png)
Proposal:
![experimental-reply-ui-after](/uploads/7ef4d40d81e829b50523d2792f29b62f/experimental-reply-ui-after.png)https://code.briarproject.org/briar/briar-desktop/-/issues/459Migrate to using compose built-in `Badge` for unread counters2023-01-13T22:17:18ZMikolai GütschowMigrate to using compose built-in `Badge` for unread counterssee https://developer.android.com/reference/kotlin/androidx/compose/material/package-summary#Badge(androidx.compose.ui.Modifier,androidx.compose.ui.graphics.Color,androidx.compose.ui.graphics.Color,kotlin.Function1)see https://developer.android.com/reference/kotlin/androidx/compose/material/package-summary#Badge(androidx.compose.ui.Modifier,androidx.compose.ui.graphics.Color,androidx.compose.ui.graphics.Color,kotlin.Function1)https://code.briarproject.org/briar/briar-desktop/-/issues/453Let user open forum from within request message (only) after accepting the in...2023-05-11T21:20:22ZMikolai GütschowLet user open forum from within request message (only) after accepting the invitationThis issue consists of two parts:
- Currently clicking on "Open" does not do anything (`ConversationRequestItem(onOpenRequestedShareable = {})` is the default)
- After declining an invitation, "Open" is also shown to the user which doesn...This issue consists of two parts:
- Currently clicking on "Open" does not do anything (`ConversationRequestItem(onOpenRequestedShareable = {})` is the default)
- After declining an invitation, "Open" is also shown to the user which doesn't make sense:
![image](/uploads/4c950cc496d574839b90d876ac1adf3a/image.png)https://code.briarproject.org/briar/briar-desktop/-/issues/423Use High Quality or Vector Icon2022-11-02T04:13:32ZpaulUse High Quality or Vector IconWhen using the task switcher on KDE, the Briar icon is noticeably lower quality than other icons.
![briar-desktop-icon](/uploads/b055b7998bcc63c5e9841a4581f06996/briar-desktop-icon.png)When using the task switcher on KDE, the Briar icon is noticeably lower quality than other icons.
![briar-desktop-icon](/uploads/b055b7998bcc63c5e9841a4581f06996/briar-desktop-icon.png)https://code.briarproject.org/briar/briar/-/issues/2381Image attachment button doesn't get enabled while conversation is open2022-10-31T12:35:50ZakwizgranImage attachment button doesn't get enabled while conversation is openWhen we receive a client versioning message informing us that a contact supports image attachments, the image attachment button in the conversation screen should be enabled. Currently this only happens after leaving and re-entering the c...When we receive a client versioning message informing us that a contact supports image attachments, the image attachment button in the conversation screen should be enabled. Currently this only happens after leaving and re-entering the conversation screen.https://code.briarproject.org/briar/briar/-/issues/2378borders around threads in dark view theme have too little contrast2023-01-31T18:14:28ZRubenborders around threads in dark view theme have too little contrastIn dark mode it is hard to recognize the indentions in threads.
The borders around the messages should have more contrastIn dark mode it is hard to recognize the indentions in threads.
The borders around the messages should have more contrasthttps://code.briarproject.org/briar/briar-desktop/-/issues/421Visual bug in forum with large author names2023-01-11T21:49:54ZMikolai GütschowVisual bug in forum with large author namesalthough the name is abbreviated (with ellipsis), the trust indicators are moved to the right:
![grafik](/uploads/258ace9883049e0d3364bc3f46ba8507/grafik.png)although the name is abbreviated (with ellipsis), the trust indicators are moved to the right:
![grafik](/uploads/258ace9883049e0d3364bc3f46ba8507/grafik.png)https://code.briarproject.org/briar/briar-desktop/-/issues/418When selecting forum post at the bottom, it gets hidden by reply box2022-10-18T12:33:57ZTorsten GroteWhen selecting forum post at the bottom, it gets hidden by reply boxHiding the selected forum post isn't ideal. Maybe we can find a solution here like scrolling the up in this case to keep the item visible.Hiding the selected forum post isn't ideal. Maybe we can find a solution here like scrolling the up in this case to keep the item visible.https://code.briarproject.org/briar/briar-desktop/-/issues/382.desktop file for jar distribution2022-09-21T21:56:19ZMikolai Gütschow.desktop file for jar distributionWhile working on !214
@ialokim started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/214#note_70289): (+9 comments)
> one thing worth mentioning is that the Briar logo is not shown in this test syst...While working on !214
@ialokim started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/214#note_70289): (+9 comments)
> one thing worth mentioning is that the Briar logo is not shown in this test system since no `.desktop` file is installed when directly running the jar (as opposed to an installation via deb (and flatpack?)). We could overcome this by setting an image on the notification itself, but I would have to look into it again. Also, it might be nice to have the option of creating the `.desktop` file anyhow, to be able to find it in the start menu for example. Not sure how this is usually handled with Java programs distributed as jar files...
We should probably check on (first or all?) launch if a `.desktop` file is present on the system and otherwise offer the user to create one.Desktop 1.0.0https://code.briarproject.org/briar/briar-desktop/-/issues/371Use constants as (screen) padding values throughout the code base2022-08-17T07:59:49ZMikolai GütschowUse constants as (screen) padding values throughout the code basesimilar to "dimens.xml" for Android
See [here](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/221#note_69460)similar to "dimens.xml" for Android
See [here](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/221#note_69460)https://code.briarproject.org/briar/briar-desktop/-/issues/366Improve screen-reader support2023-04-17T22:04:24ZMikolai GütschowImprove screen-reader supportTargeting issues raised in #341 and as part of #84.
- Heading structure: > not supported by upstream Compose (https://github.com/JetBrains/compose-jb/issues/2119)
- [ ] "Welcome to Briar" on login and main screen (no chats)
- [ ] co...Targeting issues raised in #341 and as part of #84.
- Heading structure: > not supported by upstream Compose (https://github.com/JetBrains/compose-jb/issues/2119)
- [ ] "Welcome to Briar" on login and main screen (no chats)
- [ ] contact name in chat screen
- [ ] "Settings" on SettingsScreen
- Image(Button) contentDescription:
- [ ] Briar logo on login > only of decorative nature, automatically skipped over by VoiceOver
- [x] back and info button on login > !223 and info button already "About Briar Desktop" on `main`
- [x] menu button in chat screen > already "Show Contact Menu" on `main`
- [x] add contact button without chats > fixed on `main`
- [x] attachment button in chat screen > fixed on `main`
- Missing context:
- [x] show password buttons on login/change password > automatically grouped on macOS/VoiceOver
- [x] labels for text fields (registration screen) > !225
- Missing list grouping:
- [x] contact list > !218
- [x] settings as list > !224
- Missing state information (expanded/collapsed): Dropdowns/Pop-Ups not supported by Compose https://github.com/JetBrains/compose-jb/issues/2185
- [ ] menu button in chat screen
- [ ] theme/language settings, also dynamic changes
- Misc:
- [ ] error message on login (not read out loud) > upstream bug: https://github.com/JetBrains/compose-jb/issues/2277
- [x] about dialog (no exit button, table not marked as such, email is not link) > !221
- [x] message count/online status in contact list > !218
- [x] "keyboard trap" in compose message text field (tab button is stuck in text field) > !222
- [ ] Missing landmarks on MainScreen to convey structure to screen-reader user > not supported by Compose
- [x] Keyboard focus does not go to close button on add contact dialog > probably missing OS-functionality on Ubuntu/Orca which is anyhow not supported, confirmed to work on macOS with VoiceOver as expected
- [ ] Dropdown not marked as such (settings) > Dropdowns/Pop-Ups not supported by Compose https://github.com/JetBrains/compose-jb/issues/2185
- [x] Briar link name/label on Add Contact dialog > !230
- [x] Add attachment button not keyboard-focusable on macOS > !222Mikolai GütschowMikolai Gütschowhttps://code.briarproject.org/briar/briar-desktop/-/issues/364Revise usage of disabled buttons2022-09-27T08:10:08ZMikolai GütschowRevise usage of disabled buttonsas a follow-up of https://code.briarproject.org/briar/briar-desktop/-/issues/343#note_67101
TD;LR: We should reconsider if we really need disabled buttons as they are bad practice UX-wise and especially for accessibility.as a follow-up of https://code.briarproject.org/briar/briar-desktop/-/issues/343#note_67101
TD;LR: We should reconsider if we really need disabled buttons as they are bad practice UX-wise and especially for accessibility.https://code.briarproject.org/briar/briar/-/issues/2322When Tor not active, adding a RSS feed fails with unclear error message2022-10-11T12:02:07ZAminda SuomalainenWhen Tor not active, adding a RSS feed fails with unclear error messageIf the option to connect to internet only when charging is set, feeds cannot be added or there will be an error message (which content I don't have at hand, but doesn't clearly tell what the issue is) and suggests trying again, which wil...If the option to connect to internet only when charging is set, feeds cannot be added or there will be an error message (which content I don't have at hand, but doesn't clearly tell what the issue is) and suggests trying again, which will result to the same problem.
The solution is to either uncheck the option or put the phone to charge and it will be able to add feeds without issues.
I think https://code.briarproject.org/briar/briar/-/issues/2247 would be a potential solution to this, but having the error message say that connecting to internet or unchecking the box is required.
Briar 1.4.7 (more device details in #2321)https://code.briarproject.org/briar/briar-desktop/-/issues/359Auto-generate screenshots with reasonable text2022-10-25T10:30:06ZMikolai GütschowAuto-generate screenshots with reasonable textSomething comparable to the screenshot currently shown on https://briarproject.org/download-briar-desktop/ or the [Android screenshots on Google Play](https://play.google.com/store/apps/details?id=org.briarproject.briar.android).
For th...Something comparable to the screenshot currently shown on https://briarproject.org/download-briar-desktop/ or the [Android screenshots on Google Play](https://play.google.com/store/apps/details?id=org.briarproject.briar.android).
For this we need (in a separate build configuration):
- some nice conversations, also including special "messages" like introduction requests (can be added to our deterministic test data)
- ability to fake some contact connection statuses in code (show contacts as connected for screenshot)
- usage of compose built-in snapshot feature (see https://dev.to/pchmielowski/automate-taking-screenshots-of-android-app-with-jetpack-compose-2950 as reference)https://code.briarproject.org/briar/briar-desktop/-/issues/349FAB in chat window not shown if older message arrives out-of-order2023-08-25T13:33:35ZMikolai GütschowFAB in chat window not shown if older message arrives out-of-orderThis issue was encountered while testing for release 0.2.1 #346. We would need to have a way to reproduce this (e.g. by sending some message from a test contact after a given time in TestData).
Nevertheless, the message counter in the c...This issue was encountered while testing for release 0.2.1 #346. We would need to have a way to reproduce this (e.g. by sending some message from a test contact after a given time in TestData).
Nevertheless, the message counter in the contact list was updated (directly after?) receiving the out-of-order message and after changing to another chat and navigating back to the chat with the new message, the scrollview was automatically scrolled to the new message.Desktop 0.7.0https://code.briarproject.org/briar/briar-desktop/-/issues/344Hidden expiration banner is displayed again when changing language/theme2022-05-03T15:48:13ZMikolai GütschowHidden expiration banner is displayed again when changing language/themeSince we are invalidating the whole screen, the hidden banner state is lost.Since we are invalidating the whole screen, the hidden banner state is lost.https://code.briarproject.org/briar/briar-desktop/-/issues/342Briar Desktop Usability Audit2022-05-03T14:59:57ZElio Qoshielio@ura.designBriar Desktop Usability AuditWe worked with Kay from Blickwinkel Digital, an external UX expert group who tested Briar Desktop as part of their Usability Audit according to ISO 9241-110.They have been immensely helpful in identifying common usability issues on the B...We worked with Kay from Blickwinkel Digital, an external UX expert group who tested Briar Desktop as part of their Usability Audit according to ISO 9241-110.They have been immensely helpful in identifying common usability issues on the Briar Desktop app. As someone without prior experiences with Briar, their insights were refreshing and much needed after we ourselves have worked with Briar over 4 years. As part of this collaboration we produced a PDF presentation including over 17 UX issues identified by Blickwinkel (including commentary from our side for further context) as well additional 8 issues identified by our Lead UX Researcher, Renata according to the UX Heuristics framework by Nielsen Norman Group.
![image](/uploads/4e87ec2fe74911cb7fd63a8ae77d58fb/image.png)
In a similar manner to the accessibility audit, the usability audit includes an issue description, an annotated screenshot, a recommendation, the severity as well as the criteria/heuristics being violated in this case.
Majority of the review has been conducted on a Mac M1 (with apparently an older version of Briar Desktop), though most things apply on both versions.
Presentation:
https://docs.google.com/presentation/d/1tDmSPzW26luF3ySaGUwbNelhvkRwXAFJ/edit?usp=sharing&ouid=100104676494073512080&rtpof=true&sd=true
[Briar_Desktop_Usability_Audit.pdf](/uploads/78097e2dcba23fe82e2fd0384041ad14/Briar_Desktop_Usability_Audit.pdf)Desktop 1.0.0SebastianSebastianhttps://code.briarproject.org/briar/briar-desktop/-/issues/332Update Conversation Search to Material Spec2023-08-25T13:33:35ZpaulUpdate Conversation Search to Material SpecI found https://material.io/design/navigation/search.html#expandable-search which covers how we likely should handle the contact list search bar in a "material way". If this looks good to everyone, I can try and implement this change.I found https://material.io/design/navigation/search.html#expandable-search which covers how we likely should handle the contact list search bar in a "material way". If this looks good to everyone, I can try and implement this change.Desktop 0.7.0https://code.briarproject.org/briar/briar-desktop/-/issues/330ContextMenu Typography2022-09-23T04:16:24ZpaulContextMenu TypographyWhen right-clicking on a message, the contextmenu that opens doesn't use the updated Roboto font. Easiest way to see this is the way the 'C' glyph is rendered.When right-clicking on a message, the contextmenu that opens doesn't use the updated Roboto font. Easiest way to see this is the way the 'C' glyph is rendered.