briar issueshttps://code.briarproject.org/groups/briar/-/issues2022-09-21T21:56:19Zhttps://code.briarproject.org/briar/briar-desktop/-/issues/382.desktop file for jar distribution2022-09-21T21:56:19ZMikolai Gütschow.desktop file for jar distributionWhile working on !214
@ialokim started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/214#note_70289): (+9 comments)
> one thing worth mentioning is that the Briar logo is not shown in this test syst...While working on !214
@ialokim started a [discussion](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/214#note_70289): (+9 comments)
> one thing worth mentioning is that the Briar logo is not shown in this test system since no `.desktop` file is installed when directly running the jar (as opposed to an installation via deb (and flatpack?)). We could overcome this by setting an image on the notification itself, but I would have to look into it again. Also, it might be nice to have the option of creating the `.desktop` file anyhow, to be able to find it in the start menu for example. Not sure how this is usually handled with Java programs distributed as jar files...
We should probably check on (first or all?) launch if a `.desktop` file is present on the system and otherwise offer the user to create one.Desktop 1.0.0https://code.briarproject.org/briar/briar-desktop/-/issues/379Data dir is resolved relative to submodule directory when run using `./gradle...2022-09-06T06:56:14ZSebastianData dir is resolved relative to submodule directory when run using `./gradlew run`When I run briar from the git repo using `./gradlew run --args="--data-dir briardata"` then I would expect `briardata` to be in the current working directory where I'm currently located with my shell. However, apparently the current work...When I run briar from the git repo using `./gradlew run --args="--data-dir briardata"` then I would expect `briardata` to be in the current working directory where I'm currently located with my shell. However, apparently the current working directory for the process is the `briar-desktop` subdirectory so that the data dir created/used really is `briar-desktop/briardata`.https://code.briarproject.org/briar/briar-desktop/-/issues/375High CPU load due to text input fields2023-06-01T07:17:07ZVivienHigh CPU load due to text input fieldsWhile a blinking cursor is displayed in any text input field, the CPU load of the Java process increases by about 10%. This leads to a temperature increase of 3°C on this (old) laptop during the login screen, but an increase of up to 15°...While a blinking cursor is displayed in any text input field, the CPU load of the Java process increases by about 10%. This leads to a temperature increase of 3°C on this (old) laptop during the login screen, but an increase of up to 15°C while typing a message. Nothing relevant appears in the log output.
Steps to reproduce:
1. java -jar briar-desktop.jar
2. Keep the window in the foreground so that any cursor blinks.
```
Briar Desktop
Version 0.2.1-nightly
Git hash 51607c81039fc360301701e7c9d94efd9d528020
Commit time 2022-08-28 19:29:32
System Information
OS Name Debian GNU/Linux
OS Version 11.4 (bullseye)
Architecture amd64 (x86_64)
Kernel Release 5.18.0-0.deb11.3-amd64
Kernel Version #1 SMP PREEMPT_DYNAMIC Debian 5.18.14-1~bpo11+1 (2022-07-28)
Software
openjdk-17-jre 17.0.4+8-1~deb11u1
xfce4 4.16
xfwm4 4.16.1-1
```https://code.briarproject.org/briar/briar/-/issues/2362Timestamps in contact list (and maybe other lists) aren't updated2022-08-30T13:17:55ZakwizgranTimestamps in contact list (and maybe other lists) aren't updatedTimestamps in the contact list aren't updated if the screen timeout is set to less than 1 minute, as the refresher task is cancelled when the screen turns off.
Other BriarRecyclerViews may be affected if they don't reload their data or ...Timestamps in the contact list aren't updated if the screen timeout is set to less than 1 minute, as the refresher task is cancelled when the screen turns off.
Other BriarRecyclerViews may be affected if they don't reload their data or redraw their lists when started/resumed.https://code.briarproject.org/briar/briar/-/issues/2361Walkie-talkie feature2022-10-26T19:35:27ZVladislavWalkie-talkie featureFeatures:
1. Possibility to record and send short audio message (~10 sec), to a person, group or blog.
2. Hands off possibility. (Voice detection for recording an sending & auto play for incoming audio messages)
3. Push-to-talk possibili...Features:
1. Possibility to record and send short audio message (~10 sec), to a person, group or blog.
2. Hands off possibility. (Voice detection for recording an sending & auto play for incoming audio messages)
3. Push-to-talk possibility. (record and send message while holding on-display button or volume-up button)
Use case:
Communicate while driving, playing, workout.
Tips:
While recording is performed in app, we could use low quality audio format (8-16 kHz), just for voice recording.https://code.briarproject.org/briar/dont-kill-me-lib/-/issues/3Huawei app launch intent doesn't work on P40 Lite 5G2023-08-24T14:46:52ZakwizgranHuawei app launch intent doesn't work on P40 Lite 5GOn the Huawei P40 Lite 5G (Android 10, EMUI 12.0.0), `HuaweiUtils.appLaunchNeedsToBeShown()` returns `true` but none of the intents in `huaweiAppLaunchIntents` can be used to open an activity.On the Huawei P40 Lite 5G (Android 10, EMUI 12.0.0), `HuaweiUtils.appLaunchNeedsToBeShown()` returns `true` but none of the intents in `huaweiAppLaunchIntents` can be used to open an activity.https://code.briarproject.org/briar/briar-desktop/-/issues/373TestLanTcpPlugin that supports BRP2022-09-24T21:38:08ZSebastianTestLanTcpPlugin that supports BRPWhen running two or more connected instances of the application for interactive testing, it is a bit annoying that it can take very long for the contacts to be actually connected and able to exchange messages. I had thought enabling the ...When running two or more connected instances of the application for interactive testing, it is a bit annoying that it can take very long for the contacts to be actually connected and able to exchange messages. I had thought enabling the LAN plugin would help, but since the LAN plugin does not support BRP, adding contacts at a distance does not work via that plugin. Now I had the idea that we might add a new plugin TestLanTcpPlugin that allows rendezvous via LAN and would only be used in test setups such as this.
I'm wondering how much effort this would be.
I can see `supportsRendezvous()` probably needs to return `true` and then `createRendezvousEndpoint()` would need to be implemented. Not sure how much of `TorPlugin`s implement could be reused there. @akwizgran do you an assessment how much trouble this all would be?https://code.briarproject.org/briar/briar/-/issues/2359Reduce traffic activity by sending BSP VERSIONS Records less often2023-02-07T15:54:53ZThomasReduce traffic activity by sending BSP VERSIONS Records less oftenI am working on a PoC for a LoRa Transport. Even with all messages and acknowledges being exchanged, I see Traffic every X seconds. From a BSP perspective this is being sent: `00 04 00 01 00`
Its basically saying: This is protocol versio...I am working on a PoC for a LoRa Transport. Even with all messages and acknowledges being exchanged, I see Traffic every X seconds. From a BSP perspective this is being sent: `00 04 00 01 00`
Its basically saying: This is protocol version 0, I am supporting only protocol version 0.
I get this same message every X seconds. Yes, the traffic is encrypted (randomized), still I think this makes the traffic easier to categorize using timing-attacks and it takes bandwidth.
I argue this should only be sent:
- during contact exchange
- if it changed and the other contact hasn't acknowledged the change or sent BSP Frames themselves with the new version
Ideally the old Version is still valid and the change doesn't have to be propagated by creating new Streams - the client can transmit it once before it sends another BSP Packet.
This mainly affects Simplex Connections (https://code.briarproject.org/briar/briar/-/blob/master/bramble-core/src/main/java/org/briarproject/bramble/sync/SimplexOutgoingSession.java#L95). It could also be changes on Duplex Connections (https://code.briarproject.org/briar/briar/-/blob/master/bramble-core/src/main/java/org/briarproject/bramble/sync/DuplexOutgoingSession.java#L136) but I don't know the real-life impact there since it won't be regularly re-sent on established connections.
My workaround for the PoC will be to just comment-out this specific line of code.https://code.briarproject.org/briar/briar-desktop/-/issues/372Tooltip does not work on all icon buttons (hidpi issue?)2022-08-18T21:00:24ZSebastianTooltip does not work on all icon buttons (hidpi issue?)While testing !221 I noticed that on my hidpi Linux device, the tooltips for the icon buttons don't work there, while they do work on a regular machine. Maybe it has to do with the high density resolution, no idea, but that is the only t...While testing !221 I noticed that on my hidpi Linux device, the tooltips for the icon buttons don't work there, while they do work on a regular machine. Maybe it has to do with the high density resolution, no idea, but that is the only thing I know is different on that machine.https://code.briarproject.org/briar/briar-desktop/-/issues/371Use constants as (screen) padding values throughout the code base2022-08-17T07:59:49ZMikolai GütschowUse constants as (screen) padding values throughout the code basesimilar to "dimens.xml" for Android
See [here](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/221#note_69460)similar to "dimens.xml" for Android
See [here](https://code.briarproject.org/briar/briar-desktop/-/merge_requests/221#note_69460)https://code.briarproject.org/briar/briar-mailbox/-/issues/154Last connection on the mailbox status screen not updating as minutes pass by2023-08-28T16:00:11ZIvanaLast connection on the mailbox status screen not updating as minutes pass bySteps to reproduce
- do not keep activities = ON
- on any two device where Briar and Mailbox are linked check the values for last connection.
- this can be after initial linking, or after the screens have fallen asleep and been woken ...Steps to reproduce
- do not keep activities = ON
- on any two device where Briar and Mailbox are linked check the values for last connection.
- this can be after initial linking, or after the screens have fallen asleep and been woken up, or after the link Check Connection on Briar is tapped
- What happens is that initially both values are set to 'now' and the Briar device then updates its 'last connection' value as minutes roll by, but the mailbox device does not.
- Here are the photos to illustrate
- Whilst I was typing this and taking the photos, the difference has become 7 mins...
- after the mailbox screen falls asleep and is reactivate by the user - the value is reset to the correct value - ie the same as on the Briar app
- Andanother microscoping inconsistency with briar screens - on mailbox Last connection says 1 min. ago, on Briar it says 1 min ago. Ie in one place we have a full stop after the short 'min', and in the other place we do not. This really is splitting hairs, but I thought as we will be looking into it anyway, we may as well make it consistent. It should take only a milisecond to do it.
![20220808_145527](/uploads/5d30834bc307c2391773262381aaee21/20220808_145527.jpg)
![20220808_145620](/uploads/030d1fd2ad075b07f3fbef23471a3564/20220808_145620.jpg)
![20220808_145714](/uploads/610ee7753f5ae0066fa0694ddcd70742/20220808_145714.jpg)https://code.briarproject.org/briar/briar/-/issues/2353High data (traffic) usage2022-08-15T13:02:20ZArcibald RajsHigh data (traffic) usageHi all.
Briar is awesome app... almost awesome.
There is no server, but as I can see - every installed instance become some kind of server / transport node. Right?
I have 3 - 4 contacts. There are situations where I don't communicat...Hi all.
Briar is awesome app... almost awesome.
There is no server, but as I can see - every installed instance become some kind of server / transport node. Right?
I have 3 - 4 contacts. There are situations where I don't communicate with them, but Briar swallow almost 2 GB of data in background in less then 24h!!! I try to disable background data in app settings, but that don't help me.
This can be a really big problem if somebody is in roaming or have limited package, as me and my friends.
Anybody have similiar experience? Any suggestion how to limit this consumption?
Regards.https://code.briarproject.org/briar/briar-mailbox/-/issues/149Send feedback and crash reports via Tor2023-08-28T16:00:11ZakwizgranSend feedback and crash reports via TorSubtask of #82Subtask of #82Mailboxhttps://code.briarproject.org/briar/briar-mailbox/-/issues/148UI for sending feedback and crash reports2023-08-28T16:00:09ZakwizgranUI for sending feedback and crash reportsSubtask of #82.Subtask of #82.Mailboxhttps://code.briarproject.org/briar/briar-mailbox/-/issues/147Research accessibility testing2023-08-28T16:00:09ZakwizgranResearch accessibility testingFind out what would be involved in testing the Mailbox app for accessibility, and what resources are available to help with this testing.Find out what would be involved in testing the Mailbox app for accessibility, and what resources are available to help with this testing.https://code.briarproject.org/briar/briar/-/issues/2350Set a more visible link to version Changes2022-07-22T21:53:33ZJohn MaverickSet a more visible link to version ChangesEvery time I try to see what's new with the latest release I have to play fish.
It's terribly difficult to find the changes made in the last version.
Please place a link from the landing page - maybe in the new version announcement tex...Every time I try to see what's new with the latest release I have to play fish.
It's terribly difficult to find the changes made in the last version.
Please place a link from the landing page - maybe in the new version announcement text - to the changes.
In short, place a link on the main page to:
https://code.briarproject.org/briar/briar/-/wikis/changeloghttps://code.briarproject.org/briar/briar/-/issues/2349SecurityException when setting clipboard contents2022-07-13T15:05:41ZakwizgranSecurityException when setting clipboard contents* Android version: 10
* Phone model: Realme RMX2020 (RMX2020RU)
* Briar version: 1.4.9 (592daf9)
Stacktrace:
```
java.lang.SecurityException: com.miHoYo.GenshinImpact from uid 10622 not allowed to perform READ_CLIPBOARD
at andro...* Android version: 10
* Phone model: Realme RMX2020 (RMX2020RU)
* Briar version: 1.4.9 (592daf9)
Stacktrace:
```
java.lang.SecurityException: com.miHoYo.GenshinImpact from uid 10622 not allowed to perform READ_CLIPBOARD
at android.os.Parcel.createException(Parcel.java:2087)
at android.os.Parcel.readException(Parcel.java:2055)
at android.os.Parcel.readException(Parcel.java:2003)
at android.content.IClipboard$Stub$Proxy.setPrimaryClip(IClipboard.java:293)
at android.content.ClipboardManager.setPrimaryClip(ClipboardManager.java:106)
at org.briarproject.briar.android.contact.add.remote.LinkExchangeFragment.lambda$onHandshakeLinkLoaded$1(LinkExchangeFragment.java:130)
at org.briarproject.briar.android.contact.add.remote.LinkExchangeFragment.$r8$lambda$7puQg0Zpj-kqg_hU0AyYfKEiXJI(Unknown Source:0)
at org.briarproject.briar.android.contact.add.remote.LinkExchangeFragment$$ExternalSyntheticLambda2.onClick(Unknown Source:4)
at android.view.View.performClick(View.java:7254)
at android.view.View.performClickInternal(View.java:7212)
at android.view.View.access$3800(View.java:828)
at android.view.View$PerformClick.run(View.java:27888)
at android.os.Handler.handleCallback(Handler.java:883)
at android.os.Handler.dispatchMessage(Handler.java:100)
at android.os.Looper.loop(Looper.java:227)
at android.app.ActivityThread.main(ActivityThread.java:7822)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1026)
Caused by: android.os.RemoteException: Remote stack trace:
at android.app.AppOpsManager.noteOp(AppOpsManager.java:5344)
at com.android.server.clipboard.ClipboardService.clipboardAccessAllowed(ClipboardService.java:759)
at com.android.server.clipboard.ClipboardService.setPrimaryClipInternal(ClipboardService.java:599)
at com.android.server.clipboard.ClipboardService.setPrimaryClipInternal(ClipboardService.java:530)
at com.android.server.clipboard.ClipboardService$ClipboardImpl.setPrimaryClip(ClipboardService.java:369)
```
Last lines of log:
```
07-10 20:03:40.221 W/BriarService: Trim memory: running critically low
07-10 20:03:40.222 I/BriarService: Clearing Glide cache
07-10 20:03:40.459 I/BaseActivity: Destroying NavDrawerActivity
07-10 20:03:45.769 I/BriarService: Trim memory: running low
07-10 20:03:45.769 I/BriarService: Clearing Glide cache
07-10 20:03:49.532 I/BaseActivity: Creating SplashScreenActivity
07-10 20:03:49.608 I/BaseActivity: Creating NavDrawerActivity
07-10 20:03:49.670 I/BaseActivity: Starting NavDrawerActivity
07-10 20:03:49.675 I/BaseActivity: Resuming NavDrawerActivity
07-10 20:03:49.840 I/BaseActivity: Destroying SplashScreenActivity
07-10 20:03:52.103 I/BaseActivity: Pausing NavDrawerActivity
07-10 20:03:52.128 I/BaseActivity: Creating AddContactActivity
07-10 20:03:52.183 I/BaseActivity: Starting AddContactActivity
07-10 20:03:52.184 I/BaseActivity: Resuming AddContactActivity
07-10 20:03:52.702 I/BaseActivity: Stopping NavDrawerActivity
```
I don't understand why Briar would receive a SecurityException when setting the primary clip, if a different app (Genshin Impact) doesn't have permission to read the clipboard. Still, perhaps we should catch this exception rather than crashing.https://code.briarproject.org/briar/briar/-/issues/2345NPE when unlocking app2022-06-29T10:44:12ZakwizgranNPE when unlocking app* Android version: 9
* Phone model: Huawei ANE-LX1
* Briar version: 1.4.8 (6e61827)
Stacktrace:
```
java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=11, result=0, data=null} to activity {org.briarprojec...* Android version: 9
* Phone model: Huawei ANE-LX1
* Briar version: 1.4.8 (6e61827)
Stacktrace:
```
java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=11, result=0, data=null} to activity {org.briarproject.briar.android/org.briarproject.briar.android.navdrawer.NavDrawerActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'int com.android.server.fingerprint.ClientMonitor.stop(boolean)' on a null object reference
at android.app.ActivityThread.deliverResults(ActivityThread.java:5078)
at android.app.ActivityThread.handleSendResult(ActivityThread.java:5120)
at android.app.servertransaction.ActivityResultItem.execute(ActivityResultItem.java:49)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2199)
at android.os.Handler.dispatchMessage(Handler.java:112)
at android.os.Looper.loop(Looper.java:216)
at android.app.ActivityThread.main(ActivityThread.java:7625)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:524)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:987)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'int com.android.server.fingerprint.ClientMonitor.stop(boolean)' on a null object reference
at android.os.Parcel.createException(Parcel.java:1965)
at android.os.Parcel.readException(Parcel.java:1927)
at android.os.Parcel.readException(Parcel.java:1877)
at android.app.IActivityManager$Stub$Proxy.finishActivity(IActivityManager.java:3774)
at android.app.Activity.finish(Activity.java:5905)
at android.app.Activity.finish(Activity.java:5929)
at android.app.Activity.finishAfterTransition(Activity.java:5990)
at androidx.core.app.ActivityCompat.finishAfterTransition(ActivityCompat.java:305)
at androidx.fragment.app.FragmentActivity.supportFinishAfterTransition(FragmentActivity.java:178)
at org.briarproject.briar.android.activity.BriarActivity.onActivityResult(BriarActivity.java:91)
at org.briarproject.briar.android.navdrawer.NavDrawerActivity.onActivityResult(NavDrawerActivity.java:223)
at android.app.Activity.dispatchActivityResult(Activity.java:7797)
at android.app.ActivityThread.deliverResults(ActivityThread.java:5071)
... 11 more
```
Edited log:
```
06-20 12:03:16.624 I/BriarService: Trim memory: running moderately low
06-20 12:03:16.624 I/BriarService: Clearing Glide cache
06-20 12:03:17.244 I/AndroidNetworkManager: Received broadcast android.intent.action.SCREEN_ON
06-20 12:03:28.006 I/AndroidNetworkManager: Received broadcast android.intent.action.SCREEN_OFF
06-20 12:07:38.666 I/BaseActivity: Starting NavDrawerActivity
06-20 12:07:38.671 I/BaseActivity: Resuming NavDrawerActivity
06-20 12:07:38.672 I/BriarActivity: Locked, launching UnlockActivity
06-20 12:07:38.799 I/BaseActivity: Pausing NavDrawerActivity
06-20 12:07:38.840 I/BaseActivity: Creating UnlockActivity
06-20 12:07:38.872 I/BaseActivity: Starting UnlockActivity
06-20 12:07:38.874 I/BaseActivity: Resuming UnlockActivity
06-20 12:07:39.133 I/BaseActivity: Stopping NavDrawerActivity
06-20 12:07:39.655 I/AndroidNetworkManager: Received broadcast android.intent.action.SCREEN_ON
06-20 12:07:39.793 I/BaseActivity: Pausing UnlockActivity
```
The SCREEN_ON broadcast seems to have been received nearly a second after NavDrawerActivity was started and replaced by UnlockActivity. The broadcasts are sometimes delivered late so I'm not sure if that's relevant.
The device has `"android.hardware.fingerprint" : true`.https://code.briarproject.org/briar/briar-desktop/-/issues/369Deleting messages doesn't update last message time and position in contact li...2022-09-05T09:49:53ZSebastianDeleting messages doesn't update last message time and position in contact list (instantly)When I delete a single or all message within a conversation, nothing happens in the last message section of the contact card in the contact list.
When I switch to settings and back to the conversation list:
* After deleting all messages...When I delete a single or all message within a conversation, nothing happens in the last message section of the contact card in the contact list.
When I switch to settings and back to the conversation list:
* After deleting all messages, I get "No messages." and the contact list moved to the top of the list.
* After deleting a single message, I see the time of deletion of the message (i.e. now). Also the contact moves to the top of the list.
I think in both cases the update should ideally also happen instantly when deleting the messages.https://code.briarproject.org/briar/briar/-/issues/2341Follow-up from "Add Tor plugin for Windows": look into using Tor's --service ...2022-06-22T08:20:50ZSebastianFollow-up from "Add Tor plugin for Windows": look into using Tor's --service optionThe following discussion from !1666 should be addressed:
- [ ] @sebkur started a [discussion](https://code.briarproject.org/briar/briar/-/merge_requests/1666#note_68084): (+1 comment)
> Cool that this works like this anyway.
>...The following discussion from !1666 should be addressed:
- [ ] @sebkur started a [discussion](https://code.briarproject.org/briar/briar/-/merge_requests/1666#note_68084): (+1 comment)
> Cool that this works like this anyway.
>
> The man page says:
>
> > RunAsDaemon 0|1
> >
> > If 1, Tor forks and daemonizes to the background. This option has no effect on Windows; instead you should use the --service command-line option. Can not be changed while tor is running. (Default: 0)
>
> Did you consider using the `--service` option?SebastianSebastian