briar issueshttps://code.briarproject.org/groups/briar/-/issues2018-05-24T09:59:19Zhttps://code.briarproject.org/briar/briar/-/issues/986Logging wrapper2018-05-24T09:59:19ZakwizgranLogging wrapperCreate a wrapper around the system logger that will allow us to log information without exposing it to the system logs, and read that information back in the case of a crash without requiring the READ_LOGS permission.Create a wrapper around the system logger that will allow us to log information without exposing it to the system logs, and read that information back in the case of a crash without requiring the READ_LOGS permission.Android 1.1akwizgranakwizgranhttps://code.briarproject.org/briar/website/-/issues/1Use Static Site Generator2019-08-30T13:59:31ZTorsten GroteUse Static Site GeneratorI recommend using a static site generator for the page to reduce duplicated code. When changing something in the header and footer, you shouldn't need to edit all pages.I recommend using a static site generator for the page to reduce duplicated code. When changing something in the header and footer, you shouldn't need to edit all pages.https://code.briarproject.org/briar/briar/-/issues/978Add preference for using tor only when having power2019-02-21T10:34:01ZGreg TroxelAdd preference for using tor only when having power(Sorry if this is a dup; I searched but am not confident.)
I just built and installed Briar after being absent for a while. I see there's a preference for using tor never, on wifi, and on cellular. That's great for some, but doesn't a...(Sorry if this is a dup; I searched but am not confident.)
I just built and installed Briar after being absent for a while. I see there's a preference for using tor never, on wifi, and on cellular. That's great for some, but doesn't address my problem. I realize there is tension with UX and complicated config, but given that having a HS is very very costly power wise, and outbound tor is somewhat costly, I'd like to see a config for "Use Tor when not charging" that is "no, outbound only, outbound and inbound". This would probably let me start running briar, and I suspect would let others do so as well.Android 1.1Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/976Dark theme2019-04-25T09:18:03ZakwizgranDark themeA user asked for a dark theme.A user asked for a dark theme.Android 1.1Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/971Detect and report Tor crashes2022-07-20T10:38:39ZakwizgranDetect and report Tor crasheshttps://code.briarproject.org/briar/briar/-/issues/970Settings title cut/ellipsized2017-07-03T14:20:23ZJulian DehmSettings title cut/ellipsizedThe german translations for the notification settings exceed the display size on some phones.
<img src="https://code.briarproject.org/goapunk/briar/raw/fileStorage/screens/Settings-translation.png" width="256">
We should change the ti...The german translations for the notification settings exceed the display size on some phones.
<img src="https://code.briarproject.org/goapunk/briar/raw/fileStorage/screens/Settings-translation.png" width="256">
We should change the title to something more concise and provide an explanation in the summary field.Julian DehmJulian Dehmhttps://code.briarproject.org/briar/briar/-/issues/969Galaxy S3 can not send message in private conversation2017-07-03T15:42:17ZTorsten GroteGalaxy S3 can not send message in private conversationDuring a recent user test, one of the testers was unable to send private messages. Clicking the send button did just not work. The workaround was to close the softkeyboard. Then, the send button worked.
Maybe related to our tap jacking ...During a recent user test, one of the testers was unable to send private messages. Clicking the send button did just not work. The workaround was to close the softkeyboard. Then, the send button worked.
Maybe related to our tap jacking protection?https://code.briarproject.org/briar/briar/-/issues/967Tap target didn't fully expand2018-06-11T11:29:59ZakwizgranTap target didn't fully expandThe tap target failed to expand to its full size, causing the text to be overlayed on other elements. This happened on a Galaxy Nexus running Android 6.0.1/LineageOS 13.0.The tap target failed to expand to its full size, causing the text to be overlayed on other elements. This happened on a Galaxy Nexus running Android 6.0.1/LineageOS 13.0.https://code.briarproject.org/briar/briar/-/issues/961Minor UX issue with reblogs and contact messaging2019-02-27T10:25:16ZErnir ErlingssonMinor UX issue with reblogs and contact messagingMargins are missing in the bottom area between the screen border and between the input area and button. Button also seems wider than the input area which is probably missing a shadow due to elevation
See screenshots:
![Screenshot_2...Margins are missing in the bottom area between the screen border and between the input area and button. Button also seems wider than the input area which is probably missing a shadow due to elevation
See screenshots:
![Screenshot_2017-05-31-11-14-05](/uploads/4bb202defb5e3589d521318eb200d48a/Screenshot_2017-05-31-11-14-05.png)
![Screenshot_2017-05-31-11-22-04](/uploads/d37e09cf19b5ad2bc194c7a561289039/Screenshot_2017-05-31-11-22-04.png)https://code.briarproject.org/briar/briar/-/issues/960Contact Introduction confusions and redundancies2019-04-16T13:38:29ZErnir ErlingssonContact Introduction confusions and redundancies***Background***
This ticket lists all the issues observed during contact introduction during user testing and a robust internal test. Some of these might be "features" or already listed as issues in other tickets.
***Results***
...***Background***
This ticket lists all the issues observed during contact introduction during user testing and a robust internal test. Some of these might be "features" or already listed as issues in other tickets.
***Results***
1 Some testers were confused why nothing happened after accepting the introduction, confirming #923 .
2 It's possible for the same user to introduce the same two contacts as in a previous introduction even when the two contact's have not yet responded to the initial introduction. Multiple simultaneous introductions, with the same pair of contacts, were confusing for the introduction recipients.
3 If A has declined the introduction that information is not displayed for B until he/she has selected decline/accept introduction. I wonder if it would not be simplest just to display the rejection immediately before B answers ?
4 If two contact's are introduced to one-another that are already contacts, unbeknown to the introducer, there is no need to propagate rejections between the two contacts.
Ex. User's A and B are already connected. User C introduces A and B to one another, A decides to reject. B receives introduction from C but also the rejection from A, which caused confusion. In this case it would have been best to skip displaying the rejection entirely because it is completely irrelevant.https://code.briarproject.org/briar/briar/-/issues/959Large RSS imports take over the feed2017-08-01T15:42:01ZErnir ErlingssonLarge RSS imports take over the feedWhen testers imported RSS feeds, they complained that user blogs were too hard to find.
One suggested using two feeds: one for user blogs and the other for imported RSS feeds. User's could then switch between them with tabs.When testers imported RSS feeds, they complained that user blogs were too hard to find.
One suggested using two feeds: one for user blogs and the other for imported RSS feeds. User's could then switch between them with tabs.https://code.briarproject.org/briar/briar/-/issues/945Send Message Button bug2019-02-27T13:17:26ZThankgod RichardSend Message Button bugThe send button in the conversation don't send until you close the keyboard.The send button in the conversation don't send until you close the keyboard.https://code.briarproject.org/briar/briar/-/issues/943Use stable IDs in BriarAdapter2017-06-09T19:25:50ZJulian DehmUse stable IDs in BriarAdapterSince we already have everything at hand (a stable message id) we could use the stableId feature of the recyclerview to improve performance.
https://developer.android.com/reference/android/support/v7/widget/RecyclerView.Adapter.html#setH...Since we already have everything at hand (a stable message id) we could use the stableId feature of the recyclerview to improve performance.
https://developer.android.com/reference/android/support/v7/widget/RecyclerView.Adapter.html#setHasStableIds(boolean)https://code.briarproject.org/briar/briar/-/issues/940Update to the latest emoji2018-09-03T12:13:35ZakwizgranUpdate to the latest emojiSignal's emoji code and resources were updated in December 2016:
https://github.com/WhisperSystems/Signal-Android/commit/f7474362ff8bc75fff70ed75a1caad31fd55374e
New emoji were released in March 2017:
http://emojipedia.org/emoji-5.0/Signal's emoji code and resources were updated in December 2016:
https://github.com/WhisperSystems/Signal-Android/commit/f7474362ff8bc75fff70ed75a1caad31fd55374e
New emoji were released in March 2017:
http://emojipedia.org/emoji-5.0/Android 1.1akwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/936Create synchronous incoming sync session for integration tests2018-06-21T15:58:16ZakwizgranCreate synchronous incoming sync session for integration testsThe integration tests use various workarounds to deal with IncomingSession writing messages and acks to the DB asynchronously. Create a simple synchronous incoming session for tests so these workarounds can be removed.The integration tests use various workarounds to deal with IncomingSession writing messages and acks to the DB asynchronously. Create a simple synchronous incoming session for tests so these workarounds can be removed.https://code.briarproject.org/briar/briar/-/issues/934Potential SocksSocket resource leak2018-05-11T10:02:32ZJulian DehmPotential SocksSocket resource leakI've seen this a few times now in the log:
```
org.briarproject.briar I/ConnectionRegistryImpl: 1 contacts connected
04-10 12:35:19.584 4701-4712/org.briarproject.briar E/StrictMode: A resource was acquired at attached stack trace but...I've seen this a few times now in the log:
```
org.briarproject.briar I/ConnectionRegistryImpl: 1 contacts connected
04-10 12:35:19.584 4701-4712/org.briarproject.briar E/StrictMode: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.
java.lang.Throwable: Explicit termination method 'close' not called
at dalvik.system.CloseGuard.open(CloseGuard.java:180)
at java.net.AbstractPlainSocketImpl.create(AbstractPlainSocketImpl.java:103)
at java.net.Socket.createImpl(Socket.java:470)
at java.net.Socket.connect(Socket.java:603)
at org.briarproject.bramble.socks.SocksSocket.connect(SocksSocket.java:57)
at java.net.Socket.connect(Socket.java:554)
at org.briarproject.bramble.socks.SocksSocketFactory.createSocket(SocksSocketFactory.java:29)
at org.briarproject.bramble.plugin.tor.TorPlugin.createConnection(TorPlugin.java:577)
at org.briarproject.bramble.plugin.tor.TorPlugin$3.run(TorPlugin.java:551)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
at java.lang.Thread.run(Thread.java:761)
```https://code.briarproject.org/briar/briar/-/issues/931Check whether getSystemService() returns null2017-06-09T19:25:50ZakwizgranCheck whether getSystemService() returns nullWe call Context#getSystemService() in various places without checking the return value. Apparently it can return null, so we should check it.We call Context#getSystemService() in various places without checking the return value. Apparently it can return null, so we should check it.https://code.briarproject.org/briar/briar/-/issues/930Recent emoji page isn't updated2018-09-03T12:13:56ZakwizgranRecent emoji page isn't updatedSteps to reproduce:
* Choose an emoji from the first page (smilies)
* Switch to the recent emoji page
* Expected behaviour: the chosen emoji has been added to the page
* Actual behaviour: the chosen emoji isn't added until the page is de...Steps to reproduce:
* Choose an emoji from the first page (smilies)
* Switch to the recent emoji page
* Expected behaviour: the chosen emoji has been added to the page
* Actual behaviour: the chosen emoji isn't added until the page is destroyed and recreated
The recent emoji page is destroyed and recreated if you switch to any non-adjacent page, such as animals and plants, so the behaviour is inconsistent depending on which pages you switch to.
The problem occurs because the EmojiPageView doesn't know when its model has been updated. The model can keep a reference to the view (via some listener interface) to notify the view of changes, but the reference must be removed when the view is destroyed and restored when the view is recreated. I had a quick look at this but couldn't find a clean way to implement it in the current structure.Android 1.1akwizgranakwizgranhttps://code.briarproject.org/briar/briar/-/issues/923Tester expected contact to be added immediately after accepting introduction2018-12-19T12:22:16ZakwizgranTester expected contact to be added immediately after accepting introductionA tester expected that when she accepted an introduction the contact would be added to her contact list immediately. She didn't understand that the introducer was waiting for the other introducee's response.A tester expected that when she accepted an introduction the contact would be added to her contact list immediately. She didn't understand that the introducer was waiting for the other introducee's response.Torsten GroteTorsten Grotehttps://code.briarproject.org/briar/briar/-/issues/919Tester was confused by hidden composition area in forums and private groups2017-06-09T19:25:51ZakwizgranTester was confused by hidden composition area in forums and private groupsA tester thought she could only reply to messages in a private group but couldn't start new threads, because the composition area was hidden until she pressed reply. Another tester mentioned the same issue with forums in a previous test.A tester thought she could only reply to messages in a private group but couldn't start new threads, because the composition area was hidden until she pressed reply. Another tester mentioned the same issue with forums in a previous test.